Re: [PATCH 4/4] mt76: add support for reporting tx status with skb

2018-10-27 Thread Felix Fietkau
On 2018-10-27 17:04, Stanislaw Gruszka wrote: > On Thu, Oct 25, 2018 at 06:55:41PM +0200, Felix Fietkau wrote: >> +struct mt76_tx_cb *cb = mt76_tx_skb_cb(skb); >> +u8 done = MT_TX_CB_DMA_DONE | MT_TX_CB_TXS_DONE; > can be "const u8 done = ..." I think the compiler is smart enough to figure

Re: [PATCH 4/4] mt76: add support for reporting tx status with skb

2018-10-27 Thread Stanislaw Gruszka
On Thu, Oct 25, 2018 at 06:55:41PM +0200, Felix Fietkau wrote: > + struct mt76_tx_cb *cb = mt76_tx_skb_cb(skb); > + u8 done = MT_TX_CB_DMA_DONE | MT_TX_CB_TXS_DONE; can be "const u8 done = ..." > +mt76_tx_status_skb_add(struct mt76_dev *dev, struct mt76_wcid *wcid, > +

[PATCH 4/4] mt76: add support for reporting tx status with skb

2018-10-25 Thread Felix Fietkau
MT76x2/MT76x0 has somewhat unreliable tx status reporting, and for that reason the driver currently does not report per-skb tx ack status at all. This breaks things like client idle polling, which relies on the tx ack status of a transmitted nullfunc frame. This patch adds code to report