Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-11-05 Thread Hans de Goede
Hi, On 05-11-18 12:41, Arend van Spriel wrote: On 10/9/2018 2:47 PM, Hans de Goede wrote: For x86 based machines, set the board_type used for nvram file selection based on the DMI sys-vendor and product-name strings. Since on some models these strings are too generic, this commit also adds a

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-11-05 Thread Arend van Spriel
On 10/9/2018 2:47 PM, Hans de Goede wrote: For x86 based machines, set the board_type used for nvram file selection based on the DMI sys-vendor and product-name strings. Since on some models these strings are too generic, this commit also adds a quirk table overriding the strings for models

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-11-05 Thread Hans de Goede
Hi, On 10-10-18 10:15, Arend van Spriel wrote: On 10/10/2018 9:59 AM, Hans de Goede wrote: Any chance you could do a patch-review of this series? Yup and test for regressions with some of the chipsets I have here. Have you gotten around to review and testing this series yet? it would be

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-10 Thread Arend van Spriel
On 10/10/2018 9:59 AM, Hans de Goede wrote: Hi Arend, On 10-10-18 09:52, Arend van Spriel wrote: On 10/10/2018 9:28 AM, Hans de Goede wrote: So how do you want to proceed with this, do you want me to just put the full ISC text in the header for now as the rest of brcmfmac does? This is not

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-10 Thread Hans de Goede
Hi, On 10-10-18 09:57, Kalle Valo wrote: Arend van Spriel writes: On 10/10/2018 9:28 AM, Hans de Goede wrote: So how do you want to proceed with this, do you want me to just put the full ISC text in the header for now as the rest of brcmfmac does? This is not entirely true as far as I

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-10 Thread Hans de Goede
Hi Arend, On 10-10-18 09:52, Arend van Spriel wrote: On 10/10/2018 9:28 AM, Hans de Goede wrote: So how do you want to proceed with this, do you want me to just put the full ISC text in the header for now as the rest of brcmfmac does? This is not entirely true as far as I know. I assume you

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-10 Thread Kalle Valo
Arend van Spriel writes: > On 10/10/2018 9:28 AM, Hans de Goede wrote: >> So how do you want to proceed with this, do you want me to just >> put the full ISC text in the header for now as the rest of brcmfmac >> does? > > This is not entirely true as far as I know. I assume you are referring >

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-10 Thread Arend van Spriel
On 10/10/2018 9:28 AM, Hans de Goede wrote: So how do you want to proceed with this, do you want me to just put the full ISC text in the header for now as the rest of brcmfmac does? This is not entirely true as far as I know. I assume you are referring to this: /* * Copyright (c) 2010

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-10 Thread Kalle Valo
Hans de Goede writes: > Hi, > > On 10-10-18 09:09, Kalle Valo wrote: >> Hans de Goede writes: >> >>> For x86 based machines, set the board_type used for nvram file selection >>> based on the DMI sys-vendor and product-name strings. >>> >>> Since on some models these strings are too generic,

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-10 Thread Hans de Goede
Hi, On 10-10-18 09:09, Kalle Valo wrote: Hans de Goede writes: For x86 based machines, set the board_type used for nvram file selection based on the DMI sys-vendor and product-name strings. Since on some models these strings are too generic, this commit also adds a quirk table overriding

Re: [PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-10 Thread Kalle Valo
Hans de Goede writes: > For x86 based machines, set the board_type used for nvram file selection > based on the DMI sys-vendor and product-name strings. > > Since on some models these strings are too generic, this commit also adds > a quirk table overriding the strings for models listed in that

[PATCH 5/6] brcmfmac: Set board_type from DMI on x86 based machines

2018-10-09 Thread Hans de Goede
For x86 based machines, set the board_type used for nvram file selection based on the DMI sys-vendor and product-name strings. Since on some models these strings are too generic, this commit also adds a quirk table overriding the strings for models listed in that table. The board_type setting is