Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz sa...@linux.intel.com wrote: + /* If a patch was applied the new version is checked */ + if (patched) { + r = nci_init(ndev); + if (r)

Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-04-01 Thread Robert Dolca
On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz sa...@linux.intel.com wrote: + /* If a patch was applied the new version is checked */ + if (patched) { + r = nci_init(ndev); + if (r) + goto error; + + r =

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-03-26 Thread Samuel Ortiz
Robert, Another comment: On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: +static struct i2c_device_id fdp_nci_i2c_id_table[] = { + {INT339A, 0}, + {} +}; + +MODULE_DEVICE_TABLE(i2c, fdp_nci_i2c_id_table); + + +static const struct acpi_device_id

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-03-26 Thread Mika Westerberg
On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: +static struct i2c_device_id fdp_nci_i2c_id_table[] = { + {INT339A, 0}, If this is ACPI only device you can remove the above line. + {} +}; + +MODULE_DEVICE_TABLE(i2c, fdp_nci_i2c_id_table); And this as well. + +

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-03-25 Thread Samuel Ortiz
Hi Robert, On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: The device can be enumerated using ACPI using the id INT339A. Please give us some more details about the device. NCI ? HCI ? Features ? What does the initial patchset support ? +config NFC_FDP + tristate Intel FDP

[PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-02-24 Thread Robert Dolca
The device can be enumerated using ACPI using the id INT339A. The 1st GPIO is the IRQ and the 2nd is the RESET pin. I can be also enumerated using platform init. Signed-off-by: Robert Dolca robert.do...@intel.com --- drivers/nfc/Kconfig | 1 + drivers/nfc/fdp/Kconfig |

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-02-24 Thread Johannes Berg
I have no idea about NFC, but +config NFC_FDP + tristate Intel FDP NFC driver + depends on NFC_NCI + select CRC_CCITT + default n + ---help--- + Intel FDP core driver. + This is a driver based on the NCI NFC kernel layers. + + To compile this

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-02-24 Thread Robert Dolca
On Tue, Feb 24, 2015 at 11:33:10AM +0100, Johannes Berg wrote: +config NFC_FDP + tristate Intel FDP NFC driver + depends on NFC_NCI + select CRC_CCITT + default n + ---help--- + Intel FDP core driver. + This is a driver based on the NCI NFC kernel layers. + +