Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

2018-08-02 Thread Ajay Singh
Hi Greg, On Thu, 2 Aug 2018 09:34:54 +0200 Greg KH wrote: > On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote: > > Cleanup patch to fix below checkpatch reported issue: > > -#define ISWILC1000(id) ((id & 0xf000) > > == 0x10 ? 1 : 0) +#define ISWILC1000(id)

Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

2018-08-02 Thread Greg KH
On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote: > Cleanup patch to fix below checkpatch reported issue: > > Macro argument 'id' may be better as '(id)' to avoid precedence issues > > Also updated the TODO file to remove the below item > 'rework comments and function headers(also

[PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

2018-07-29 Thread Ajay Singh
Cleanup patch to fix below checkpatch reported issue: Macro argument 'id' may be better as '(id)' to avoid precedence issues Also updated the TODO file to remove the below item 'rework comments and function headers(also coding style)' Signed-off-by: Ajay Singh ---