Re: [PATCH MOREWORK 14/19] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring

2016-04-12 Thread Andrea Merello
On Mon, Apr 11, 2016 at 2:11 AM, Julian Calaby wrote: > Hi Andrea, > > On Sat, Apr 9, 2016 at 4:56 AM, Andrea Merello > wrote: >> >> On Fri, Mar 18, 2016 at 3:27 AM, Julian Calaby >> wrote: >>> From: Jia-Ju Bai

Re: [PATCH MOREWORK 14/19] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring

2016-04-10 Thread Julian Calaby
Hi Andrea, On Sat, Apr 9, 2016 at 4:56 AM, Andrea Merello wrote: > > On Fri, Mar 18, 2016 at 3:27 AM, Julian Calaby > wrote: >> From: Jia-Ju Bai >> >> When dev_alloc_skb or pci_dma_mapping_error in rtl8180_init_rx_ring

Re: [PATCH MOREWORK 14/19] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring

2016-04-07 Thread Julian Calaby
Hi all, Could someone please review this? On Fri, Mar 18, 2016 at 1:27 PM, Julian Calaby wrote: > From: Jia-Ju Bai > > When dev_alloc_skb or pci_dma_mapping_error in rtl8180_init_rx_ring fails, > the memory allocated by pci_zalloc_consistent is

[PATCH MOREWORK 14/19] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring

2016-03-19 Thread Julian Calaby
From: Jia-Ju Bai When dev_alloc_skb or pci_dma_mapping_error in rtl8180_init_rx_ring fails, the memory allocated by pci_zalloc_consistent is not freed. This patch fixes the bug by adding pci_free_consistent in error handling code. Signed-off-by: Jia-Ju Bai