Re: [PATCH RFC v3 2/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-12 Thread Rajkumar Manoharan
On 2018-09-12 04:10, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: On 2018-09-10 04:13, Toke Høiland-Jørgensen wrote: Johannes Berg writes: - txqi->flags & (1flags & (1<: ""); + txqi->flags & (1 << IEEE80211_TXQ_

Re: [PATCH RFC v3 2/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-12 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: > On 2018-09-10 04:13, Toke Høiland-Jørgensen wrote: >> Johannes Berg writes: - txqi->flags & (1<>>> "RUN", - txqi->flags & (1<>>> AMPDU" : "", - txqi->flags & (1<>>> NO-AMSDU" : >>

Re: [PATCH RFC v3 2/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-11 Thread Rajkumar Manoharan
On 2018-09-10 04:13, Toke Høiland-Jørgensen wrote: Johannes Berg writes: - txqi->flags & (1flags & (1<""); + txqi->flags & (1 << IEEE80211_TXQ_STOP) ? "STOP" : "RUN", + txqi->fl

Re: [PATCH RFC v3 2/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-10 Thread Johannes Berg
On Mon, 2018-09-10 at 13:13 +0200, Toke Høiland-Jørgensen wrote: > > Yeah, this is the API that would be used by drivers where the actual > scheduling of TXQs is done by the hardware (i.e., ath10k in pull/push > mode, and iwlwifi if I understand you correctly); whereas the next_txq() > call is for

Re: [PATCH RFC v3 2/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-10 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Sat, 2018-09-08 at 00:22 +0200, Toke Høiland-Jørgensen wrote: >> >> +/** >> + * ieee80211_airtime_may_transmit - check whether TXQ is allowed to transmit >> + * >> + * This function is used to check whether given txq is allowed to transmit >> by >> + * the airtime sch

Re: [PATCH RFC v3 2/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-10 Thread Johannes Berg
On Sat, 2018-09-08 at 00:22 +0200, Toke Høiland-Jørgensen wrote: > > +/** > + * ieee80211_airtime_may_transmit - check whether TXQ is allowed to transmit > + * > + * This function is used to check whether given txq is allowed to transmit by > + * the airtime scheduler, and can be used by drivers t

[PATCH RFC v3 2/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-07 Thread Toke Høiland-Jørgensen
This adds airtime accounting and scheduling to the mac80211 TXQ scheduler. A new callback, ieee80211_sta_register_airtime(), is added that drivers can call to report airtime usage for stations. When airtime information is present, mac80211 will schedule TXQs (through ieee80211_next_txq()) in a way