Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-03 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: > On 2018-10-02 16:07, Rajkumar Manoharan wrote: >> On 2018-10-02 12:00, Toke Høiland-Jørgensen wrote: >>> Rajkumar Manoharan writes: I noticed a race condition b/w sta cleanup and kick_airtime tasklet. >> How do you plan to exit kick_airtime gracefully

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-03 Thread Rajkumar Manoharan
On 2018-10-02 22:53, Rajkumar Manoharan wrote: Shouldn't have to call next_txq(). It should be as below. Anyway drv_wake_tx_queue is just an indication to driver and driver will always dequeue first node from list. diff --git a/net/mac80211/util.c b/net/mac80211/util.c index

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-02 Thread Rajkumar Manoharan
On 2018-10-02 16:07, Rajkumar Manoharan wrote: On 2018-10-02 12:00, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: I noticed a race condition b/w sta cleanup and kick_airtime tasklet. How do you plan to exit kick_airtime gracefully during sta_cleanup? Ah, right, there's a lot of

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-02 Thread Rajkumar Manoharan
On 2018-10-02 12:00, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: I noticed a race condition b/w sta cleanup and kick_airtime tasklet. How do you plan to exit kick_airtime gracefully during sta_cleanup? Ah, right, there's a lot of stuff going on before we get to purge_txq.

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-02 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: > On 2018-10-02 01:22, Toke Høiland-Jørgensen wrote: >> Rajkumar Manoharan writes: >> Great! I'll fold in the rest, test it with ath9k and submit as a proper patch :) >>> Toke, >>> >>> I noticed a race condition b/w sta cleanup and kick_airtime

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-02 Thread Rajkumar Manoharan
On 2018-10-02 01:22, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: Great! I'll fold in the rest, test it with ath9k and submit as a proper patch :) Toke, I noticed a race condition b/w sta cleanup and kick_airtime tasklet. How do you plan to exit kick_airtime gracefully during

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-02 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: >> Great! I'll fold in the rest, test it with ath9k and submit as a proper >> patch :) >> > Toke, > > I noticed a race condition b/w sta cleanup and kick_airtime tasklet. > How do you plan to exit kick_airtime gracefully during sta_cleanup? Ah, right, there's a lot

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-02 Thread Rajkumar Manoharan
On 2018-10-01 23:58, Rajkumar Manoharan wrote: Great! I'll fold in the rest, test it with ath9k and submit as a proper patch :) Toke, I noticed a race condition b/w sta cleanup and kick_airtime tasklet. How do you plan to exit kick_airtime gracefully during sta_cleanup? If kick_airtime

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-02 Thread Rajkumar Manoharan
Great! I'll fold in the rest, test it with ath9k and submit as a proper patch :) Toke, I noticed a race condition b/w sta cleanup and kick_airtime tasklet. How do you plan to exit kick_airtime gracefully during sta_cleanup? -Rajkumar

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-28 Thread Rajkumar Manoharan
On 2018-09-28 04:02, Toke Høiland-Jørgensen wrote: On 28 September 2018 12:47:51 CEST, Rajkumar Manoharan wrote: On 2018-09-28 03:35, Jonathan Morton wrote: On 28 Sep, 2018, at 1:19 pm, Rajkumar Manoharan wrote: This is going to break fairness; we only want to increase deficits when all

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-28 Thread Toke Høiland-Jørgensen
On 28 September 2018 12:47:51 CEST, Rajkumar Manoharan wrote: >On 2018-09-28 03:35, Jonathan Morton wrote: >>> On 28 Sep, 2018, at 1:19 pm, Rajkumar Manoharan >>> wrote: >>> This is going to break fairness; we only want to increase deficits when all stations' deficits are

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-28 Thread Rajkumar Manoharan
On 2018-09-28 03:35, Jonathan Morton wrote: On 28 Sep, 2018, at 1:19 pm, Rajkumar Manoharan wrote: This is going to break fairness; we only want to increase deficits when all stations' deficits are negative. Hence the two loops. Did you see any problems with those specifically? No. I

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-28 Thread Jonathan Morton
> On 28 Sep, 2018, at 1:19 pm, Rajkumar Manoharan > wrote: > >> This is going to break fairness; we only want to increase deficits when >> all stations' deficits are negative. Hence the two loops. Did you see >> any problems with those specifically? > > No. I didn't see any issue but the loop

Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-28 Thread Rajkumar Manoharan
On 2018-09-28 02:58, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: On 2018-09-28 00:51, Toke Høiland-Jørgensen wrote: On 28 September 2018 07:29:03 CEST, Rajkumar Manoharan wrote: On 2018-09-26 17:09, Rajkumar Manoharan wrote: On 2018-09-26 02:22, Toke Høiland-Jørgensen wrote:

Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-28 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: > On 2018-09-28 00:51, Toke Høiland-Jørgensen wrote: >> On 28 September 2018 07:29:03 CEST, Rajkumar Manoharan >> wrote: >>> On 2018-09-26 17:09, Rajkumar Manoharan wrote: On 2018-09-26 02:22, Toke Høiland-Jørgensen wrote: > Rajkumar Manoharan writes: >>>

Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-28 Thread Rajkumar Manoharan
On 2018-09-28 02:27, Rajkumar Manoharan wrote: On 2018-09-28 00:51, Toke Høiland-Jørgensen wrote: On 28 September 2018 07:29:03 CEST, Rajkumar Manoharan wrote: On 2018-09-26 17:09, Rajkumar Manoharan wrote: On 2018-09-26 02:22, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: :(

Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-28 Thread Rajkumar Manoharan
On 2018-09-28 00:51, Toke Høiland-Jørgensen wrote: On 28 September 2018 07:29:03 CEST, Rajkumar Manoharan wrote: On 2018-09-26 17:09, Rajkumar Manoharan wrote: On 2018-09-26 02:22, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: :( Yeah... I got confused with attached soft

Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-27 Thread Rajkumar Manoharan
On 2018-09-26 17:09, Rajkumar Manoharan wrote: On 2018-09-26 02:22, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: :( Yeah... I got confused with attached soft lockup in ARM platform. Toke, Cause for the soft lockup exposed in multi client scenario is due to mixed order of

Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-26 Thread Rajkumar Manoharan
On 2018-09-26 02:22, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: On 2018-09-16 10:42, Toke Høiland-Jørgensen wrote: + if (ret) { + clear_bit(IEEE80211_TXQ_AIRTIME_THROTTLE, >flags); + list_del_init(>schedule_order); + } else +

Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-26 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: > On 2018-09-16 10:42, Toke Høiland-Jørgensen wrote: >> This adds airtime accounting and scheduling to the mac80211 TXQ >> scheduler. A new callback, ieee80211_sta_register_airtime(), is added >> that drivers can call to report airtime usage for stations. >> >> +bool

Re: [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-26 Thread Rajkumar Manoharan
On 2018-09-16 10:42, Toke Høiland-Jørgensen wrote: This adds airtime accounting and scheduling to the mac80211 TXQ scheduler. A new callback, ieee80211_sta_register_airtime(), is added that drivers can call to report airtime usage for stations. +bool ieee80211_txq_may_transmit(struct

[PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-09-16 Thread Toke Høiland-Jørgensen
This adds airtime accounting and scheduling to the mac80211 TXQ scheduler. A new callback, ieee80211_sta_register_airtime(), is added that drivers can call to report airtime usage for stations. When airtime information is present, mac80211 will schedule TXQs (through ieee80211_next_txq()) in a