Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread Johannes Berg
On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote: Use the built-in function instead of memset. Please don't use foo in the title, especially not if the patch only introduces usage of eth_zero_addr(). It's easier to look for in the commit log without it. Other than that, I guess I'll apply

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread David Miller
From: Joe Perches j...@perches.com Date: Tue, 03 Mar 2015 11:03:17 -0800 On Tue, 2015-03-03 at 13:57 -0500, David Miller wrote: From: Johannes Berg johan...@sipsolutions.net Date: Tue, 03 Mar 2015 09:16:57 +0100 Other than that, I guess I'll apply this, but I really wish there was a way

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread David Miller
From: Johannes Berg johan...@sipsolutions.net Date: Tue, 03 Mar 2015 09:16:57 +0100 Other than that, I guess I'll apply this, but I really wish there was a way to distinguish more easily which of these require alignment and which don't. You can't apply this without the dependency patch #1.

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread Johannes Berg
On Tue, 2015-03-03 at 13:57 -0500, David Miller wrote: From: Johannes Berg johan...@sipsolutions.net Date: Tue, 03 Mar 2015 09:16:57 +0100 Other than that, I guess I'll apply this, but I really wish there was a way to distinguish more easily which of these require alignment and which

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread Joe Perches
On Tue, 2015-03-03 at 13:57 -0500, David Miller wrote: From: Johannes Berg johan...@sipsolutions.net Date: Tue, 03 Mar 2015 09:16:57 +0100 Other than that, I guess I'll apply this, but I really wish there was a way to distinguish more easily which of these require alignment and which

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread Johannes Berg
Other than that, I guess I'll apply this, but I really wish there was a way to distinguish more easily which of these require alignment and which don't. My guess is the eth_zero_addr and eth_broadcast functions are always taking aligned(2) arguments, just like all the is_foo_ether_addr

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread Joe Perches
On Tue, 2015-03-03 at 10:00 +0100, Johannes Berg wrote: On Tue, 2015-03-03 at 00:52 -0800, Joe Perches wrote: My guess is the eth_zero_addr and eth_broadcast functions are always taking aligned(2) arguments, just like all the is_foo_ether_addr functions. Err, are you

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread Johannes Berg
On Tue, 2015-03-03 at 02:29 -0800, Joe Perches wrote: Nope, you simply misunderstood what I did write. What I said was that the arguments were likely already aligned(2), not that the alignment was a requirement. Fair enough. That's not actually true/guaranteed though as far as this patch

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread Joe Perches
On Tue, 2015-03-03 at 09:44 +0100, Johannes Berg wrote: Other than that, I guess I'll apply this, but I really wish there was a way to distinguish more easily which of these require alignment and which don't. My guess is the eth_zero_addr and eth_broadcast functions are always

Re: [PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-03 Thread Joe Perches
On Tue, 2015-03-03 at 09:16 +0100, Johannes Berg wrote: On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote: Use the built-in function instead of memset. Please don't use foo in the title, especially not if the patch only introduces usage of eth_zero_addr(). It's easier to look for in the

[PATCH net-next 13/14] wireless: Use eth_foo_addr instead of memset

2015-03-02 Thread Joe Perches
Use the built-in function instead of memset. Signed-off-by: Joe Perches j...@perches.com --- net/wireless/ibss.c | 2 +- net/wireless/nl80211.c | 4 ++-- net/wireless/trace.h| 9 + net/wireless/wext-sme.c | 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git