Re: [PATCH v2] mac80211: Encrypt "Group addressed privacy" action frames

2016-06-22 Thread Masashi Honma
On 2016年06月22日 01:42, Jouni Malinen wrote: This is somewhat problematic since no indication of the frame length is passed in here and we are reading beyond the frame header below.. Maybe this should use the same style as ieee80211_is_robust_mgmt_frame() instead, i.e., use skb as the argument and

Re: [PATCH v2] mac80211: Encrypt "Group addressed privacy" action frames

2016-06-21 Thread Jouni Malinen
On Tue, Jun 21, 2016 at 03:23:39PM +0900, Masashi Honma wrote: > diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h > +static inline bool ieee80211_is_group_privacy_action(struct ieee80211_hdr > *hdr) This is somewhat problematic since no indication of the frame length is passed

[PATCH v2] mac80211: Encrypt "Group addressed privacy" action frames

2016-06-21 Thread Masashi Honma
Previously, the action frames to group address was not encrypted. But [1] "Table 8-38 Category values" indicates "Mesh" and "Multihop" category action frames should be encrypted (Group addressed privacy == yes). And the encyption key should be MGTK ([1] 10.13 Group addressed robust management frame