Re: [PATCH v2] rsi: remove unecessary PTR_ALIGN()s

2018-04-06 Thread Kalle Valo
Arend van Spriel writes: > On 4/6/2018 10:37 AM, Dan Carpenter wrote: >> The issue here is that we allocate "data" and then set >> "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer >> instead of the original pointer. >> >> kmalloc() pointers are

Re: [PATCH v2] rsi: remove unecessary PTR_ALIGN()s

2018-04-06 Thread Arend van Spriel
On 4/6/2018 10:37 AM, Dan Carpenter wrote: The issue here is that we allocate "data" and then set "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer instead of the original pointer. kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or more on everything except

[PATCH v2] rsi: remove unecessary PTR_ALIGN()s

2018-04-06 Thread Dan Carpenter
The issue here is that we allocate "data" and then set "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer instead of the original pointer. kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or more on everything except certain Xtensa variants. We decided that if