Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

2017-03-09 Thread Hans de Goede
Hi, On 09-03-17 09:17, Arend Van Spriel wrote: On 9-3-2017 9:09, Hans de Goede wrote: Hi all, On 08-03-17 21:44, Arend Van Spriel wrote: On 8-3-2017 18:53, Joe Perches wrote: On Wed, 2017-03-08 at 17:57 +0100, Hans de Goede wrote: Hi, And hello back to you. Also hello. On 08-03-17

Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

2017-03-09 Thread Arend Van Spriel
On 9-3-2017 9:09, Hans de Goede wrote: > Hi all, > > On 08-03-17 21:44, Arend Van Spriel wrote: >> >> >> On 8-3-2017 18:53, Joe Perches wrote: >>> On Wed, 2017-03-08 at 17:57 +0100, Hans de Goede wrote: Hi, >>> >>> And hello back to you. >> >> Also hello. >> On 08-03-17 17:34, Joe

Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

2017-03-09 Thread Hans de Goede
Hi all, On 08-03-17 21:44, Arend Van Spriel wrote: On 8-3-2017 18:53, Joe Perches wrote: On Wed, 2017-03-08 at 17:57 +0100, Hans de Goede wrote: Hi, And hello back to you. Also hello. On 08-03-17 17:34, Joe Perches wrote: On Wed, 2017-03-08 at 09:23 +0100, Hans de Goede wrote: Using

Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Arend Van Spriel
On 8-3-2017 18:53, Joe Perches wrote: > On Wed, 2017-03-08 at 17:57 +0100, Hans de Goede wrote: >> Hi, > > And hello back to you. Also hello. >> On 08-03-17 17:34, Joe Perches wrote: >>> On Wed, 2017-03-08 at 09:23 +0100, Hans de Goede wrote: Using pr_err for things which are not errors

Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Joe Perches
On Wed, 2017-03-08 at 17:57 +0100, Hans de Goede wrote: > Hi, And hello back to you. > On 08-03-17 17:34, Joe Perches wrote: > > On Wed, 2017-03-08 at 09:23 +0100, Hans de Goede wrote: > > > Using pr_err for things which are not errors is a bad idea. E.g. it > > > will cause the plymouth

Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Hans de Goede
Hi, On 08-03-17 17:34, Joe Perches wrote: On Wed, 2017-03-08 at 09:23 +0100, Hans de Goede wrote: Using pr_err for things which are not errors is a bad idea. E.g. it will cause the plymouth bootsplash screen to drop back to the text console so that the user can see the error, which is not what

Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Joe Perches
On Wed, 2017-03-08 at 09:23 +0100, Hans de Goede wrote: > Using pr_err for things which are not errors is a bad idea. E.g. it > will cause the plymouth bootsplash screen to drop back to the text > console so that the user can see the error, which is not what we > normally want to happen. > >

[PATCH v3] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Hans de Goede
Using pr_err for things which are not errors is a bad idea. E.g. it will cause the plymouth bootsplash screen to drop back to the text console so that the user can see the error, which is not what we normally want to happen. Instead add a new brcmf_info macro and use that. Signed-off-by: Hans de