Re: [PATCH v3] brcmsmac: AP mode: update beacon when TIM changes

2018-09-26 Thread Ali MJ Al-Nasrawy
Hi, I suggest here some improvements to this patch but I don't have strong opinion about them so any feedback is appreciated: -split it into two: one for storing the current vif into brcms_c_info and also setting it to NULL on remove_interface to avoid dangling pointers; and an other one for actu

Re: [PATCH v3] brcmsmac: AP mode: update beacon when TIM changes

2018-09-24 Thread Ali MJ Al-Nasrawy
On Mon, 24 Sep 2018 10:15:49 +0200 Arend van Spriel wrote: > On 9/23/2018 11:54 AM, Ali MJ Al-Nasrawy wrote: > > Beacons are not updated to reflect TIM changes. This is not > > compliant with power-saving client stations as the beacons do not > > have valid TIM and can cause the network to stall

Re: [PATCH v3] brcmsmac: AP mode: update beacon when TIM changes

2018-09-24 Thread Arend van Spriel
On 9/23/2018 11:54 AM, Ali MJ Al-Nasrawy wrote: Beacons are not updated to reflect TIM changes. This is not compliant with power-saving client stations as the beacons do not have valid TIM and can cause the network to stall at random occasions with highly variable latencies. Fix it by updating be

[PATCH v3] brcmsmac: AP mode: update beacon when TIM changes

2018-09-23 Thread Ali MJ Al-Nasrawy
Beacons are not updated to reflect TIM changes. This is not compliant with power-saving client stations as the beacons do not have valid TIM and can cause the network to stall at random occasions with highly variable latencies. Fix it by updating beacon templates on mac80211 set_tim callback. Addr