Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-14 Thread Kalle Valo
Stanislaw Gruszka writes: > Hi > > On Fri, Jan 13, 2017 at 04:50:32AM +0100, Daniel Golle wrote: >> Please review and comment, so we can get those patches merged! > > As already pointed by Kalle posting patches to mailing list is better > way for review. Posing patches is

Re: [OpenWrt-Devel] [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Daniel Golle
On Fri, Jan 13, 2017 at 05:17:23PM +0100, Daniel Golle wrote: > On Fri, Jan 13, 2017 at 04:59:59PM +0100, Johannes Berg wrote: > > > > > The advantage of pull requests is that author information can be > > > preserved more easily. Running git format-patch results in most > > > patches > > >

Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Christian Lamparter
On Friday, January 13, 2017 4:46:30 PM CET Daniel Golle wrote: > On Fri, Jan 13, 2017 at 12:46:56PM +0200, Kalle Valo wrote: > > Daniel Golle writes: > > > ... > > > Please review and comment, so we can get those patches merged! > > > > No pull requests, please. Instead

Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Daniel Golle
On Fri, Jan 13, 2017 at 04:59:59PM +0100, Johannes Berg wrote: > > > The advantage of pull requests is that author information can be > > preserved more easily. Running git format-patch results in most > > patches > > having wrong SMTP sender information due to the assumption that the > > patch

Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Johannes Berg
> The advantage of pull requests is that author information can be > preserved more easily. Running git format-patch results in most > patches > having wrong SMTP sender information due to the assumption that the > patch author is the same person also submitting the patch. > So in practise, this

Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Daniel Golle
Hi Kalle, On Fri, Jan 13, 2017 at 12:46:56PM +0200, Kalle Valo wrote: > Daniel Golle writes: > > ... > > Please review and comment, so we can get those patches merged! > > No pull requests, please. Instead send these as patches, easier to > review and actually also easier

Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Stanislaw Gruszka
Hi On Fri, Jan 13, 2017 at 04:50:32AM +0100, Daniel Golle wrote: > Please review and comment, so we can get those patches merged! As already pointed by Kalle posting patches to mailing list is better way for review. Posing patches is easy with git-format-patch and git-send-email. Ideally patch

Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Kalle Valo
Daniel Golle writes: > In preparation to be submitted upstream I started to clean up a huge > pile of patches for rt2x00 we have been carrying along for quite a > while (some for more than half a decade!). > Some of them are fixes, most importantly Serge Vasilugin fixed

[RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-12 Thread Daniel Golle
Hi! In preparation to be submitted upstream I started to clean up a huge pile of patches for rt2x00 we have been carrying along for quite a while (some for more than half a decade!). Some of them are fixes, most importantly Serge Vasilugin fixed setting the HT20/HT40 filter which got us much