Re: [RFC] cfg80211: Add feature flag for 4-way handshake offload

2014-12-18 Thread Arend van Spriel
On 12/18/14 14:31, Johannes Berg wrote: On Thu, 2014-12-18 at 13:51 +0100, Arend van Spriel wrote: Here the proposed way to deal with new feature flags. Let me know if this is suitable. I guess that works. I think those functions should be inlines - no point in having them with export symbol

Re: [RFC] cfg80211: Add feature flag for 4-way handshake offload

2014-12-18 Thread Eliad Peller
hi Arend, On Thu, Dec 18, 2014 at 5:21 PM, Arend van Spriel wrote: > On 12/18/14 14:44, Eliad Peller wrote: >> On Thu, Dec 18, 2014 at 2:51 PM, Arend van Spriel >> wrote: >>> >>> From: Gautam Kumar Shukla >>> >>> The new feature flag allows the driver to indicate that it can >>> offload the 4-way

Re: [RFC] cfg80211: Add feature flag for 4-way handshake offload

2014-12-18 Thread Arend van Spriel
On 12/18/14 14:44, Eliad Peller wrote: hi, On Thu, Dec 18, 2014 at 2:51 PM, Arend van Spriel wrote: From: Gautam Kumar Shukla The new feature flag allows the driver to indicate that it can offload the 4-way handshake for WPA/RSN-PSK. With the wiphy::features flag being used up this patch adds

Re: [RFC] cfg80211: Add feature flag for 4-way handshake offload

2014-12-18 Thread Johannes Berg
On Thu, 2014-12-18 at 15:44 +0200, Eliad Peller wrote: > > u32 flags, regulatory_flags, features; > > + u8 ext_features[1]; > > > i think it would be nicer to use unsigned long (instead of u8) along > with BITS_TO_LONGS That works in the kernel, but not in the userspace API. We can d

Re: [RFC] cfg80211: Add feature flag for 4-way handshake offload

2014-12-18 Thread Eliad Peller
hi, On Thu, Dec 18, 2014 at 2:51 PM, Arend van Spriel wrote: > From: Gautam Kumar Shukla > > The new feature flag allows the driver to indicate that it can > offload the 4-way handshake for WPA/RSN-PSK. With the > wiphy::features flag being used up this patch adds a new > field wiphy::ext_featur

Re: [RFC] cfg80211: Add feature flag for 4-way handshake offload

2014-12-18 Thread Johannes Berg
On Thu, 2014-12-18 at 13:51 +0100, Arend van Spriel wrote: > Here the proposed way to deal with new feature flags. Let > me know if this is suitable. I guess that works. I think those functions should be inlines - no point in having them with export symbol etc (the structures needed for that are

[RFC] cfg80211: Add feature flag for 4-way handshake offload

2014-12-18 Thread Arend van Spriel
From: Gautam Kumar Shukla The new feature flag allows the driver to indicate that it can offload the 4-way handshake for WPA/RSN-PSK. With the wiphy::features flag being used up this patch adds a new field wiphy::ext_features. Considering extensibility this new field is declared as a byte array.