Re: [RFC] mac80211: advertise supported interface types for sw encryption

2018-03-22 Thread mpubbise
On 2018-03-22 13:36, Johannes Berg wrote: On Thu, 2018-03-22 at 11:51 +0530, mpubb...@codeaurora.org wrote: > So IMHO - just get rid of the bitmap and hard-code AP_VLAN. > I agree with you only partially. Today, I do not see any driver advertising SW_CRYPTO_CONTROL other than ath10k. There

Re: [RFC] mac80211: advertise supported interface types for sw encryption

2018-03-22 Thread Johannes Berg
On Thu, 2018-03-22 at 11:51 +0530, mpubb...@codeaurora.org wrote: > > > So IMHO - just get rid of the bitmap and hard-code AP_VLAN. > > > > I agree with you only partially. > > Today, I do not see any driver advertising SW_CRYPTO_CONTROL other than > ath10k. There could be some driver which wo

Re: [RFC] mac80211: advertise supported interface types for sw encryption

2018-03-21 Thread mpubbise
On 2018-03-21 13:23, Johannes Berg wrote: On Fri, 2018-03-09 at 11:57 +0530, mpubb...@codeaurora.org wrote: From: Manikanta Pubbisetty Extending SW_CRYPTO_CONTROL interface so that drivers can advertise the interface types on which they can support software encryption. Driver's job is not done

Re: [RFC] mac80211: advertise supported interface types for sw encryption

2018-03-21 Thread Johannes Berg
On Fri, 2018-03-09 at 11:57 +0530, mpubb...@codeaurora.org wrote: > From: Manikanta Pubbisetty > > Extending SW_CRYPTO_CONTROL interface so that drivers can advertise > the interface types on which they can support software encryption. > Driver's job is not done by advertising the supported vif t

[RFC] mac80211: advertise supported interface types for sw encryption

2018-03-08 Thread mpubbise
From: Manikanta Pubbisetty Extending SW_CRYPTO_CONTROL interface so that drivers can advertise the interface types on which they can support software encryption. Driver's job is not done by advertising the supported vif types alone, they should also return -EOPNOTSUPP from set_key. Mac80211 will