Re: [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

2018-03-28 Thread Johannes Berg
On Wed, 2018-03-28 at 14:20 +0530, vthia...@codeaurora.org wrote: > > > Btw, we should probably also have a way to *delete* the per-station > > configuration, so it uses the default again? > > Sure. How about setting it to default when the command is received with > no NL80211_ATTR_NOACK_MAP att

Re: [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

2018-03-28 Thread vthiagar
On 2018-03-28 13:36, Johannes Berg wrote: On Wed, 2018-03-28 at 10:24 +0530, vthia...@codeaurora.org wrote: > The question is how that interacts with having enough space - are you > sure this is a concern? This will not be an issue at lest for ath10k. This is mainly for a (new)driver which imp

Re: [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

2018-03-28 Thread Johannes Berg
On Wed, 2018-03-28 at 10:24 +0530, vthia...@codeaurora.org wrote: > > The question is how that interacts with having enough space - are you > > sure this is a concern? > > This will not be an issue at lest for ath10k. This is mainly for a > (new)driver > which implements the offload but has limi

Re: [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

2018-03-27 Thread vthiagar
On 2018-03-27 18:17, Johannes Berg wrote: On Tue, 2018-03-27 at 14:12 +0530, Vasanthakumar Thiagarajan wrote: - * @set_noack_map: Set the NoAck Map for the TIDs. + * @set_noack_map: Set the NoAck Map for the TIDs. When peer is not %NULL NoAck + * map will be applied for that particular peer. W

Re: [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

2018-03-27 Thread Johannes Berg
On Tue, 2018-03-27 at 14:12 +0530, Vasanthakumar Thiagarajan wrote: > > - * @set_noack_map: Set the NoAck Map for the TIDs. > + * @set_noack_map: Set the NoAck Map for the TIDs. When peer is not %NULL > NoAck > + * map will be applied for that particular peer. When peer is %NULL NoAck > + * m

[RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

2018-03-27 Thread Vasanthakumar Thiagarajan
Provides peer level NoAck policy configuration by extending NL80211_CMD_SET_NOACK_MAP command with peer MAC address. If user space does not give any peer mac address, the driver should retain the existing functionality of applying the NoAck policy for all the staions connected to the netdev. Peer s