Re: [RFC v2] device coredump: add new device coredump class

2014-09-12 Thread Greg Kroah-Hartman
On Mon, Sep 08, 2014 at 10:38:07AM +0200, Johannes Berg wrote: > On Fri, 2014-09-05 at 15:13 -0700, Greg Kroah-Hartman wrote: > > > > + /* > > > + * this seems racy, but I don't see a notifier or such on > > > + * a struct device to know when it goes away? > > > + */ > > > + if (devcd->failing_

Re: [RFC v2] device coredump: add new device coredump class

2014-09-08 Thread Johannes Berg
On Fri, 2014-09-05 at 15:13 -0700, Greg Kroah-Hartman wrote: > > + /* > > +* this seems racy, but I don't see a notifier or such on > > +* a struct device to know when it goes away? > > +*/ > > + if (devcd->failing_dev->kobj.sd) > > + sysfs_delete_link(&devcd->failing_dev

Re: [RFC v2] device coredump: add new device coredump class

2014-09-08 Thread Arend van Spriel
On 09/05/14 10:50, Johannes Berg wrote: From: Johannes Berg Many devices run firmware and/or complex hardware, and most of that can have bugs. When it misbehaves, however, it is often much harder to debug than software running on the host. Introduce a "device coredump" mechanism to allow dumpin

Re: [RFC v2] device coredump: add new device coredump class

2014-09-07 Thread Johannes Berg
On Fri, 2014-09-05 at 15:13 -0700, Greg Kroah-Hartman wrote: > > +MODULE_AUTHOR("Johannes Berg "); > > +MODULE_DESCRIPTION("Device Coredump support"); > > +MODULE_LICENSE("GPL"); > > As you only allow Y or N as build options, it's not really a "module" :) Umm, yeah. I went back and forth on whet

Re: [RFC v2] device coredump: add new device coredump class

2014-09-07 Thread Arik Nemtsov
On Fri, Sep 5, 2014 at 11:50 AM, Johannes Berg wrote: > From: Johannes Berg > > Many devices run firmware and/or complex hardware, and most of that > can have bugs. When it misbehaves, however, it is often much harder > to debug than software running on the host. > Very nice concept IMO :) [...

Re: [RFC v2] device coredump: add new device coredump class

2014-09-05 Thread Greg Kroah-Hartman
On Fri, Sep 05, 2014 at 10:50:54AM +0200, Johannes Berg wrote: > From: Johannes Berg > > Many devices run firmware and/or complex hardware, and most of that > can have bugs. When it misbehaves, however, it is often much harder > to debug than software running on the host. > > Introduce a "device

Re: [RFC v2] device coredump: add new device coredump class

2014-09-05 Thread Johannes Berg
On Fri, 2014-09-05 at 11:40 +0200, Jonas Gorski wrote: > On Fri, Sep 5, 2014 at 10:50 AM, Johannes Berg > wrote: > > From: Johannes Berg > > Can't you just send from the correct address? ;p Not easily :) > How about the following to avoid negative options: > > config DEV_COREDUMP >boo

Re: [RFC v2] device coredump: add new device coredump class

2014-09-05 Thread Jonas Gorski
On Fri, Sep 5, 2014 at 10:50 AM, Johannes Berg wrote: > From: Johannes Berg Can't you just send from the correct address? ;p (snip) > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 4e7f0ff83ae7..134f763d90fd 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @

[RFC v2] device coredump: add new device coredump class

2014-09-05 Thread Johannes Berg
From: Johannes Berg Many devices run firmware and/or complex hardware, and most of that can have bugs. When it misbehaves, however, it is often much harder to debug than software running on the host. Introduce a "device coredump" mechanism to allow dumping internal device/firmware state through