Re: [RFC v4 08/13] rtw88: debug files

2018-11-15 Thread Kalle Valo
Joe Perches writes: > On Thu, 2018-11-15 at 16:15 +0200, Kalle Valo wrote: >> Joe Perches writes: >> >> > On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote: >> > > On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: >> > > > Joe Perches writes: >> > [] >> > > > > It's very unusual to have

Re: [RFC v4 08/13] rtw88: debug files

2018-11-15 Thread Joe Perches
On Thu, 2018-11-15 at 16:15 +0200, Kalle Valo wrote: > Joe Perches writes: > > > On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote: > > > On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > > > > Joe Perches writes: > > [] > > > > > It's very unusual to have _all_ the logging under a

Re: [RFC v4 08/13] rtw88: debug files

2018-11-15 Thread Kalle Valo
Joe Perches writes: > On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote: >> On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: >> > Joe Perches writes: > [] >> > > It's very unusual to have _all_ the logging under a CONFIG__DEBUG >> > > config guard flag. >> > >> > For wireless drivers

Re: [RFC v4 08/13] rtw88: debug files

2018-11-03 Thread Joe Perches
On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote: > On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > > Joe Perches writes: [] > > > It's very unusual to have _all_ the logging under a CONFIG__DEBUG > > > config guard flag. > > > > For wireless drivers that is actually quite typical. >

Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Joe Perches
On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: > > > From: Yan-Hsuan Chuang > > [] > > > diff --git a/drivers/net/wireless/realtek/rtw88/debug.c > > > b/drivers/net/wireless/realtek/rtw88/debug.c >

Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Kalle Valo
Joe Perches writes: > On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: >> From: Yan-Hsuan Chuang > [] >> diff --git a/drivers/net/wireless/realtek/rtw88/debug.c >> b/drivers/net/wireless/realtek/rtw88/debug.c > [] >> +#ifdef CONFIG_RTW88_DEBUG >> + >> +void __rtw_dbg(struct

Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Joe Perches
On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: > From: Yan-Hsuan Chuang [] > diff --git a/drivers/net/wireless/realtek/rtw88/debug.c > b/drivers/net/wireless/realtek/rtw88/debug.c [] > +#ifdef CONFIG_RTW88_DEBUG > + > +void __rtw_dbg(struct rtw_dev *rtwdev, const char *fmt, ...)

[RFC v4 08/13] rtw88: debug files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang debug files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/debug.c | 652 + drivers/net/wireless/realtek/rtw88/debug.h | 43 ++ 2 files changed, 695 insertions(+) create