Re: Association race when acting as AP?

2015-07-09 Thread Michal Kazior
On 7 July 2015 at 17:00, Jouni Malinen wrote: > On Thu, Jul 02, 2015 at 10:24:33AM +0200, Michal Kazior wrote: >> After looking into hostapd code I noticed something strange and I wonder if >> anyone else is already aware of this problem: >> >> 1. AP starts >> 2. STA->AP auth OTA >> 3. AP->STA

Re: Association race when acting as AP?

2015-07-07 Thread Jouni Malinen
On Thu, Jul 02, 2015 at 10:24:33AM +0200, Michal Kazior wrote: > After looking into hostapd code I noticed something strange and I wonder if > anyone else is already aware of this problem: > > 1. AP starts > 2. STA->AP auth OTA > 3. AP->STA auth OTA > 4. STA->AP assoc req OTA > 5. AP->STA ass

Re: Association race when acting as AP?

2015-07-02 Thread Eliad Peller
On Thu, Jul 2, 2015 at 1:39 PM, Michal Kazior wrote: > On 2 July 2015 at 10:43, Eliad Peller wrote: >> On Thu, Jul 2, 2015 at 11:38 AM, Johannes Berg >> wrote: >>> >>> [please try to send w/o html if you're CC'ing the linux-wireless list] >>> >>> > To me this looks like a race in hostapd. The st

Re: Association race when acting as AP?

2015-07-02 Thread Johannes Berg
On Thu, 2015-07-02 at 12:28 +0200, Michal Kazior wrote: > > Ultimately, depending on the nl80211 capabilities, the station > > should > > in fact be added (as unauthenticated) before even sending the > > authentication response frame, and then stepping through the stages > > appropriately. > > W

Re: Association race when acting as AP?

2015-07-02 Thread Michal Kazior
On 2 July 2015 at 10:43, Eliad Peller wrote: > On Thu, Jul 2, 2015 at 11:38 AM, Johannes Berg > wrote: >> >> [please try to send w/o html if you're CC'ing the linux-wireless list] >> >> > To me this looks like a race in hostapd. The station should be >> > installed to driver _before_ sending Asso

Re: Association race when acting as AP?

2015-07-02 Thread Michal Kazior
On 2 July 2015 at 10:38, Johannes Berg wrote: > [please try to send w/o html if you're CC'ing the linux-wireless list] Ah, sorry. I suspect the "plain text mode" in gmail/www got disabled for some reason for that e-mail.. >> To me this looks like a race in hostapd. The station should be >> inst

Re: Association race when acting as AP?

2015-07-02 Thread Johannes Berg
[please try to send w/o html if you're CC'ing the linux-wireless list] > To me this looks like a race in hostapd. The station should be > installed to driver _before_ sending Assoc Resp frame, not after. My > quick-n-dirty hack seems to help: > [...] > Is anyone aware of this problem already? A