Re: [v2] ath9k: Add support for OCB mode

2015-09-29 Thread Kalle Valo
> The patch adds support for "outside the context of a BSS"(OCB) mode > to ath9k driver and extends debugfs files by OCB ralated information. > > This patch was tested on AR9380-AL1A cards. > > Signed-off-by: Jan Kaisrlik > Cc: Michal Sojka Thanks, appli

[PATCH v2] ath9k: Add support for OCB mode

2015-09-17 Thread Jan Kaisrlik
The patch adds support for "outside the context of a BSS"(OCB) mode to ath9k driver and extends debugfs files by OCB ralated information. This patch was tested on AR9380-AL1A cards. Signed-off-by: Jan Kaisrlik Cc: Michal Sojka --- changes: * OCB mode is treated like AP mode rather th

Re: [PATCH] ath9k: Add support for OCB mode

2015-09-12 Thread Jan Kaisrlik
ds support for "outside the context of a BSS"(OCB) mode >> to ath9k driver and extends debugfs files by OCB ralated information. >> >> This patch was tested on AR9380-AL1A cards. >> >> Signed-off-by: Jan Kaisrlik >> Cc: Michal Sojka >> --- >&g

Re: [PATCH] ath9k: Add support for OCB mode

2015-09-09 Thread Felix Fietkau
On 2015-09-09 14:55, Jan Kaisrlik wrote: > The patch adds support for "outside the context of a BSS"(OCB) mode > to ath9k driver and extends debugfs files by OCB ralated information. > > This patch was tested on AR9380-AL1A cards. > > Signed-off-by: Jan

[PATCH] ath9k: Add support for OCB mode

2015-09-09 Thread Jan Kaisrlik
The patch adds support for "outside the context of a BSS"(OCB) mode to ath9k driver and extends debugfs files by OCB ralated information. This patch was tested on AR9380-AL1A cards. Signed-off-by: Jan Kaisrlik Cc: Michal Sojka --- drivers/net/wireless/ath/ath9k/ani.c | 1

Re: [PATCH] mac80211: Fix oops in OCB mode when receiving data when not joined

2015-09-08 Thread Johannes Berg
On Tue, 2015-09-08 at 21:17 +0200, Bertold Van den Bergh wrote: > Hello, > > Sorry. I missed your previous email. I agree that your solution is > better and cleaner. > > Do you want me to submit a new patch? > Yes, please do. Thanks, johannes -- To unsubscribe from this list: send the line "un

Re: [PATCH] mac80211: Fix oops in OCB mode when receiving data when not joined

2015-09-08 Thread Bertold Van den Bergh
Hello, Sorry. I missed your previous email. I agree that your solution is better and cleaner. Do you want me to submit a new patch? Sincerely, Bertold Van den Bergh On Tue, Sep 8, 2015 at 6:03 PM, Johannes Berg wrote: > On Thu, 2015-08-13 at 11:09 +0200, Johannes Berg wrote: >> On Wed, 2015-08

Re: [PATCH] mac80211: Fix oops in OCB mode when receiving data when not joined

2015-09-08 Thread Johannes Berg
On Thu, 2015-08-13 at 11:09 +0200, Johannes Berg wrote: > On Wed, 2015-08-05 at 15:38 +0200, Bertold Van den Bergh wrote: > > The current implementation in ocb.c can cause a kernel oops when > > the > > interface is up, but no ocb has been joined. When data is received > > with the broadcast BSSID

Re: [PATCH 5/5] mac80211: Make OCB mode set BSSID

2015-08-13 Thread Johannes Berg
On Wed, 2015-08-05 at 16:02 +0200, Bertold Van den Bergh wrote: > Perform the BSS_CHANGED_BSSID action when joining an OCB network. > This is required to set the broadcast BSSID in some network drivers. > Also applied 4 and 5. johannes -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 3/5] mac80211: Create STA when transmitting to unknown station in OCB mode

2015-08-13 Thread Johannes Berg
On Wed, 2015-08-05 at 16:02 +0200, Bertold Van den Bergh wrote: > Create a new STA when requested to unicast a frame to an unknown > station. > This is needed to make ratecontrol work in the case where data is > sent > from sta A to B and sta B never replies. Currently, sta B will stay > unknown

Re: [PATCH] mac80211: Fix oops in OCB mode when receiving data when not joined

2015-08-13 Thread Johannes Berg
On Wed, 2015-08-05 at 15:38 +0200, Bertold Van den Bergh wrote: > The current implementation in ocb.c can cause a kernel oops when the > interface is up, but no ocb has been joined. When data is received > with the broadcast BSSID rx_no_sta is called. This function uses > uninitialized variables be

Re: [1/1] ath: Make ath_opmode_to_string understand OCB mode

2015-08-10 Thread Kalle Valo
> Make ath_opmode_to_string return "OCB" for NL80211_IFTYPE_OCB. Currently > it will return "UNKNOWN". > > Signed-off-by: Bertold Van den Bergh Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a

[PATCH 5/5] mac80211: Make OCB mode set BSSID

2015-08-05 Thread Bertold Van den Bergh
Perform the BSS_CHANGED_BSSID action when joining an OCB network. This is required to set the broadcast BSSID in some network drivers. Signed-off-by: Bertold Van den Bergh --- net/mac80211/ocb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/ocb.c b/net/mac80211

[PATCH 3/5] mac80211: Create STA when transmitting to unknown station in OCB mode

2015-08-05 Thread Bertold Van den Bergh
Create a new STA when requested to unicast a frame to an unknown station. This is needed to make ratecontrol work in the case where data is sent from sta A to B and sta B never replies. Currently, sta B will stay unknown to mac80211 and the default rate will always be used. Signed-off-by: Bertold

[PATCH 4/5] mac80211: Only accept data frames in OCB mode

2015-08-05 Thread Bertold Van den Bergh
Currently OCB mode accepts frames with bssid==broadcast and type!=beacon. Some non-data frames are sent matching this, for example probe responses. This results in unnecessary creation of STA entries. Signed-off-by: Bertold Van den Bergh --- net/mac80211/rx.c | 2 +- 1 file changed, 1 insertion

[PATCH] mac80211: Fix oops in OCB mode when receiving data when not joined

2015-08-05 Thread Bertold Van den Bergh
The current implementation in ocb.c can cause a kernel oops when the interface is up, but no ocb has been joined. When data is received with the broadcast BSSID rx_no_sta is called. This function uses uninitialized variables because the join function has not yet been used. Signed-off-by: Bertold V

[PATCH 1/1] ath: Make ath_opmode_to_string understand OCB mode

2015-08-03 Thread Bertold Van den Bergh
Make ath_opmode_to_string return "OCB" for NL80211_IFTYPE_OCB. Currently it will return "UNKNOWN". Signed-off-by: Bertold Van den Bergh --- drivers/net/wireless/ath/debug.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/debug.c b/drivers/net/wi

Re: [PATCH] iw: Add OCB mode handling

2015-01-14 Thread Johannes Berg
On Mon, 2015-01-12 at 13:49 +0100, Rostislav Lisovy wrote: > Since the commit 6e0bd6c35b021dc73a81ebd1ef79761233c48b50 > ("cfg80211: 802.11p OCB mode handling") and > 239281f803e2efdb77d906ef296086b6917e5d71 > ("mac80211: 802.11p OCB mode support") > does the

[PATCH] iw: Add OCB mode handling

2015-01-12 Thread Rostislav Lisovy
Since the commit 6e0bd6c35b021dc73a81ebd1ef79761233c48b50 ("cfg80211: 802.11p OCB mode handling") and 239281f803e2efdb77d906ef296086b6917e5d71 ("mac80211: 802.11p OCB mode support") does the Linux kernel support OCB mode. This commit adds proper OCB mode handling. Modify th

OCB mode

2014-12-19 Thread Andre Paixao
Hi, is the code open? From where could I clone it? Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2 v3] cfg80211: mac80211: 802.11p OCB mode support

2014-11-04 Thread Rostislav Lisovy
width) to communicate on. The channel > > has to be known a priori. It is set during the 'ocb join' > > operation (sent via netlink message from user-space). > > > > This patchset adds the OCB mode, OCB join and leave handling > > (nl80211, cfg80211, mac80

Re: [PATCH 0/2 v3] cfg80211: mac80211: 802.11p OCB mode support

2014-11-04 Thread Johannes Berg
7;ocb join' > operation (sent via netlink message from user-space). > > This patchset adds the OCB mode, OCB join and leave handling > (nl80211, cfg80211, mac80211), 802.11p EDCA parameters > modification, RX and TX path (for unicast/broadcast messages). Applied, thanks for a

[PATCH 2/2] mac80211: 802.11p OCB mode support

2014-11-03 Thread Rostislav Lisovy
This patch adds 802.11p OCB (Outside the Context of a BSS) mode support. When communicating in OCB mode a mandatory wildcard BSSID (48 '1' bits) is used. The EDCA parameters handling function was changed to support 802.11p specific values. The insertion of a newly discovered STAs is d

[PATCH 1/2] cfg80211: mac80211: 802.11p OCB mode handling

2014-11-03 Thread Rostislav Lisovy
0b3d8 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -1359,6 +1359,16 @@ struct mesh_setup { }; /** + * struct ocb_setup - 802.11p OCB mode setup configuration + * @chandef: defines the channel to use + * + * These parameters are fixed when connecting to the network + */ +str

[PATCH 0/2 v3] cfg80211: mac80211: 802.11p OCB mode support

2014-11-03 Thread Rostislav Lisovy
/association is necessary to communicate. The only parameter to be configured is the channel (central frequency and bandwidth) to communicate on. The channel has to be known a priori. It is set during the 'ocb join' operation (sent via netlink message from user-space). This patchset adds the OCB

Re: [PATCH 1/2] cfg80211: 802.11p OCB mode handling

2014-10-31 Thread Johannes Berg
On Fri, 2014-10-31 at 16:12 +0100, Rostislav Lisovy wrote: > On Fri, 2014-10-31 at 14:13 +0100, Johannes Berg wrote: > > On Thu, 2014-10-30 at 11:42 +0100, Rostislav Lisovy wrote: > > > @@ -2093,6 +2102,7 @@ enum nl80211_iftype { > > > NL80211_IFTYPE_P2P_CLIENT, > > > NL80211_IFTYPE_P2P_GO, > >

Re: [PATCH 1/2] cfg80211: 802.11p OCB mode handling

2014-10-31 Thread Rostislav Lisovy
On Fri, 2014-10-31 at 14:13 +0100, Johannes Berg wrote: > On Thu, 2014-10-30 at 11:42 +0100, Rostislav Lisovy wrote: > > @@ -2093,6 +2102,7 @@ enum nl80211_iftype { > > NL80211_IFTYPE_P2P_CLIENT, > > NL80211_IFTYPE_P2P_GO, > > NL80211_IFTYPE_P2P_DEVICE, > > + NL80211_IFTYPE_OCB, > >

Re: [PATCH 2/2] mac80211: 802.11p OCB mode support

2014-10-31 Thread Johannes Berg
On Thu, 2014-10-30 at 11:42 +0100, Rostislav Lisovy wrote: > +int ieee80211_ocb_join(struct ieee80211_sub_if_data *sdata, > +struct ocb_setup *setup) > +{ > + struct ieee80211_local *local = sdata->local; > + struct ieee80211_if_ocb *ifocb = &sdata->u.ocb; > + u32 c

Re: [PATCH 1/2] cfg80211: 802.11p OCB mode handling

2014-10-31 Thread Johannes Berg
On Thu, 2014-10-30 at 11:42 +0100, Rostislav Lisovy wrote: > --- a/include/net/mac80211.h > +++ b/include/net/mac80211.h > @@ -263,6 +263,7 @@ struct ieee80211_vif_chanctx_switch { > * @BSS_CHANGED_BANDWIDTH: The bandwidth used by this interface changed, > * note that this is only called whe

[PATCH 2/2] mac80211: 802.11p OCB mode support

2014-10-30 Thread Rostislav Lisovy
This patch adds 802.11p OCB (Outside the Context of a BSS) mode support. When communicating in OCB mode a mandatory wildcard BSSID (48 '1' bits) is used. The EDCA parameters handling function was changed to support 802.11p specific values. The insertion of a newly discovered STAs is d

[PATCH 1/2] cfg80211: 802.11p OCB mode handling

2014-10-30 Thread Rostislav Lisovy
@@ struct mesh_setup { }; /** + * struct ocb_setup - 802.11p OCB mode setup configuration + * @chandef: defines the channel to use + * + * These parameters are fixed when connecting to the network + */ +struct ocb_setup { + struct cfg80211_chan_def chandef; +}; + +/** * struct ieee80211_txq_params -

[PATCH 0/2 v2] cfg80211: mac80211: 802.11p OCB mode support

2014-10-30 Thread Rostislav Lisovy
/association is necessary to communicate. The only parameter to be configured is the channel (central frequency and bandwidth) to communicate on. The channel has to be known a priori. It is set during the 'ocb join' operation (sent via netlink message from user-space). This patchset adds the OCB

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-20 Thread Johannes Berg
On Thu, 2014-10-16 at 19:20 +0200, Rostislav Lisovy wrote: > Now I realized it is not that easy (and I confused "interface running" > and being "connected to the network"). There seems not to be a solid > indication that we are no longer "connected" to the network. Oops, ignore my previous reply.

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-20 Thread Johannes Berg
ocb_work(struct ieee80211_sub_if_data > *sdata) > struct ieee80211_if_ocb *ifocb = &sdata->u.ocb; > struct sta_info *sta; > > + if (!netif_running(sdata->dev)) > + return; Not sure, it seems you should check "is it operating in OCB mode&quo

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-16 Thread Rostislav Lisovy
On Thu, 2014-10-16 at 18:33 +0200, Rostislav Lisovy wrote: > > > + mutex_lock(&sdata->local->mtx); > > > + ieee80211_vif_release_channel(sdata); > > > + mutex_unlock(&sdata->local->mtx); > > > + > > > + skb_queue_purge(&sdata->skb_queue); > > > + > > > + del_timer_sync(&sdata->u.ocb.house

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-16 Thread Rostislav Lisovy
Hello Johannes; Thanks for the thorough review. On Thu, 2014-10-09 at 10:23 +0200, Johannes Berg wrote: > On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote: > > +++ b/net/mac80211/cfg.c > > @@ -229,6 +229,7 @@ static int ieee80211_add_key(struct wiphy *wiphy, > > struct net_device *dev, >

Re: [PATCH 4/4] nl80211: Join and Leave handling for OCB mode

2014-10-09 Thread Johannes Berg
On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote: > Signed-off-by: Rostislav Lisovy same comment about commit log here - also this patch should either go first in the series, or just be squashed with the cfg80211 patch, there's no real need to distinguish between the two. I guess it can'

Re: [PATCH 3/4] cfg80211: Join and Leave handling for OCB mode

2014-10-09 Thread Johannes Berg
On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote: > Signed-off-by: Rostislav Lisovy A bit more commit log would be good :) > +++ b/include/net/cfg80211.h > @@ -375,6 +375,8 @@ static inline enum nl80211_channel_type > cfg80211_get_chandef_type(const struct cfg80211_chan_def *chandef) >

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-09 Thread Johannes Berg
TYPE_P2P_GO: > + case NL80211_IFTYPE_OCB: > /* shouldn't happen */ There's no encryption in OCB at all? > +++ b/net/mac80211/ieee80211_i.h > @@ -82,6 +82,8 @@ struct ieee80211_fragment_entry { > u8 last_pn[6]; /* PN of the last fragment if CCMP was used */

[PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-09-11 Thread Rostislav Lisovy
All the devices compliant to the IEEE 802.11p (dot11OCBActivated=true) should operate in the OCB (Outside the Context of a BSS) mode. This makes it possible to communicate without the need for association/authentication. All participants use the wildcard BSSID (set to all 1's). In OCB mode

[PATCH 3/4] cfg80211: Join and Leave handling for OCB mode

2014-09-11 Thread Rostislav Lisovy
op_ap(struct cfg80211_registered_device *rdev, struct net_device *dev, bool notify); diff --git a/net/wireless/ocb.c b/net/wireless/ocb.c new file mode 100644 index 000..d288ae6 --- /dev/null +++ b/net/wireless/ocb.c @@ -0,0 +1,88 @@ +/* + * OCB mode implementation + * + * Copyright: (c

[PATCH 0/4] 802.11p OCB mode

2014-09-11 Thread Rostislav Lisovy
/association is necessary to communicate. The only parameter to be configured is the channel (central frequency and bandwidth) to communicate on. The channel has to be known a priori. It is set during the 'ocb join' operation (sent via netlink message from user-space). This patchset adds the OCB

[PATCH 4/4] nl80211: Join and Leave handling for OCB mode

2014-09-11 Thread Rostislav Lisovy
Signed-off-by: Rostislav Lisovy --- include/uapi/linux/nl80211.h | 8 net/wireless/nl80211.c | 47 2 files changed, 55 insertions(+) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index cdf9ba4..4b39455 100644

Re: Regulatory of 5.9 GHz band and OCB mode (was: [RFC 1/4] cfg80211: Add channel flags limiting availability to OCB mode only)

2014-09-05 Thread Luis R. Rodriguez
at 00:18 +0200, Luis R. Rodriguez wrote: > >>> Rostislav, can you provide documentation references which would > >>> clarify > >>> the stance on 802.11p and restrictions for only allowing OCB mode? > >> > >> If I may cite the 802.11-2012 standard