RE: [PATCH 09/28] mac80211: pass the TWT support bits in extended caps to the driver

2018-09-03 Thread Grumbach, Emmanuel
> > On Mon, 2018-09-03 at 09:28 +, Grumbach, Emmanuel wrote: > > > > > For managed mode, the driver will need to check the HE cap along with > > the extended capabilities to determine whether AP supports TWT or not. > > Do you have any idea why it's there twice? Sounds like we should resolve

Re: [PATCH 09/28] mac80211: pass the TWT support bits in extended caps to the driver

2018-09-03 Thread Johannes Berg
On Mon, 2018-09-03 at 09:28 +, Grumbach, Emmanuel wrote: > > > For managed mode, the driver will need to check the HE cap along with the > extended capabilities to determine whether AP supports TWT or not. Do you have any idea why it's there twice? Sounds like we should resolve that in

RE: [PATCH 09/28] mac80211: pass the TWT support bits in extended caps to the driver

2018-09-03 Thread Grumbach, Emmanuel
> > > Since those bits are present in the HE Cap as well, we can set the > > capability bits in the Extended Capabilities IE based on what is > > advertised in the HE Cap IE. > > It's not clear to me what this is trying to say, you don't seem to do anything > with the HE capabilities in the

Re: [PATCH 09/28] mac80211: pass the TWT support bits in extended caps to the driver

2018-09-03 Thread Johannes Berg
On Fri, 2018-08-31 at 11:31 +0300, Luca Coelho wrote: > Since those bits are present in the HE Cap as well, > we can set the capability bits in the Extended > Capabilities IE based on what is advertised in the HE Cap IE. It's not clear to me what this is trying to say, you don't seem to do