Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Seth Forshee
On Sun, Oct 05, 2014 at 04:57:12PM +0300, Emmanuel Grumbach wrote: + if (vif) + scd_queues = ~BIT(vif-hw_queue[IEEE80211_AC_VO]); I'm backporting this to 3.13, and this part doesn't work unless 77be2c54c5bd26279abc13807398771d80cda37a is also backported. Is this critical, or can

RE: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Grumbach, Emmanuel
Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing On Sun, Oct 05, 2014 at 04:57:12PM +0300, Emmanuel Grumbach wrote: + if (vif) + scd_queues = ~BIT(vif-hw_queue[IEEE80211_AC_VO]); I'm backporting this to 3.13, and this part doesn't work unless

Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Seth Forshee
On Mon, Oct 06, 2014 at 07:43:07AM -0500, Seth Forshee wrote: On Mon, Oct 06, 2014 at 12:35:46PM +, Grumbach, Emmanuel wrote: Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing On Sun, Oct 05, 2014 at 04:57:12PM +0300, Emmanuel Grumbach wrote: + if (vif

RE: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Grumbach, Emmanuel
On Mon, Oct 06, 2014 at 07:43:07AM -0500, Seth Forshee wrote: On Mon, Oct 06, 2014 at 12:35:46PM +, Grumbach, Emmanuel wrote: Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing On Sun, Oct 05, 2014 at 04:57:12PM +0300, Emmanuel Grumbach wrote: + if (vif

Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Seth Forshee
On Mon, Oct 06, 2014 at 12:47:41PM +, Grumbach, Emmanuel wrote: On Mon, Oct 06, 2014 at 07:43:07AM -0500, Seth Forshee wrote: On Mon, Oct 06, 2014 at 12:35:46PM +, Grumbach, Emmanuel wrote: Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing On Sun, Oct

RE: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Grumbach, Emmanuel
On Mon, Oct 06, 2014 at 12:47:41PM +, Grumbach, Emmanuel wrote: On Mon, Oct 06, 2014 at 07:43:07AM -0500, Seth Forshee wrote: On Mon, Oct 06, 2014 at 12:35:46PM +, Grumbach, Emmanuel wrote: Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing

RE: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-05 Thread Sujith Manoharan
Grumbach, Emmanuel wrote: I can't really tell... I guess it depends on the firmware / hardware. On these devices (dvm), the firmware would take a very long time to send / drop the packets. I guess it is a bug, and users have been suffering from this for a very long time. Thing is that I was

Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-05 Thread Seth Forshee
On Sun, Oct 05, 2014 at 04:57:12PM +0300, Emmanuel Grumbach wrote: When mac80211 wants to ensure that a frame is sent, it calls the flush() callback. Until now, iwldvm implemented this by waiting that all the frames are sent (ACKed or timeout). In case of weak signal, this can take a