Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-10-01 Thread Johannes Berg
> For what purpose? Or rather, when a user sees this in their dmesg, > what are they supposed to do about it? I think the idea isn't that the user would do something, but more that in case of performance issues, or perhaps driver/device bugs handling the changes, or similar you'd have an

Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 13:02 -0400, Josh Boyer wrote: > Hi Johannes, > > We've seen a handful of reports that seem to have verbose output from > the ieee80211_config_bw function in net/mac80211/mlme.c. It looks > similar to this: > > [ 66.578652] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth,

Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Johannes Berg
> > I'm not sure ratelimiting it would even work - it's not *that* high > frequency? Not really sure though. > > I think we can do either, it's not such a terribly important message as > far as I can tell. > Seems like Emmanuel would like to see the message stay in some form - perhaps we

Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Josh Boyer
On Wed, Sep 30, 2015 at 3:04 PM, Johannes Berg wrote: > >> >> I'm not sure ratelimiting it would even work - it's not *that* high >> frequency? Not really sure though. >> >> I think we can do either, it's not such a terribly important message as >> far as I can tell. >>

Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Josh Boyer
Hi Johannes, We've seen a handful of reports that seem to have verbose output from the ieee80211_config_bw function in net/mac80211/mlme.c. It looks similar to this: [ 66.578652] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config is 2437 MHz, width 2 (2447/0 MHz) [ 68.522437] wlp3s0: