Re: [Codel] [PATCHv3 2/5] mac80211: implement fair queueing per txq

2016-04-19 Thread Johannes Berg
On Mon, 2016-04-18 at 15:36 +0200, Michal Kazior wrote: > FWIW cfg80211 drivers might become another user of the fq/codel stuff > in the future. > > Arguably I should make include/net/codel.h not be qdisc specific as > it is now (and hence re-usable by mac80211) and submit fq.h to >

Re: [Codel] [PATCHv3 2/5] mac80211: implement fair queueing per txq

2016-04-18 Thread Michal Kazior
On 18 April 2016 at 14:31, Eric Dumazet wrote: > On Mon, 2016-04-18 at 07:16 +0200, Michal Kazior wrote: > >> >> I guess .h file can give the compiler an opportunity for more >> optimizations. With .c you would need LTO which I'm not sure if it's >> available everywhere.

Re: [Codel] [PATCHv3 2/5] mac80211: implement fair queueing per txq

2016-04-18 Thread Eric Dumazet
On Mon, 2016-04-18 at 07:16 +0200, Michal Kazior wrote: > > I guess .h file can give the compiler an opportunity for more > optimizations. With .c you would need LTO which I'm not sure if it's > available everywhere. > This makes little sense really. Otherwise everything would be in .h files.