Re: [PATCH] mac80211: prevent skb/txq mismatch

2017-01-13 Thread Johannes Berg
> > What I don't understand - and you haven't really described - is how > > the changes fix it? Could you resend with a paragraph added that > > explains that? > > "Since downgrading unicast traffic to vif->txq must not be done > there's no txq to put a frame on if sta->uploaded is false.

Re: [PATCH] mac80211: prevent skb/txq mismatch

2017-01-13 Thread Michal Kazior
On 13 January 2017 at 09:16, Johannes Berg wrote: > On Thu, 2017-01-12 at 15:28 +0100, Michal Kazior wrote: >> Station structure is considered as not uploaded >> (to driver) until drv_sta_state() finishes. This >> call is however done after the structure is >> attached

Re: [PATCH] mac80211: prevent skb/txq mismatch

2017-01-13 Thread Johannes Berg
On Thu, 2017-01-12 at 15:28 +0100, Michal Kazior wrote: > Station structure is considered as not uploaded > (to driver) until drv_sta_state() finishes. This > call is however done after the structure is > attached to mac80211 internal lists and hashes. > This means mac80211 can lookup (and use)

Re: [PATCH] mac80211: prevent skb/txq mismatch

2017-01-12 Thread Dave Taht
Yay! This sounds like a potential fix for this? https://bugs.lede-project.org/index.php?do=details_id=368 Are all the ath10k chipsets excluded by commit: 4ca1807815aa6801aaced7fdefa9edacc2521767 Still needed to be excluded?

Re: [PATCH] mac80211: prevent skb/txq mismatch

2017-01-12 Thread Felix Fietkau
On 2017-01-12 15:28, Michal Kazior wrote: > Station structure is considered as not uploaded > (to driver) until drv_sta_state() finishes. This > call is however done after the structure is > attached to mac80211 internal lists and hashes. > This means mac80211 can lookup (and use) station >

Re: [PATCH] mac80211: prevent skb/txq mismatch

2017-01-12 Thread Mohammed Shafi Shajakhan
On Thu, Jan 12, 2017 at 03:51:20PM +0100, Johannes Berg wrote: > On Thu, 2017-01-12 at 20:15 +0530, Mohammed Shafi Shajakhan wrote: > > > > > Reported-by: Mohammed Shafi Shajakhan > > > Signed-off-by: Michal Kazior > > > > Signed-off-by:

Re: [PATCH] mac80211: prevent skb/txq mismatch

2017-01-12 Thread Mohammed Shafi Shajakhan
On Thu, Jan 12, 2017 at 03:28:41PM +0100, Michal Kazior wrote: > Station structure is considered as not uploaded > (to driver) until drv_sta_state() finishes. This > call is however done after the structure is > attached to mac80211 internal lists and hashes. > This means mac80211 can lookup (and

Re: [PATCH] mac80211: prevent skb/txq mismatch

2017-01-12 Thread Johannes Berg
On Thu, 2017-01-12 at 20:15 +0530, Mohammed Shafi Shajakhan wrote: > > > Reported-by: Mohammed Shafi Shajakhan > > Signed-off-by: Michal Kazior > > Signed-off-by: Mohammed Shafi Shajakhan That makes no sense,