Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-21 Thread Mark Greer
On Wed, Dec 21, 2016 at 06:47:36AM -0500, Geoff Lansberry wrote: > Thanks Mark. Should I resubmit patches with the requested edits today, or > wait a bit for more comments? What is the desired etiquette? Its up to you. I don't think there are any hard & fast rules on this. If it were me, I w

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-21 Thread Geoff Lansberry
Thanks Mark. Should I resubmit patches with the requested edits today, or wait a bit for more comments? What is the desired etiquette? > On Dec 20, 2016, at 9:23 PM, Mark Greer wrote: > >> On Tue, Dec 20, 2016 at 11:16:31AM -0500, Geoff Lansberry wrote: >> From: Geoff Lansberry >> >> The T

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:16:31AM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry > > The TRF7970A has configuration options for supporting hardware designs > with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, > using a fixed regulator binding, for setting the io voltag

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:13:23AM -0500, Geoff Lansberry wrote: > On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring wrote: > > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > >> From: Geoff Lansberry > >> > >> --- > >> Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Geoff Lansberry
On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring wrote: > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: >> From: Geoff Lansberry >> >> --- >> Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ >> drivers/nfc/trf7970a.c | 13

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-19 Thread Rob Herring
On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry > > --- > Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ > drivers/nfc/trf7970a.c | 13 - > 2 files changed, 14 insertions(+), 1 deletion(-) > >

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-15 Thread Mark Greer
On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry Missing commit description. > diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c > index 2d2a077..b4c37ab 100644 > --- a/drivers/nfc/trf7970a.c > +++ b/drivers/nfc/trf7970a.c > @@ -1048,6 +1049,11