Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-08 Thread Geoff Lansberry
On Tue, Jan 3, 2017 at 4:21 PM, Mark Greer wrote: > On Tue, Jan 03, 2017 at 01:35:18PM -0500, Geoff Lansberry wrote: >> On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: >> > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > >> >>

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-03 Thread Mark Greer
On Tue, Jan 03, 2017 at 01:35:18PM -0500, Geoff Lansberry wrote: > On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: > > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > >> In the meantime - here is some more info about how we use it. > >> > >> We do

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-03 Thread Geoff Lansberry
On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: > [Please stop top-posting. Bottom-post only to these lists.] Sorry; gmail keeps baiting me to do it... > > Hi Geoff & happy new year. > > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: >> Mark - I

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-03 Thread Mark Greer
[Please stop top-posting. Bottom-post only to these lists.] Hi Geoff & happy new year. On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > Mark - I will split this off soon. OK > In the meantime - here is some more info about how we use it. > > We do use NFC structures.I

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-27 Thread Geoff Lansberry
Mark - I will split this off soon. In the meantime - here is some more info about how we use it. We do use NFC structures.I did find an interesting clue in that there are certain bottles that cause neard to segfault, I'm not sure what is different about them. We write a string, like

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-24 Thread Mark Greer
On Sat, Dec 24, 2016 at 11:17:18AM -0500, Geoff Lansberry wrote: > Mark - I'm sorry, but I did not write this code, and therefore was not > able to accurately describe it. It is fixing a different issue, not > the neard segfault that we are still chasing. Last week Jaret Cantu > sent a separate

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-24 Thread Geoff Lansberry
Mark - I'm sorry, but I did not write this code, and therefore was not able to accurately describe it. It is fixing a different issue, not the neard segfault that we are still chasing. Last week Jaret Cantu sent a separate email explaining the purpose of the code, which had you copied, did you

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-23 Thread Mark Greer
On Wed, Dec 21, 2016 at 11:18:34PM -0500, Geoff Lansberry wrote: > From: Jaret Cantu > > Repeated polling attempts cause a NULL dereference error to occur. > This is because the state of the trf7970a is currently reading but > another request has been made to send a