Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Wed 03 Aug 08:55 PDT 2016, Luis R. Rodriguez wrote: > On Wed, Aug 03, 2016 at 08:57:09AM +0200, Daniel Wagner wrote: > > On 08/02/2016 09:41 AM, Luis R. Rodriguez wrote: [..] > > Not sure if I get you here correctly. Is the 'system configurable > > deterministic file' is a knob which

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On 03-08-16 17:35, Dmitry Torokhov wrote: >> In my opinion the kernel should provide functionality to user-space and >> > user-space providing functionality to the kernel should be avoided. > Why? We have bunch of stuff running in userspace for the kernel. Fuse > for example. I am sure there are

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Wed, Aug 03, 2016 at 10:39:55AM -0700, Bjorn Andersson wrote: > On Tue 02 Aug 00:41 PDT 2016, Luis R. Rodriguez wrote: > > > On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: > > > On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: > > > >On Tue, Aug 02, 2016 at 07:49:19AM +0200,

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Wed, Aug 03, 2016 at 05:55:40PM +0200, Luis R. Rodriguez wrote: > On Wed, Aug 03, 2016 at 08:57:09AM +0200, Daniel Wagner wrote: > > On 08/02/2016 09:41 AM, Luis R. Rodriguez wrote: > > >On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: > > >>On 08/02/2016 08:34 AM, Luis R.

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Wed, Aug 03, 2016 at 09:18:21AM -0700, Dmitry Torokhov wrote: > On Wed, Aug 03, 2016 at 05:55:40PM +0200, Luis R. Rodriguez wrote: > > > > I accept all help and would be glad to make enhancements instead of > > the old API through new API. The biggest thing here first I think is > > adding

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Tue 02 Aug 00:41 PDT 2016, Luis R. Rodriguez wrote: > On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: > > On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: > > >On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner wrote: > > >>>The sysdata API's main goal rather is to provide

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Wed, Aug 03, 2016 at 08:57:09AM +0200, Daniel Wagner wrote: > On 08/02/2016 09:41 AM, Luis R. Rodriguez wrote: > >On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: > >>On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: > >>>On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Wed, Aug 03, 2016 at 05:55:40PM +0200, Luis R. Rodriguez wrote: > > I accept all help and would be glad to make enhancements instead of > the old API through new API. The biggest thing here first I think is > adding devm support, that I think should address what seemed to be > the need to add

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Wed, Aug 03, 2016 at 12:42:14AM -0700, Dmitry Torokhov wrote: > On Tue, Aug 2, 2016 at 12:41 AM, Luis R. Rodriguez wrote: > > On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: > >> On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: > >> >On Tue, Aug 02, 2016 at

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Wed, Aug 03, 2016 at 01:43:31PM +0200, Arend van Spriel wrote: > On 03-08-16 09:42, Dmitry Torokhov wrote: > > On Tue, Aug 2, 2016 at 12:41 AM, Luis R. Rodriguez > > wrote: > >> On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: > >>> On 08/02/2016 08:34 AM,

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On 03-08-16 09:42, Dmitry Torokhov wrote: > On Tue, Aug 2, 2016 at 12:41 AM, Luis R. Rodriguez wrote: >> On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: >>> On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Tue, Aug 2, 2016 at 12:41 AM, Luis R. Rodriguez wrote: > On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: >> On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: >> >On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner wrote: >> >>>The sysdata API's main goal

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On 08/02/2016 09:41 AM, Luis R. Rodriguez wrote: On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner wrote: So you argue for the remoteproc use case with 100+ MB firmware that

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: > On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: > >On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner wrote: > >>>The sysdata API's main goal rather is to provide a flexible API first, > >>>compartamentalizing the usermode

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner wrote: The sysdata API's main goal rather is to provide a flexible API first, compartamentalizing the usermode helper was secondary. But now it seems I may just also add devm support too to

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner wrote: > >The sysdata API's main goal rather is to provide a flexible API first, > >compartamentalizing the usermode helper was secondary. But now it seems > >I may just also add devm support too to help simplify code further. > > I missed

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

Hi Luis, I was ignorant on all the nasty details around the firmware loading. If I parse Luis' patches correctly they introduce an API which calls kernel_read_file_from_path() asynchronously: sysdata_file_request_async(..., ) *coookie = async_schedule_domain(request_sysdata_file_work_func(),

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Mon, Aug 01, 2016 at 10:19:51AM -0700, Bjorn Andersson wrote: > On Sat 30 Jul 09:58 PDT 2016, Luis R. Rodriguez wrote: > > > On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: > > > + Luis (again) ;-) > > > > > > On 29-07-16 08:13, Daniel Wagner wrote: > > > > On 07/28/2016

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Mon, Aug 01, 2016 at 10:19:51AM -0700, Bjorn Andersson wrote: > On Sat 30 Jul 09:58 PDT 2016, Luis R. Rodriguez wrote: > > > On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: > > > + Luis (again) ;-) > > > > > > On 29-07-16 08:13, Daniel Wagner wrote: > > > > On 07/28/2016

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Sun, Jul 31, 2016 at 12:23:09AM -0700, Dmitry Torokhov wrote: > On July 30, 2016 9:58:17 AM PDT, "Luis R. Rodriguez" > wrote: > >On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: > >> + Luis (again) ;-) > >> > >> On 29-07-16 08:13, Daniel Wagner wrote: > >>

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Mon, Aug 01, 2016 at 02:26:04PM +0200, Daniel Wagner wrote: > On 07/31/2016 09:23 AM, Dmitry Torokhov wrote: > >On July 30, 2016 9:58:17 AM PDT, "Luis R. Rodriguez" > >wrote: > >>On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: > >>>On 29-07-16 08:13,

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Sat 30 Jul 09:58 PDT 2016, Luis R. Rodriguez wrote: > On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: > > + Luis (again) ;-) > > > > On 29-07-16 08:13, Daniel Wagner wrote: > > > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: > > >> On Thu 28 Jul 11:33 PDT 2016, Dmitry

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On 07/31/2016 09:23 AM, Dmitry Torokhov wrote: On July 30, 2016 9:58:17 AM PDT, "Luis R. Rodriguez" wrote: On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: On 29-07-16 08:13, Daniel Wagner wrote: On 07/28/2016 09:01 PM, Bjorn Andersson wrote: On Thu 28

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On July 30, 2016 9:58:17 AM PDT, "Luis R. Rodriguez" wrote: >On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: >> + Luis (again) ;-) >> >> On 29-07-16 08:13, Daniel Wagner wrote: >> > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: >> >> On Thu 28 Jul 11:33 PDT

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On July 30, 2016 5:42:41 AM PDT, Arend van Spriel wrote: >+ Luis (again) ;-) > >On 29-07-16 08:13, Daniel Wagner wrote: >> On 07/28/2016 09:01 PM, Bjorn Andersson wrote: >>> On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: >>> On Thu, Jul 28, 2016 at

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: > + Luis (again) ;-) > > On 29-07-16 08:13, Daniel Wagner wrote: > > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: > >> On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: > >> > >>> On Thu, Jul 28, 2016 at 09:55:11AM +0200,

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

+ Luis (again) ;-) On 29-07-16 08:13, Daniel Wagner wrote: > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: >> On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: >> >>> On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: From: Daniel Wagner >>

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On 07/28/2016 09:01 PM, Bjorn Andersson wrote: On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: From: Daniel Wagner [..] Do not quite like it... I'd rather asynchronous request give out a

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: > On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: > > From: Daniel Wagner > > [..] > > Do not quite like it... I'd rather asynchronous request give out a > firmware status pointer that could be used

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > Loading firmware is an operation many drivers implement in various ways > around the completion API. And most of them do it almost in the same > way. Let's reuse the firmware_stat