Re: Where to report mpdus tx vs failed?

2018-10-23 Thread Johannes Berg
On Mon, 2018-10-22 at 10:16 -0700, Ben Greear wrote: > > > We have NL80211_STA_INFO_TX_RETRIES, shouldn't you be able to capture it > > > there? > > > > Or, per TID, NL80211_TID_STATS_TX_MSDU_RETRIES > > I added this code (rate is struct ieee80211_tx_rate) > > if (tx_done->mpdus_failed) {

Re: Where to report mpdus tx vs failed?

2018-10-22 Thread Ben Greear
On 10/22/2018 05:07 AM, Johannes Berg wrote: On Mon, 2018-10-22 at 14:06 +0200, Johannes Berg wrote: On Fri, 2018-10-19 at 11:32 -0700, Ben Greear wrote: I was hoping I could fit it into some existing stat. It is sort of like retries, so that will be my first attempt. By investigating an RF

Re: Where to report mpdus tx vs failed?

2018-10-22 Thread Johannes Berg
On Mon, 2018-10-22 at 14:06 +0200, Johannes Berg wrote: > On Fri, 2018-10-19 at 11:32 -0700, Ben Greear wrote: > > > > I was hoping I could fit it into some existing stat. It is sort of like > > retries, so that will be my first attempt. > > > > By investigating an RF sniff, I notice the 9880 at

Re: Where to report mpdus tx vs failed?

2018-10-22 Thread Johannes Berg
On Fri, 2018-10-19 at 11:32 -0700, Ben Greear wrote: > > I was hoping I could fit it into some existing stat. It is sort of like > retries, so that will be my first attempt. > > By investigating an RF sniff, I notice the 9880 ath10k (with my fw > and driver, at least), will retransmit about 30%

Re: Where to report mpdus tx vs failed?

2018-10-19 Thread Ben Greear
On 10/19/2018 11:25 AM, Steve deRosier wrote: On Fri, Oct 19, 2018 at 10:34 AM Ben Greear wrote: While debugging rate-ctrl in ath10k, I found the amount of mpdus transmitted vs failed ratio useful. Probably more useful than retries since retries could count an attempt at 80Mhz followed by H

Re: Where to report mpdus tx vs failed?

2018-10-19 Thread Steve deRosier
On Fri, Oct 19, 2018 at 10:34 AM Ben Greear wrote: > > While debugging rate-ctrl in ath10k, I found the amount of mpdus transmitted > vs failed > ratio useful. Probably more useful than retries since retries could count an > attempt at > 80Mhz followed by HW trying a 40Mhz rate (afaik). > > Is

Where to report mpdus tx vs failed?

2018-10-19 Thread Ben Greear
While debugging rate-ctrl in ath10k, I found the amount of mpdus transmitted vs failed ratio useful. Probably more useful than retries since retries could count an attempt at 80Mhz followed by HW trying a 40Mhz rate (afaik). Is there a good way to report this up the stack in a useful manner?