Re: brcmfmac: testing the wrong variable in brcmf_rx_hdrpull()

2016-04-26 Thread Kalle Valo
> Smatch complains about this code: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c:335 > brcmf_rx_hdrpull() > error: we previously assumed '*ifp' could be null (see line 333) > > The problem is that we recently changed these from "ifp" to "*ifp" but > there was one that we

Re: [patch] brcmfmac: testing the wrong variable in brcmf_rx_hdrpull()

2016-04-20 Thread Arend Van Spriel
On 19-4-2016 16:25, Dan Carpenter wrote: > Smatch complains about this code: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c:335 > brcmf_rx_hdrpull() > error: we previously assumed '*ifp' could be null (see line 333) > > The problem is that we recently changed these from

[patch] brcmfmac: testing the wrong variable in brcmf_rx_hdrpull()

2016-04-19 Thread Dan Carpenter
Smatch complains about this code: drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c:335 brcmf_rx_hdrpull() error: we previously assumed '*ifp' could be null (see line 333) The problem is that we recently changed these from "ifp" to "*ifp" but there was one that we didn't update.