Re: iwlwifi firmware load broken in current -git

2017-09-16 Thread Jens Axboe
On 09/15/2017 09:03 PM, Bjorn Helgaas wrote: > On Fri, Sep 15, 2017 at 01:55:57PM -0600, Jens Axboe wrote: >> On 09/15/2017 01:51 PM, Luca Coelho wrote: >>> On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote: On 09/15/2017 01:38 PM, Linus Torvalds wrote: > On Fri, Sep 15, 2017 at 12:32

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Bjorn Helgaas
On Fri, Sep 15, 2017 at 01:55:57PM -0600, Jens Axboe wrote: > On 09/15/2017 01:51 PM, Luca Coelho wrote: > > On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote: > >> On 09/15/2017 01:38 PM, Linus Torvalds wrote: > >>> On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: > > >

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/15/2017 01:51 PM, Linus Torvalds wrote: > On Fri, Sep 15, 2017 at 12:43 PM, Luca Coelho wrote: >> On Fri, 2017-09-15 at 12:38 -0700, Linus Torvalds wrote: >>> >>> From some of the context it looks like commit 40f11adc7cd9 ("PCI: >>> Avoid race while enabling upstream

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/15/2017 01:51 PM, Luca Coelho wrote: > On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote: >> On 09/15/2017 01:38 PM, Linus Torvalds wrote: >>> On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: > > In any case, your patch introduces a regression on systems.

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Linus Torvalds
On Fri, Sep 15, 2017 at 12:43 PM, Luca Coelho wrote: > On Fri, 2017-09-15 at 12:38 -0700, Linus Torvalds wrote: >> >> From some of the context it looks like commit 40f11adc7cd9 ("PCI: >> Avoid race while enabling upstream bridges"), is that correct? > > Yes, that's the one. And

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote: > On 09/15/2017 01:38 PM, Linus Torvalds wrote: > > On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: > > > > > > > > In any case, your patch introduces a regression on systems. Please get > > > > it reverted now, and then

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/15/2017 01:38 PM, Linus Torvalds wrote: > On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: >>> >>> In any case, your patch introduces a regression on systems. Please get >>> it reverted now, and then you can come up with a new approach to fix the >>> double enable of the

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/15/2017 01:36 PM, Luca Coelho wrote: > On Fri, 2017-09-15 at 13:32 -0600, Jens Axboe wrote: >> On 09/14/2017 02:36 PM, Jens Axboe wrote: >>> On 09/14/2017 02:04 PM, Srinath Mannam wrote: Hi Jens Axboe, On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote:

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 12:38 -0700, Linus Torvalds wrote: > On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: > > > > > > In any case, your patch introduces a regression on systems. Please get > > > it reverted now, and then you can come up with a new approach to fix the > > >

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Linus Torvalds
On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: >> >> In any case, your patch introduces a regression on systems. Please get >> it reverted now, and then you can come up with a new approach to fix the >> double enable of the upstream bridge. > > Who's sending in the revert? I

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 13:32 -0600, Jens Axboe wrote: > On 09/14/2017 02:36 PM, Jens Axboe wrote: > > On 09/14/2017 02:04 PM, Srinath Mannam wrote: > > > Hi Jens Axboe, > > > > > > > > > On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote: > > > > On 09/14/2017 11:35 AM, Jens

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/14/2017 02:36 PM, Jens Axboe wrote: > On 09/14/2017 02:04 PM, Srinath Mannam wrote: >> Hi Jens Axboe, >> >> >> On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote: >>> On 09/14/2017 11:35 AM, Jens Axboe wrote: On 09/14/2017 11:28 AM, Srinath Mannam wrote: > Hi

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 02:04 PM, Srinath Mannam wrote: > Hi Jens Axboe, > > > On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote: >> On 09/14/2017 11:35 AM, Jens Axboe wrote: >>> On 09/14/2017 11:28 AM, Srinath Mannam wrote: Hi Bjorn, On Thu, Sep 14, 2017 at 10:52 PM,

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Srinath Mannam
Hi Jens Axboe, On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote: > On 09/14/2017 11:35 AM, Jens Axboe wrote: >> On 09/14/2017 11:28 AM, Srinath Mannam wrote: >>> Hi Bjorn, >>> >>> On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: On 09/14/2017

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Johannes Berg
On Thu, 2017-09-14 at 23:14 +0530, Srinath Mannam wrote: > > atomic_inc_return(>enable_cnt) in function > pci_enable_device_flags enables passed pcie device. > !pci_is_enabled(bridge) check in "if (bridge && > !pci_is_enabled(bridge))"  checks for bridge device of previous pcie > device. > So it

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 11:44 AM, Srinath Mannam wrote: > Hi Jens Axboe, > > On Thu, Sep 14, 2017 at 11:05 PM, Jens Axboe wrote: >> On 09/14/2017 11:28 AM, Srinath Mannam wrote: >>> Hi Bjorn, >>> >>> On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: On

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 11:35 AM, Jens Axboe wrote: > On 09/14/2017 11:28 AM, Srinath Mannam wrote: >> Hi Bjorn, >> >> On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: >>> >>> On 09/14/2017 11:11 AM, Bjorn Helgaas wrote: [+cc linux-pci] On Thu, Sep 14, 2017 at 12:00 PM,

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Srinath Mannam
Hi Jens Axboe, On Thu, Sep 14, 2017 at 11:05 PM, Jens Axboe wrote: > On 09/14/2017 11:28 AM, Srinath Mannam wrote: >> Hi Bjorn, >> >> On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: >>> >>> On 09/14/2017 11:11 AM, Bjorn Helgaas wrote: [+cc linux-pci]

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 11:28 AM, Srinath Mannam wrote: > Hi Bjorn, > > On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: >> >> On 09/14/2017 11:11 AM, Bjorn Helgaas wrote: >>> [+cc linux-pci] >>> >>> On Thu, Sep 14, 2017 at 12:00 PM, Jens Axboe wrote: On

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Srinath Mannam
Hi Bjorn, On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: > > On 09/14/2017 11:11 AM, Bjorn Helgaas wrote: > > [+cc linux-pci] > > > > On Thu, Sep 14, 2017 at 12:00 PM, Jens Axboe wrote: > >> On 09/12/2017 02:04 PM, Johannes Berg wrote: > >>> On Tue,

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 11:11 AM, Bjorn Helgaas wrote: > [+cc linux-pci] > > On Thu, Sep 14, 2017 at 12:00 PM, Jens Axboe wrote: >> On 09/12/2017 02:04 PM, Johannes Berg wrote: >>> On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: >>> CC'ing the guilty part and Bjorn. I'm assuming

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Bjorn Helgaas
[+cc linux-pci] On Thu, Sep 14, 2017 at 12:00 PM, Jens Axboe wrote: > On 09/12/2017 02:04 PM, Johannes Berg wrote: >> On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: >> >>> CC'ing the guilty part and Bjorn. I'm assuming it's the >>> pci_is_enabled() check, since the rest of

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/12/2017 02:04 PM, Johannes Berg wrote: > On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: > >> CC'ing the guilty part and Bjorn. I'm assuming it's the >> pci_is_enabled() check, since the rest of the patch shouldn't have >> functional changes. > > and pci_enable_bridge() already checks

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Johannes Berg
On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: > CC'ing the guilty part and Bjorn. I'm assuming it's the > pci_is_enabled() check, since the rest of the patch shouldn't have > functional changes. and pci_enable_bridge() already checks if it's already enabled, but still enables mastering in

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Luca Coelho
On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: > On 09/12/2017 10:36 AM, Luca Coelho wrote: > > On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: > > > Hi Jens, > > > > > > On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: > > > > Hi, > > > > > > > > I have no wifi in current

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Jens Axboe
On 09/12/2017 10:36 AM, Luca Coelho wrote: > On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: >> Hi Jens, >> >> On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: >>> Hi, >>> >>> I have no wifi in current git (8fac2f96ab8), it simply fails with: >>> >>> [4.363481] iwlwifi

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Jens Axboe
On 09/12/2017 10:36 AM, Luca Coelho wrote: > On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: >> Hi Jens, >> >> On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: >>> Hi, >>> >>> I have no wifi in current git (8fac2f96ab8), it simply fails with: >>> >>> [4.363481] iwlwifi

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Luca Coelho
On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: > Hi Jens, > > On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: > > Hi, > > > > I have no wifi in current git (8fac2f96ab8), it simply fails with: > > > > [4.363481] iwlwifi :04:00.0: Direct firmware load for > >

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Jens Axboe
On 09/12/2017 10:11 AM, Coelho, Luciano wrote: > Hi Jens, > > On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: >> Hi, >> >> I have no wifi in current git (8fac2f96ab8), it simply fails with: >> >> [4.363481] iwlwifi :04:00.0: Direct firmware load for >> iwlwifi-8000C-34.ucode failed

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Coelho, Luciano
Hi Jens, On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: > Hi, > > I have no wifi in current git (8fac2f96ab8), it simply fails with: > > [4.363481] iwlwifi :04:00.0: Direct firmware load for > iwlwifi-8000C-34.ucode failed with error -2 > [4.363733] iwlwifi :04:00.0:

iwlwifi firmware load broken in current -git

2017-09-12 Thread Jens Axboe
Hi, I have no wifi in current git (8fac2f96ab8), it simply fails with: [4.363481] iwlwifi :04:00.0: Direct firmware load for iwlwifi-8000C-34.ucode failed with error -2 [4.363733] iwlwifi :04:00.0: Direct firmware load for iwlwifi-8000C-33.ucode failed with error -2 [