Re: [PATCH] rtlwifi/rtl8192de: remove redundant else if check

2015-01-13 Thread Larry Finger
On 01/13/2015 08:07 AM, Colin King wrote: From: Colin Ian King colin.k...@canonical.com The else if check condition checks for the opposite of the if check, hence the else if check is redundant and can be replaced with a simple else: if (rtlpriv-rtlhal.macphymode == SINGLEMAC_SINGLEPHY) {

[PATCH] NFC: hci: llc: Remove unused function

2015-01-13 Thread Rickard Strandqvist
Remove the function nfc_llc_unregister() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- net/nfc/hci/llc.c | 13 - net/nfc/hci/llc.h |1 -

[RFC 1/2] cfg80211: add VHT support for IBSS

2015-01-13 Thread Janusz Dziedzic
Add VHT support for IBSS. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com --- include/net/cfg80211.h | 17 + include/uapi/linux/nl80211.h | 2 ++ net/wireless/nl80211.c | 34 -- 3 files changed, 51 insertions(+), 2

[RFC 2/2] mac80211: add VHT support for IBSS

2015-01-13 Thread Janusz Dziedzic
Add VHT support for IBSS. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com --- net/mac80211/ibss.c| 29 + net/mac80211/ieee80211_i.h | 11 +++ net/mac80211/main.c| 1 + net/mac80211/util.c| 35

[PATCH] ath10k: fix config_enabled check for hwmon

2015-01-13 Thread Rajkumar Manoharan
Because of wrong macro check in config_enabled, hwmon never be enabled. Fix that. Signed-off-by: Rajkumar Manoharan rmano...@qti.qualcomm.com --- drivers/net/wireless/ath/ath10k/thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 8/8] ath10k: fix error return code

2015-01-13 Thread Kalle Valo
Julia Lawall julia.law...@lip6.fr writes: Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return

[PATCH iw] Read number of supported net-detect matches

2015-01-13 Thread Luca Coelho
From: Luciano Coelho luciano.coe...@intel.com Instead of just printing whether netdetect is supported, parse the attribute and report the maximum number of matchsets the driver supports. Signed-off-by: Luciano Coelho luciano.coe...@intel.com --- info.c | 5 +++-- 1 file changed, 3

Re: [PATCH RESEND] ath10k: Fix potential Rx ring corruption

2015-01-13 Thread Kalle Valo
Vasanthakumar Thiagarajan vthia...@qti.qualcomm.com writes: When replenishing Rx buffers driver updates the address of the buffer and the index of rx buffer in rx ring to the firmware. Change in order by CPU can cause rx ring corruption. Add memory barrier before updating rx buffer index to

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-13 Thread Kalle Valo
Vasanthakumar Thiagarajan vthia...@qti.qualcomm.com writes: This patch adds a module parameter to adjust the fill size based on the platform/usage. I don't think this should be adjustable. Default value of 16 causes rx ring corruption within 1 hour of stress testing. Increasing this limit

Re: [PATCH v3] ath10k: fixup wait_for_completion_timeout return handling

2015-01-13 Thread Kalle Valo
Nicholas Mc Guire der.h...@hofr.at writes: wait_for_completion_timeout does not return negative values so the tests for = 0 are not needed and the case differentiation in the error handling path unnecessary. Signed-off-by: Nicholas Mc Guire der.h...@hofr.at Thanks, applied to ath.git. --

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-13 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: I have a patch internally which removes the replenishment tasklet and I wonder how will it behave with rx batching then, hmm.. I tried that earlier and could see only marginal improvement. The biggest increase came when I replaced

[PATCH] rtlwifi/rtl8192de: remove redundant else if check

2015-01-13 Thread Colin King
From: Colin Ian King colin.k...@canonical.com The else if check condition checks for the opposite of the if check, hence the else if check is redundant and can be replaced with a simple else: if (rtlpriv-rtlhal.macphymode == SINGLEMAC_SINGLEPHY) { .. } else if (rtlpriv-rtlhal.macphymode

Re: [PATCH] ath10k: fix config_enabled check for hwmon

2015-01-13 Thread Kalle Valo
Rajkumar Manoharan rmano...@qti.qualcomm.com writes: Because of wrong macro check in config_enabled, hwmon never be enabled. Fix that. Signed-off-by: Rajkumar Manoharan rmano...@qti.qualcomm.com Ouch, thanks for fixing my bug. Applied to ath.git. -- Kalle Valo -- To unsubscribe from this

[PATCH] ath10k: fix duration calculation for quiet param

2015-01-13 Thread Rajkumar Manoharan
The duty cycle (% of quiet duration) is used to put the device in quiet mode for the given period. Currently the quiet duration is wrongly calculated which results in not enabling quiet mode. Fix the calculation as below duration = (period * duty cycle) / 100 Signed-off-by: Rajkumar

Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-13 Thread Zefir Kurtisi
On 01/10/2015 05:26 PM, Simon Wunderlich wrote: On Friday 09 January 2015 19:57:37 Arend van Spriel wrote: On 01/09/15 17:54, Simon Wunderlich wrote: Performing spectral scans on 5 GHz channels may result in PHY errors sent by the hardware, even if DFS support is not enabled in the driver

Re: [PATCH v2 2/2] cfg80211: avoid reg-hints in self-managed only systems

2015-01-13 Thread Arik Nemtsov
On Tue, Jan 13, 2015 at 12:30 PM, Julian Calaby julian.cal...@gmail.com wrote: Hi Arik, On Tue, Jan 13, 2015 at 9:11 PM, Arik Nemtsov a...@wizery.com wrote: On Tue, Jan 13, 2015 at 6:26 AM, Julian Calaby julian.cal...@gmail.com wrote: Hi Arik, On Thu, Jan 8, 2015 at 1:47 AM, Arik Nemtsov

Re: Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-13 Thread Simon Wunderlich
On Tuesday 13 January 2015 11:16:02 Zefir Kurtisi wrote: On 01/10/2015 05:26 PM, Simon Wunderlich wrote: On Friday 09 January 2015 19:57:37 Arend van Spriel wrote: On 01/09/15 17:54, Simon Wunderlich wrote: Performing spectral scans on 5 GHz channels may result in PHY errors sent by the

Re: [PATCH v2 2/2] cfg80211: avoid reg-hints in self-managed only systems

2015-01-13 Thread Arik Nemtsov
On Tue, Jan 13, 2015 at 6:26 AM, Julian Calaby julian.cal...@gmail.com wrote: Hi Arik, On Thu, Jan 8, 2015 at 1:47 AM, Arik Nemtsov a...@wizery.com wrote: When a system contains only self-managed regulatory devices all hints from the regulatory core are ignored. Stop hint processing early in

Re: [PATCH v2 2/2] cfg80211: avoid reg-hints in self-managed only systems

2015-01-13 Thread Julian Calaby
Hi Arik, On Tue, Jan 13, 2015 at 9:35 PM, Arik Nemtsov a...@wizery.com wrote: On Tue, Jan 13, 2015 at 12:30 PM, Julian Calaby julian.cal...@gmail.com wrote: Hi Arik, On Tue, Jan 13, 2015 at 9:11 PM, Arik Nemtsov a...@wizery.com wrote: On Tue, Jan 13, 2015 at 6:26 AM, Julian Calaby

Re: [PATCH v2 2/2] cfg80211: avoid reg-hints in self-managed only systems

2015-01-13 Thread Julian Calaby
Hi Arik, On Tue, Jan 13, 2015 at 9:11 PM, Arik Nemtsov a...@wizery.com wrote: On Tue, Jan 13, 2015 at 6:26 AM, Julian Calaby julian.cal...@gmail.com wrote: Hi Arik, On Thu, Jan 8, 2015 at 1:47 AM, Arik Nemtsov a...@wizery.com wrote: When a system contains only self-managed regulatory

RE: mwifiex - question

2015-01-13 Thread Avinash Patil
Hi Wim, Mwifiex is FullMac driver; we have our own thick FW for managing MLME. This is reason why we do not use mac80211. Mwifiex is very much located under drivers/net/wireless; its not in net/wireless. net/wireless has cfg80211 driver. Thanks, Avinash.

pull request: iwlwifi 2015-01-13

2015-01-13 Thread Grumbach, Emmanuel
Hi Kalle, This is a pull request for 3.19. As usual, the description is in the tag itself. This time, we are already in -rc4, no gray area patches. These are all real bug fixes. Let me know if you have issues with this. BTW - if you wish, I can add the diff in the pull request for -rc cycle.

[PATCH 2/3] iwlwifi: mvm: drop non VO frames when flushing

2015-01-13 Thread Emmanuel Grumbach
This change has already been implemented in iwldvm: commit a260e7b3f0307878b99d57ed1406cf2d497923b8 Author: Emmanuel Grumbach emmanuel.grumb...@intel.com Date: Sun Oct 5 09:11:14 2014 +0300 iwlwifi: dvm: drop non VO frames when flushing Since I added the flush() callback implementation in

Re: [PATCH 1/8] ath10k: scan should handle scan-start-failed event properly.

2015-01-13 Thread Kalle Valo
Ben Greear gree...@candelatech.com writes: Sorry about the resends...had mail-server issue, should be resolved now. So which one should I look at? Or are the patches the same in both sets? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of

Re: mwifiex - question

2015-01-13 Thread wim torfs
Hi Avinash, Thanks for the clarification. Obviously I missed the most important part of the path, which caused the confusion. Thanks, Wim. On 01/13/2015 02:44 PM, Avinash Patil wrote: Hi Wim, Mwifiex is FullMac driver; we have our own thick FW for managing MLME. This is reason why we do

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-13 Thread Kalle Valo
Sujith Manoharan suj...@msujith.org writes: From: Sujith Manoharan c_man...@qca.qualcomm.com The HTT RX ring is replenished with a maximum of 16 buffers, but this might be insufficient when RX traffic is high. Not having enough RX buffers throttles the FW, resulting in low throughput.

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-13 Thread Sujith Manoharan
Kalle Valo wrote: I tried that earlier and could see only marginal improvement. The biggest increase came when I replaced netif_receive_skb() with netif_rx() in mac80211/rx.c. Any ideas why that increases throughput? Not sure, but RPS is enabled by default on this platform, so maybe that

Re: (re)licensing the wireless wiki

2015-01-13 Thread Nick Kossifidis
2015-01-12 20:57 GMT+02:00 Pat Erley pat-l...@erley.org: On 01/12/2015 09:26 AM, Johannes Berg wrote: On Mon, 2015-01-12 at 12:16 +0100, Johannes Berg wrote: I've emailed every contributor who I could find an email address for, but some (~40) don't have an email address and I already have a