[PATCH] rfkill: fix rfkill_fop_read wait_event usage

From: Johannes Berg The code within wait_event_interruptible() is called with !TASK_RUNNING, so mustn't call any functions that can sleep, like mutex_lock(). Since we re-check the list_empty() in a loop after the wait, it's safe to simply use list_empty() without

[PATCH 2/5] iwlwifi: add device ID for 8265

From: Oren Givon Signed-off-by: Oren Givon Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 5/5] iwlwifi: mvm: rs: fix TPC statistics handling

From: Gregory Greenman FW behaviour changed and now updates driver about the used TPC reduction in the following cases: 1. In tx response, which is used mostly for a single frame case 2. In BA notification When tx aggregation fails with the initial rate, FW will send

[PATCH 4/5] iwlwifi: update support for 3168 series firmware and NVM

From: Oren Givon Update the struct which defines the support for 3168 cards. Now it will search for a firmware of this format: iwlwifi-3168-XX.ucode Also, set the minimum version of the ucode to 20. Update the minimum NVM version and minimum NVM calibrations version of the

[PATCH 3/5] iwlwifi: dvm: calib.c: fix min() warning

From: Johannes Berg Depending on the system, kernel, architecture abs() might return long or not - just use min_t(u8, ...) to avoid any warnings. Reported-by: Andrew Morton Signed-off-by: Johannes Berg Signed-off-by:

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

On Mon, 2016-01-25 at 21:07 +0100, Arend van Spriel wrote: > On 25-1-2016 20:23, Doug Anderson wrote: > > Kinda curious: do we get one or two really slow responses on every > > bootup, or just some bootups?  Do we ever succeed even with a slow > > (like 1.8 or 1.9 seconds) response, or is it

[RFC V3 2/2] brcmfmac: add support for nl80211 BSS_SELECT feature

Announce support for nl80211 feature BSS_SELECT and process BSS selection behaviour provided in .connect() callback. Reviewed-by: Hante Meuleman Reviewed-by: Franky (Zhenhui) Lin Reviewed-by: Pieter-Paul Giesberts Reviewed-by:

[RFC V3 0/2] nl80211: allow configuration of BSS selection

This patch series adds support for configuration of BSS selection done by the driver and/or firmware. It allows user-space to pass selection criteria with the NL80211_CMD_CONNECT using NL80211_ATTR_BSS_SELECT. When user-space does provide this attribute and no explicit BSSID is provided it will

pull request: iwlwifi 2016-01-26

Hi Kalle, This is the first round of fixes for 4.5. Most of them are really trivial. The TPC stats one stands out a little bit. It can fix traffic issues which are typically hard to debug. Please pull and let me know if you have issues. I also have a batch of patches for -next, but

UBSAN: Undefined behaviour in net/mac80211/rc80211_minstrel.h:47:34

4.5.0-rc1 with the new UBSAN checker: [ 2624.978741] [ 2624.978749] UBSAN: Undefined behaviour in net/mac80211/rc80211_minstrel.h:47:34 [ 2624.978752] signed integer overflow: [ 2624.978754] -32768 * 100 cannot

Re: [PATCH 16/26] libceph: Use skcipher

On Tue, Jan 26, 2016 at 12:29:57PM +0100, Ilya Dryomov wrote: > > LGTM. You want to take it through crypto? That's probably the easiest route since I'd like to take the first patch through cryptodev. Thanks, -- Email: Herbert Xu Home Page:

Re: [PATCH 2/2] mac80211: expose txq queue depth and size to drivers

On 26 January 2016 at 11:45, Felix Fietkau wrote: > On 2016-01-21 14:23, Michal Kazior wrote: >> This will allow drivers to make more educated >> decisions whether to defer transmission or not. >> >> Relying on wake_tx_queue() call count implicitly >> was not possible because it

[RFC V3 1/2] nl80211: add feature for BSS selection support

Introducing a new feature that the driver can use to indicate the driver/firmware supports configuration of BSS selection criteria upon CONNECT command. This can be useful when multiple BSS-es are found belonging to the same ESS, ie. Infra-BSS with same SSID. The criteria can then be used to

Re: net/rfkill: WARNING in rfkill_fop_read

On Tue, 2016-01-26 at 10:55 +0100, Dmitry Vyukov wrote: > Hello, > > The following program triggers WARNING message in rfkill_fop_read: > > [ cut here ] > WARNING: CPU: 2 PID: 6975 at kernel/sched/core.c:7663 > __might_sleep+0x138/0x1a0() > do not call blocking ops when

Re: [PATCH 2/2] mac80211: expose txq queue depth and size to drivers

On 2016-01-21 14:23, Michal Kazior wrote: > This will allow drivers to make more educated > decisions whether to defer transmission or not. > > Relying on wake_tx_queue() call count implicitly > was not possible because it could be called > without queued frame count actually changing on >

net/rfkill: WARNING in rfkill_fop_read

Hello, The following program triggers WARNING message in rfkill_fop_read: [ cut here ] WARNING: CPU: 2 PID: 6975 at kernel/sched/core.c:7663 __might_sleep+0x138/0x1a0() do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait_event+0x141/0x410

Re: [PATCH 16/26] libceph: Use skcipher

On Mon, Jan 25, 2016 at 05:18:47PM +0100, Ilya Dryomov wrote: > > Could you get rid of ivsize instead of assigning to it - see the > attached diff? How about an incremental patch like this? Thanks! ---8<--- From: Ilya Dryomov Subject: libceph: Remove unnecessary ivsize

Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

On Tue, 2015-10-20 at 10:24 -0700, gree...@candelatech.com wrote: > --- a/include/uapi/linux/nl80211.h > +++ b/include/uapi/linux/nl80211.h > @@ -2130,6 +2130,8 @@ enum nl80211_attrs { >   >   NL80211_ATTR_REG_INDOOR, >   > + NL80211_ATTR_TX_ADVERT_RATEMASK, First of all, this is missing

Re: [PATCH-v2 2/2] mac80211: ensure association req uses configured ratemask.

On Tue, 2015-10-20 at 10:24 -0700, gree...@candelatech.com wrote: > From: Ben Greear > > When sending the association request, pay attention to the > legacy rates configured by the user, and do not advertise support > for any that are not configured. > > This makes the

Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

On Tue, 2016-01-19 at 09:04 +0100, Henning Rogge wrote: > +++ b/net/mac80211/mesh_pathtbl.c > @@ -929,12 +929,55 @@ int mesh_path_del(struct ieee80211_sub_if_data > *sdata, const u8 *addr) >   if (mpath->sdata == sdata && >   ether_addr_equal(addr, mpath->dst)) { >  

[PATCH] staging: wilc1000: fix alignment for open parenthesis

This patch fixes the check found by checkpatch.pl CHECK: Alignment should match open parenthesis Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 90 +++ 1 file changed, 45 insertions(+), 45 deletions(-) diff --git

pull-request: mac80211 2016-01-26

Hi Dave, After split up the patches from the previous pull request that was lost in the process, here's a new one with fixes for the current cycle (I'll follow up with a -next one later.) I've also scripted my pull-request sending process a bit more, so hopefully the emails will no longer have

Re: [PATCH 13/13] ath10k: implement push-pull tx

On 22 January 2016 at 08:47, Michal Kazior wrote: > On 21 January 2016 at 18:40, Peter Oh wrote: >> On 01/21/2016 05:46 AM, Michal Kazior wrote: [...] >>> - /* TODO: apply configuration */ >>> + rcu_read_unlock(); >>> + >>> +

Re: [PATCH] mac80211: Requeue work after scan complete for all VIF types.

On Tue, 2016-01-12 at 14:30 +0530, Sachin Kulkarni wrote: > From: Sachin Kulkarni > > During a sw scan ieee80211_iface_work ignores work items for all > vifs. > However after the scan complete work is requeued only for STA, ADHOC > and MESH iftypes. > > This

UBSAN: Undefined behaviour in net/mac80211/rx.c:924:18

4.5.0-rc1 another UBSAN error: [ 4845.229441] [ 4845.229454] UBSAN: Undefined behaviour in net/mac80211/rx.c:924:18 [ 4845.229458] load of value 2 is not a valid value for type '_Bool' [ 4845.229464] CPU: 1 PID:

Re: [PATCH 16/26] libceph: Use skcipher

On Tue, Jan 26, 2016 at 11:54 AM, Herbert Xu wrote: > On Mon, Jan 25, 2016 at 05:18:47PM +0100, Ilya Dryomov wrote: >> >> Could you get rid of ivsize instead of assigning to it - see the >> attached diff? > > How about an incremental patch like this? Thanks! > >

RE: [PATCH v2] iwldvm: fix chain gain calibration when firmware return zero values

> Hi > > 2016-01-26 3:28 GMT-05:00 Grumbach, Emmanuel > : > > > > > > On 01/26/2016 12:20 AM, Nikolay Martynov wrote: > >> It looks like sometimes firmware returns zero for chain noise and > >> signal during calibration period. This seems to be a known problem > >>

Need direction to understand mac80211

Hi, I am currently working on an project that aims to provide multiple 802.11ac radio support on a single node for mesh network. In this both the radios will operate in different channel and will talk to different nodes in mesh network. I need to work with kernel mac80211 driver subsystem for

Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties withrfkill_gpio

On Mon, 2016-01-25 at 21:59 +0100, Marc Dietrich wrote: >  > seems to work fine. I wish we could instantiate this from device-tree > so we can finially get rid of this file. That'd be nice - anyone want to propose rfkill DT bindings? :) johannes -- To unsubscribe from this list: send the line

Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio

On Mon, 2016-01-25 at 13:18 +0100, Thierry Reding wrote: >  > Johannes, I assume that you'll want to take this through your tree > because of the dependency? In that case: > > Acked-by: Thierry Reding I can, but I don't really care - perhaps you'd rather take the entire

Re: [PATCH v2] iwldvm: fix chain gain calibration when firmware return zero values

On 01/26/2016 12:20 AM, Nikolay Martynov wrote: > It looks like sometimes firmware returns zero for chain noise and signal > during calibration period. This seems to be a known problem and current > implementation accounts for this by ignoring invalid data when all chains > return zero signal

Re: [PATCHv2 3/4] ARM: tegra: use build-in device propertieswithrfkill_gpio

Am Dienstag, 26. Januar 2016, 09:46:56 CET schrieb Johannes Berg: > On Mon, 2016-01-25 at 21:59 +0100, Marc Dietrich wrote: > > > > > > seems to work fine. I wish we could instantiate this from device-tree > > so we can finially get rid of this file. > > That'd be nice - anyone want to propose

Re: [PATCH] mac80211: Parse legacy and HT rate in injected frames

On Mon, 2016-01-25 at 13:59 +0100, Sven Eckelmann wrote: >  > The flag itself has to be set when the radiotap information is > available+parsed and when the actual rate information calculation > should > happen. > > Afaik the ieee80211_tx_data is always a local variable on the stack. > Either >

Re: [RFC/RFT v4 2/2] mac80211: add NEED_ALIGNED4_SKBS hw flag

On Thu, 2016-01-21 at 10:30 +0100, Janusz Dziedzic wrote: >  > +static inline unsigned int > +__ieee80211_hdrlen(struct ieee80211_hw *hw, __le16 fc) { coding style - should have that brace on the next line perhaps this really ought to be called ieee80211_padded_hdrlen() or so instead of just

Re: pull request: iwlwifi 2016-01-26

"Grumbach, Emmanuel" writes: > This is the first round of fixes for 4.5. Most of them are really > trivial. The TPC stats one stands out a little bit. It can fix traffic > issues which are typically hard to debug. Please pull and let me know > if you have issues.

Re: [RFC V4 1/2] nl80211: add feature for BSS selection support

On Tue, 2016-01-26 at 14:06 +0100, Arend van Spriel wrote: >  > + * @behaviour: requested BSS selection behaviour. > + * @param: parameters for requestion behaviour. > + * @band_pref: preferred band for > %NL80211_BSS_SELECT_ATTR_BAND_PREF. > + * @adjust: parameters for

Re: pull request: iwlwifi 2016-01-26

Hi Kalle, On 01/26/2016 03:51 PM, Kalle Valo wrote: > "Grumbach, Emmanuel" writes: > >> This is the first round of fixes for 4.5. Most of them are really >> trivial. The TPC stats one stands out a little bit. It can fix traffic >> issues which are typically hard to

Re: pull request: iwlwifi 2016-01-26

> > There's a conflict due to 8f57e4d930d, how should I fix it? I think we can thus drop my patch - that commit fixes the issue that Andrew had reported as well, and that I worked around by casting the result... now that abs() has a consistent result, using s32 in both sides of the min() is

Re: pull request: iwlwifi 2016-01-26

On 01/26/2016 04:01 PM, Johannes Berg wrote: >>> There's a conflict due to 8f57e4d930d, how should I fix it? > I think we can thus drop my patch - that commit fixes the issue that > Andrew had reported as well, and that I worked around by casting the > result... now that abs() has a consistent

Re: [PATCH v2] iwldvm: fix chain gain calibration when firmware return zero values

Hi 2016-01-26 3:28 GMT-05:00 Grumbach, Emmanuel : > > > On 01/26/2016 12:20 AM, Nikolay Martynov wrote: >> It looks like sometimes firmware returns zero for chain noise and signal >> during calibration period. This seems to be a known problem and current >>

Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block

Raja Mani writes: > Add device tree binding documentation details for wifi block present > in Qualcomm IPQ4019 SoC into "qcom,ath10k.txt". > > Right now, ath10k wireless driver has support for PCI based wlan devices. > There is a plan to extend ath10k driver to support

Re: [PATCH] ath10k: prevent txrx running for too long

Michal Kazior writes: > On multicore systems it was possible for the txrx > tasklet to keep on running for long periods of > time on a single CPU due to tx completion > processing. Another CPU could feed the running > tasklet for an indefinite amount of time. > > The

Re: [PATCH 0/7] Add support for Per STA Rx duration

Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > From: Mohammed Shafi Shajakhan > > *Enable parsing of rx_duration as part of peer stats support > by the new 10.2.4 firmware > *Add support to

Re: [PATCH] ath10k: Remove the p2p notice of absence info from 10.2.4 FW beacon info

Yanbo Li writes: > The p2p NOA never been supported at 10.2.4 FW, remove it to avoid SWBA > event parse error for multi beacon interval case. > > Signed-off-by: Yanbo Li Applied, thanks. -- Kalle Valo -- To unsubscribe from this list: send

Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

On 01/26/2016 03:16 AM, Johannes Berg wrote: On Tue, 2015-10-20 at 10:24 -0700, gree...@candelatech.com wrote: --- a/include/uapi/linux/nl80211.h +++ b/include/uapi/linux/nl80211.h @@ -2130,6 +2130,8 @@ enum nl80211_attrs { NL80211_ATTR_REG_INDOOR, +

Re: [PATCH 1/2] mac80211: fix txq queue related crashes

On 01/25/2016 10:35 PM, Michal Kazior wrote: On 25 January 2016 at 18:59, Ben Greear wrote: On 01/21/2016 05:23 AM, Michal Kazior wrote: The driver can access the queue simultanously while mac80211 tears down the interface. Without spinlock protection this could

[PATCH] bcma: claim only 14e4:4365 PCI Dell card with SoftMAC BCM43142

It seems 14e4:4365 pattern is too generic as there are two devices: 1) 14e4:4365 1028:0016 with SoftMAC BCM43142 chipset 2) 14e4:4365 14e4:4365 with FullMAC BCM4366 chipset The later one was found in D-Link DIR-885L router and we want to let brcmfmac handle it. Signed-off-by: Rafał Miłecki

[PATCH v3] mac80211: Parse legacy and HT rate in injected frames

Drivers/devices without their own rate control algorithm can get the information what rates they should use from either the radiotap header of injected frames or from the rate control algorithm. But the parsing of the legacy rate information from the radiotap header was removed in commit

Re: [PATCH v2] mac80211: Parse legacy and HT rate in injected frames

On Tuesday 26 January 2016 14:27:20 Johannes Berg wrote: > Hi, > > CALL_TXH(ieee80211_tx_h_select_key); > > - if (!ieee80211_hw_check(>local->hw, HAS_RATE_CONTROL)) > > + if (!ieee80211_hw_check(>local->hw, HAS_RATE_CONTROL) && > > + !(info->control.flags &

Re: [PATCH 17/26] mac802154: Use skcipher

Hello. On 24/01/16 14:18, Herbert Xu wrote: This patch replaces uses of blkcipher with skcipher. Signed-off-by: Herbert Xu --- net/mac802154/llsec.c | 41 +++-- net/mac802154/llsec.h |3 +-- 2 files changed, 24

[PATCH 2/5] brcmfmac: allow storing PMU core without wrapper address

Separated PMU core can be found in new devices and should be used for accessing PMU registers (which were routed through ChipCommon so far). This core is one of exceptions that doesn't have or need wrapper address to be still safely accessible. Signed-off-by: Rafał Miłecki ---

[PATCH 0/5] brcmfmac: support for new 14e43:4365 card with BCM4366

I got D-Link DIR-885L with two 14e4:4365 PCI cards both using BCM4366 chipset. It seems to have newer ChipCommon and separated PMU core so I needed these patches on top of recent Broadcom's work. Please note this patchset depends on: [PATCH 2/2] bcma: support PMU present as separated bus core as

[PATCH 4/5] brcmfmac: access PMU registers using standalone PMU core if available

On recent Broadcom chipsets PMU is present as separated core and it can't be accessed using ChipCommon anymore as it fails with e.g.: [ 18.198412] Unhandled fault: imprecise external abort (0x1406) at 0xb6da200f Add a new helper function that will return a proper core that should be used for

[PATCH 5/5] brcmfmac: add support for 14e4:4365 PCI ID with BCM4366 chipset

On Broadcom ARM routers BCM4366 cards are available with 14e4:4365 ID. Unfortunately this ID was already used by Broadcom for cards with BCM43142, a totally different chipset requiring SoftMAC driver. To avoid a conflict between brcmfmac and bcma use more specific ID entry with subvendor and

[PATCH 1/5] brcmfmac: analyze descriptors of current component only

So far we were looking for address descriptors without a check for crossing current component border. In case of dealing with unsupported descriptor or descriptor missing at all the code would incorrectly get data from another component. Consider this binary-described component from BCM4366 EROM:

[PATCH 3/5] brcmfmac: read extended capabilities of ChipCommon core

This is an extra bitfield with info about some present hardware. Signed-off-by: Rafał Miłecki --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 3 +++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.h | 2 ++ 2 files changed, 5 insertions(+) diff --git

Re: [PATCH 4/5] brcmfmac: access PMU registers using standalone PMU core if available

Hi Rafał, [auto build test ERROR on wireless-drivers/master] [also build test ERROR on v4.5-rc1 next-20160125] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

[PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

Reported-by: Dmitry Vyukov Cc: Lauro Ramos Venancio Cc: Aloisio Almeida Jr Cc: Samuel Ortiz Signed-off-by: Cong Wang --- net/nfc/llcp_commands.c | 2 +- 1 file

Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath

On Tue, Jan 26, 2016 at 12:41:25PM +0100, Johannes Berg wrote: > > + mpp = node->mpath; > > + if (ether_addr_equal(mpp->mpp, proxy)) { > > + spin_lock(>hashwlock[i]); > > + __mesh_path_del(tbl, node); > > +

Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath

On Tue, Jan 26, 2016 at 7:36 PM, Bob Copeland wrote: > On Tue, Jan 26, 2016 at 12:41:25PM +0100, Johannes Berg wrote: >> > + mpp = node->mpath; >> > + if (ether_addr_equal(mpp->mpp, proxy)) { >> > + spin_lock(>hashwlock[i]); >> > +

Re: [PATCH 13/13] ath10k: implement push-pull tx

On 01/26/2016 02:28 AM, Michal Kazior wrote: On 22 January 2016 at 08:47, Michal Kazior wrote: On 21 January 2016 at 18:40, Peter Oh wrote: On 01/21/2016 05:46 AM, Michal Kazior wrote: [...] - /* TODO: apply configuration */ +

Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath

On Tue, 2016-01-26 at 13:36 -0500, Bob Copeland wrote: > On Tue, Jan 26, 2016 at 12:41:25PM +0100, Johannes Berg wrote: > > > + mpp = node->mpath; > > > + if (ether_addr_equal(mpp->mpp, proxy)) { > > > + spin_lock(>hashwlock[i]); > > > +

Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath

On Tue, Jan 26, 2016 at 09:53:33PM +0100, Johannes Berg wrote: > Oh. Interesting. Yeah, I guess that should be OK then. > > It's not *nice*, since that's pretty much unexpected, and you then do > need the rcu_read_lock() ... hmm. Yeah, I puzzled over that a bit last week as well -- I rewrote it

Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath

On Tue, 2016-01-26 at 16:22 -0500, Bob Copeland wrote: >  > void mesh_path_flush_by_nexthop(struct sta_info *sta) > { > [...] > rhashtable_walk_start(); It seems you need to check the return value here? > while ((mpath = rhashtable_walk_next())) { > if

Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath

On Tue, 2016-01-26 at 22:31 +0100, Johannes Berg wrote: > On Tue, 2016-01-26 at 16:22 -0500, Bob Copeland wrote: > >   > > void mesh_path_flush_by_nexthop(struct sta_info *sta) > > { > > [...] > > rhashtable_walk_start(); > > It seems you need to check the return value here? > Actually,

Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath

On Tue, Jan 26, 2016 at 10:32:23PM +0100, Johannes Berg wrote: > On Tue, 2016-01-26 at 22:31 +0100, Johannes Berg wrote: > > On Tue, 2016-01-26 at 16:22 -0500, Bob Copeland wrote: > > >   > > > void mesh_path_flush_by_nexthop(struct sta_info *sta) > > > { > > > [...] > > >

[PATCH] mac80211: avoid excessive stack usage in sta_info

When CONFIG_OPTIMIZE_INLINING is set, the sta_info_insert_finish function consumes more stack than normally, exceeding the 1024 byte limit on ARM: net/mac80211/sta_info.c: In function 'sta_info_insert_finish': net/mac80211/sta_info.c:561:1: error: the frame size of 1080 bytes is larger than 1024

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

Hi Cong, On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: A commit message would be nice. A brief rundown of how this is called from userspace would be nice (I'm talking a single sentence here, e.g. "this is allocated when submitting a nfc packet") and what issue

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby wrote: > Hi Cong, > > On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: > > A commit message would be nice. A brief rundown of how this is called > from userspace would be nice (I'm talking a single

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

Hi Cong, On Wed, Jan 27, 2016 at 10:12 AM, Cong Wang wrote: > On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby > wrote: >> Hi Cong, >> >> On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: >> >> A commit message would

Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

On Tue, Jan 19, 2016 at 09:04:32AM +0100, Henning Rogge wrote: > err = -ENXIO; > -enddel: > +enddelpath: Concur about it being better to leave this label alone, also the diff looks weird because it continues: > + mesh_paths_generation++; > + spin_unlock(>hashwlock[hash_idx]); > +

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

On Tue, 2016-01-26 at 15:12 -0800, Cong Wang wrote: > On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby > wrote: > > Hi Cong, > > > > On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang wrote: > > > > A commit message would be nice. A brief rundown of how

[PATCH 01/13] staging: wilc1000: wilc_frmw_to_linux(): fixes null check

From: Leo Kim Null checking wilc_netdev and skb->dev are already done in the begining of the function and they are just print printing error log, so delete them. Null checking wilc is needed before is used so add null ckeck before it is used. Signed-off-by: Leo Kim

[PATCH 02/13] staging: wilc1000: fixes no space is necessary after a cast

From: Leo Kim This patch fixes the check reported by checkpatch.pl for 'no space is necessary after a cast'. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1

[PATCH 05/13] staging: wilc1000: rename Firmware_ver variable

From: Leo Kim This patch renames Firmware_ver variable to firmware_ver to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 15 --- 1 file changed, 8 insertions(+),

[PATCH 03/13] staging: wilc1000: fixes add spaces required around

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for spaces required around that '=' or '||' or '('. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- 1 file changed,

[PATCH 04/13] staging: wilc1000: rename hWILCWFIDrv of wilc_priv structure

From: Leo Kim This patch renames hWILCWFIDrv pointer variable of wilc_priv structure to hif_drv to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 8

[PATCH 06/13] staging: wilc1000: fixes missing a blank line after declarations

From: Leo Kim This patch fixes the warnings reported by checkpatch.pl for Missing a blank line after declarations. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 2 ++ 1 file changed, 2

[PATCH 07/13] staging: wilc1000: rename pBssid of tx_complete_data structure

From: Leo Kim This patch renames pBssid variable of tx_complete_data structure to bssid to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 2 +-

[PATCH 08/13] staging: wilc1000: remove warnings line over 80 characters

From: Leo Kim This patch removes the warnings reported by checkpatch.pl for line over 80 characters. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 6 -- 1 file changed, 4 insertions(+),

[PATCH 11/13] staging: wilc1000: removes void function return

From: Leo Kim This patch removes the warning reported by checkpatch.pl for void function return statements are not generally useful. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 2 -- 1

[PATCH 09/13] staging: wilc1000: removes unnecessary debug logs

From: Leo Kim This patch removes unnecessary debug logs. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 154 ++ 1 file changed, 24 insertions(+), 130

[PATCH 12/13] staging: wilc1000: renames u8IfIdx of wilc_vif structure

From: Leo Kim This patch renames u8IfIdx variable of wilc_vif structure to idx to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 2 +-

[PATCH 13/13] staging: wilc1000: fixes variable dereferenced before check

From: Leo Kim This patch fixes the warning reported by smatch. - wilc_wlan_get_firmware() warn: variable dereferenced before check 'vif' - wilc_set_multicast_list() warn: variable dereferenced before check 'dev' Just delete them and no need add null check since they are

Re: [PATCH] cfg80211: Fix some linguistics in Kconfig

Applied, thanks! johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] cfg80211: basic support for PBSS network type

On Wed, 2016-01-13 at 11:04 +0200, Lior David wrote: >  > + * @NL80211_ATTR_PBSS: flag attribute. If set it means operate > + * in a PBSS. Specified in %NL80211_CMD_CONNECT to request > + * connecting to a PCP, and in %NL80211_CMD_START_AP to start > + * a PCP instead of AP. Relevant for DMG

Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath

On Tue, 2016-01-19 at 09:04 +0100, Henning Rogge wrote: >  > +static void mpp_flush_by_proxy(struct ieee80211_sub_if_data *sdata, > +    const u8 *proxy) > +{ > + struct mesh_table *tbl; > + struct mesh_path *mpp; > + struct mpath_node *node; > + int i; > +

Re: [PATCH 2/2] mac80211: expose txq queue depth and size to drivers

On 2016-01-26 12:56, Michal Kazior wrote: > On 26 January 2016 at 11:45, Felix Fietkau wrote: >> On 2016-01-21 14:23, Michal Kazior wrote: >>> This will allow drivers to make more educated >>> decisions whether to defer transmission or not. >>> >>> Relying on wake_tx_queue()

Re: [PATCH 2/2] mac80211: expose txq queue depth and size to drivers

> I don't see a point in maintaining coherency between the two counters > with regard to each other alone. Do you have a use-case that would > actually make use of that property? > > I'd like to avoid any unnecessary spinlocks. > Make sure you document the lack of consistency between the two

Re: [PATCH] net:mac80211:mesh_plink: remove redundant sta_info check

On Thu, 2016-01-21 at 11:06 +0530, Sunil Shahu wrote: > Remove unnecessory "if" statement and club it with previos "if" > block. > Applied. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] cfg80211: basic support for PBSS network type

On 1/26/2016 1:22 PM, Johannes Berg wrote: > On Wed, 2016-01-13 at 11:04 +0200, Lior David wrote: >> >> + * @NL80211_ATTR_PBSS: flag attribute. If set it means operate >> + * in a PBSS. Specified in %NL80211_CMD_CONNECT to request >> + * connecting to a PCP, and in %NL80211_CMD_START_AP to

Re: [RFC V3 0/2] nl80211: allow configuration of BSS selection

On 26-1-2016 11:01, Arend van Spriel wrote: > This patch series adds support for configuration of BSS selection done by > the driver and/or firmware. It allows user-space to pass selection criteria > with the NL80211_CMD_CONNECT using NL80211_ATTR_BSS_SELECT. When user-space > does provide this

Re: [PATCH 2/2] mac80211: expose txq queue depth and size to drivers

On 26 January 2016 at 13:04, Felix Fietkau wrote: > On 2016-01-26 12:56, Michal Kazior wrote: >> On 26 January 2016 at 11:45, Felix Fietkau wrote: >>> On 2016-01-21 14:23, Michal Kazior wrote: This will allow drivers to make more educated decisions

[RFC V4 1/2] nl80211: add feature for BSS selection support

Introducing a new feature that the driver can use to indicate the driver/firmware supports configuration of BSS selection criteria upon CONNECT command. This can be useful when multiple BSS-es are found belonging to the same ESS, ie. Infra-BSS with same SSID. The criteria can then be used to

Re: [PATCH] mac80211: fix unnecessary frame drops in mesh fwding

On Mon, 2016-01-25 at 14:43 +0100, Michal Kazior wrote: > The ieee80211_queue_stopped() expects hw queue > number but it was given raw WMM AC number instead. > > This could cause frame drops and problems with > traffic in some cases - most notably if driver > doesn't map AC numbers to queue

[RFC V4 2/2] brcmfmac: add support for nl80211 BSS_SELECT feature

Announce support for nl80211 feature BSS_SELECT and process BSS selection behaviour provided in .connect() callback. Reviewed-by: Hante Meuleman Reviewed-by: Franky (Zhenhui) Lin Reviewed-by: Pieter-Paul Giesberts Reviewed-by:

[RFC V4 0/2] nl80211: allow configuration of BSS selection

This patch series adds support for configuration of BSS selection done by the driver and/or firmware. It allows user-space to pass selection behaviour with the NL80211_CMD_CONNECT using NL80211_ATTR_BSS_SELECT. When user-space does provide this attribute and no explicit BSSID is provided it will

Re: [PATCH 1/3] mac80211: add RX_FLAG_MACTIME_PLCP_START

All three applied. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/8] General RFKill improvements

Hi, On Tue, 2016-01-19 at 10:42 -0500, João Paulo Rechi Vita wrote: > This series contains a few general improvements to the RFKill code, > found while > I was writing the rfkill-all / airplane mode LED trigger. All were > points where > I had to read twice or do some other kind of extra effort

Re: [PATCH] cfg80211: basic support for PBSS network type

> Yes, DMG devices can function as a full AP in addition to PCP. Ok. I'll try to remember :) > Certified 11ad devices must support PBSS, but in theory you can have > 11ad drivers that do not support it. 11ac devices cannot support > it and currently will just ignore this flag, so I think I will

  1   2   >