Re: [PATCH 2/3] iwlwifi: mvm: move TX PN assignment for TKIP to the driver

2016-02-15 Thread Eliad Peller
On Sun, Feb 14, 2016 at 9:37 PM, Grumbach, Emmanuel wrote: > > > On 02/14/2016 09:33 PM, Johannes Berg wrote: >> On Sun, 2016-02-14 at 19:34 +0200, Emmanuel Grumbach wrote: >>> >>> Since the 3rd patch needs to be dropped anyway, let's route this one >>> through my

Re: [PATCH] brcmfmac: of: Include "of.h" header file

2016-02-15 Thread Arend Van Spriel
On Sun, Feb 14, 2016 at 10:57 PM, Fabio Estevam wrote: > From: Fabio Estevam > > Include "of.h" header file to fix the following sparse warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol > 'brcmf_of_probe' was not

Re: [PATCH 2/3] iwlwifi: mvm: move TX PN assignment for TKIP to the driver

2016-02-15 Thread Grumbach, Emmanuel
On 02/15/2016 11:06 AM, Eliad Peller wrote: > On Sun, Feb 14, 2016 at 9:37 PM, Grumbach, Emmanuel > wrote: >> >> On 02/14/2016 09:33 PM, Johannes Berg wrote: >>> On Sun, 2016-02-14 at 19:34 +0200, Emmanuel Grumbach wrote: Since the 3rd patch needs to be dropped

Re: [PATCH 2/3] iwlwifi: mvm: move TX PN assignment for TKIP to the driver

2016-02-15 Thread Eliad Peller
On Mon, Feb 15, 2016 at 11:16 AM, Grumbach, Emmanuel wrote: > > > On 02/15/2016 11:06 AM, Eliad Peller wrote: >> On Sun, Feb 14, 2016 at 9:37 PM, Grumbach, Emmanuel >> wrote: >>> >>> On 02/14/2016 09:33 PM, Johannes Berg wrote: On

Re: [PATCH 2/3] iwlwifi: mvm: move TX PN assignment for TKIP to the driver

2016-02-15 Thread Grumbach, Emmanuel
On 02/15/2016 11:21 AM, Eliad Peller wrote: > On Mon, Feb 15, 2016 at 11:16 AM, Grumbach, Emmanuel > wrote: >> >> On 02/15/2016 11:06 AM, Eliad Peller wrote: >>> On Sun, Feb 14, 2016 at 9:37 PM, Grumbach, Emmanuel >>> wrote: On

Re: [PATCH] brcmfmac: of: Include "of.h" header file

2016-02-15 Thread Arend Van Spriel
I am actually preparing a patch series and found that this change is incorporated in that series. As that involves other changes it is probably better to drop this patch. I thought I could change the patchwork state for it, but no luck. Regards, Arend On Mon, Feb 15, 2016 at 10:15 AM, Arend Van

Re: [PATCH 2/3] iwlwifi: mvm: move TX PN assignment for TKIP to the driver

2016-02-15 Thread Johannes Berg
On Mon, 2016-02-15 at 09:24 +, Grumbach, Emmanuel wrote: >  > It doesn't feel right to remove this function in mac80211-next.git > and > touch 3 drivers along the way, but I don't mind. Johannes, what do > you say? I don't see any problem with that? I've touched far more drivers (like "every

wireless dependency

2016-02-15 Thread Arend Van Spriel
Hi Kalle, I am preparing a patch series for wireless-drivers-next, but there is a dependency with patch that was submitted to wireless-drivers [1]. How should I handle this. Can I submit it for wireless-drivers-next as well? Regards, Arend [1] https://patchwork.kernel.org/patch/8061031/ -- To

[PATCH 3/3 v2] mac80211: remove ieee80211_get_key_tx_seq/ieee80211_set_key_tx_seq

2016-02-15 Thread Emmanuel Grumbach
From: Eliad Peller Since the PNs of all the tx keys are now tracked in the public part of the key struct (with atomic counter), we no longer need these functions. dvm and vt665{5,6} are currently the only users of these functions, so update them accordingly. Signed-off-by:

RE: drivers/staging/wilc1000/wilc_spi.c won't compile ?

2016-02-15 Thread Kim, Leo
Hi David, You're had old wilc1000 source. Remove the wilc1000_ops structure. (Branch) staging-testing (SHA) ce7b516f3f9e11fe4ee06fad0d7e853bb6e8f160 Please receive the latest source.  Thanks, BR  Leo -Original Message- From: David Binderman [mailto:dcb...@hotmail.com] Sent: Monday,

pull request: iwlwifi-2016-02-16

2016-02-15 Thread Grumbach, Emmanuel
Hi Kalle, This is a pull request for 4.5. Apart from my RF-Kill fix, the patches are really small. My RF-Kill patch needed to move code around to avoid adding a forward declaration and on the way there were a few very trivial code style fixes, that were needed to make checkpatch happy. Let me

[PATCH 1/5] iwlwifi: fix name of ucode loaded for 8265 series

2016-02-15 Thread Emmanuel Grumbach
From: Oren Givon Fix the name of the ucode being loaded for 8265 series to be: iwlwifi-8265-XX.ucode Signed-off-by: Oren Givon Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/iwl-8000.c | 42

[PATCH 2/5] iwlwifi: dvm: remove a wrong dependency on m

2016-02-15 Thread Emmanuel Grumbach
This was wronly added when the dependency on IWLWIFI was removed. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=112201 Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 5/5] iwlwifi: pcie: fix erroneous return value

2016-02-15 Thread Emmanuel Grumbach
From: Anton Protopopov The iwl_trans_pcie_start_fw() function may return the positive value EIO instead of -EIO in case of error. Signed-off-by: Anton Protopopov Signed-off-by: Emmanuel Grumbach ---

[PATCH 4/5] iwlwifi: pcie: fix RF-Kill vs. firmware load race

2016-02-15 Thread Emmanuel Grumbach
When we load the firmware, we hold trans_pcie->mutex to avoid nested flows. We also rely on the ISR to wake up the thread when the DMA has finished copying a chunk. During this flow, we enable the RF-Kill interrupt. The problem is that the RF-Kill interrupt handler can take the mutex and bring

[PATCH 3/5] iwlwifi: mvm: don't allow sched scans without matches to be started

2016-02-15 Thread Emmanuel Grumbach
From: Luca Coelho The firmware can perform a scheduled scan with not matchsets passed, but it can't send notification that results were found. Since the userspace then cannot know when we got new results and the firmware wouldn't trigger a wake in case we are sleeping,

[PATCH 1/3] nl80211: add feature for BSS selection support

2016-02-15 Thread Arend van Spriel
Introducing a new feature that the driver can use to indicate the driver/firmware supports configuration of BSS selection criteria upon CONNECT command. This can be useful when multiple BSS-es are found belonging to the same ESS, ie. Infra-BSS with same SSID. The criteria can then be used to

[PATCH 3/3] cfg80211: stop critical protocol session upon disconnect event

2016-02-15 Thread Arend van Spriel
When user-space has started a critical protocol session and a disconnect event occurs, the rdev::crit_prot_nlportid remains set. This caused a subsequent NL80211_CMD_CRIT_PROTO_START to fail (-EBUSY). Fix this by clearing the rdev attribute and call .crit_proto_stop() callback upon disconnect

[PATCH 2/3] brcmfmac: add support for nl80211 BSS_SELECT feature

2016-02-15 Thread Arend van Spriel
Announce support for nl80211 feature BSS_SELECT and process BSS selection behaviour provided in .connect() callback. Reviewed-by: Hante Meuleman Reviewed-by: Franky (Zhenhui) Lin Reviewed-by: Pieter-Paul Giesberts Reviewed-by:

[PATCH V5 0/3] nl80211: allow configuration of BSS selection

2016-02-15 Thread Arend van Spriel
This patch series adds support for configuration of BSS selection done by the driver and/or firmware. It allows user-space to pass selection behaviour with the NL80211_CMD_CONNECT using NL80211_ATTR_BSS_SELECT. When user-space does provide this attribute and no explicit BSSID is provided it will

[PATCH] staging: wilc1000: remove wilc1000_spi_ops as it is not used

2016-02-15 Thread Colin King
From: Colin Ian King building with gcc 6 I hit a build failure: CC drivers/staging/wilc1000/wilc_spi.o drivers/staging/wilc1000/wilc_spi.c:123:34: error: storage size of ‘wilc1000_spi_ops’ isn’t known static const struct wilc1000_ops wilc1000_spi_ops;

Re: [PATCH v3 1/3] staging: rtl8723au: use list_for_each_entry*()

2016-02-15 Thread Jes Sorensen
Geliang Tang writes: > Use list_for_each_entry*() instead of list_for_each*() to simplify > the code. > > Signed-off-by: Geliang Tang > --- > Changes in v3: > - split it into three patches. > Changes in v2: > - drop the coding style fixing in v1. > ---

Re: [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes

2016-02-15 Thread Jes Sorensen
Geliang Tang writes: > There are some useless codes in rtw_free_recvframe23a_queue() and > recvframe_defrag(), so remove them. > > Signed-off-by: Geliang Tang > --- > Changes in v3: > - split it into three patches. > Changes in v2: > - drop the coding

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

2016-02-15 Thread Jes Sorensen
Julian Calaby writes: > Hi Geliang, > > On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang wrote: >> This patch cleans whitespaces and blank lines surrounding >> list_for_each_entry*(). > > It does a lot more than this, including: > - Removing some

[PATCH] rt2x00: unterminated strlen of user data

2016-02-15 Thread Alan
The buffer needs to be zero terminated in case the user data is not. Otherwise we run off the end of the buffer. Signed-off-by: Alan Cox --- drivers/net/wireless/ralink/rt2x00/rt2x00debug.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH] rtlwifi: Change long delays to sleeps

2016-02-15 Thread Larry Finger
Routine rtl_addr_delay() uses delay statements in code that can sleep. To improve system responsiveness, the various delay statements are changed. In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are rewritten to use the code in rtl_addr_delay() for most of their input values.

mwifiex driver unstable on MS Surface Pro 4

2016-02-15 Thread Mikael Djurfeldt
Dear list, I'm experiencing problems with the mwifiex_pcie driver on MS Surface Pro 4 (with the 88W8897 chip). The symtom is that the driver only works for a few minutes during which various error messages is shown in syslog after which the device becomes unavailable. I've tried a bunch of

Re: [PATCH 2/3] mwifiex: Removed extra spaces before commas

2016-02-15 Thread Julian Calaby
Hi All, On Thu, Feb 11, 2016 at 5:47 PM, Ujjal Roy wrote: > This patch fixes spaces before commas issue in coding style. > > Signed-off-by: Ujjal Roy Looks right to me. Reviewed-by: Julian Calaby Thanks, > --- >

Re: [PATCH 1/3] mwifiex: Fixed incorrect indentation issue

2016-02-15 Thread Julian Calaby
Hi All, On Thu, Feb 11, 2016 at 5:47 PM, Ujjal Roy wrote: > This patch fixes the incorrect indentation of the case label. > > Signed-off-by: Ujjal Roy Looks right to me. Reviewed-by: Julian Calaby Thanks, > --- >

Re: [PATCH 3/3] mwifiex: Added missing spaces around brackets

2016-02-15 Thread Julian Calaby
Hi All, On Thu, Feb 11, 2016 at 5:47 PM, Ujjal Roy wrote: > This patch fixes the missing spaces issue in coding style. > > Signed-off-by: Ujjal Roy Looks right to me. Reviewed-by: Julian Calaby Thanks, > --- >

Re: [PATCH] staging: wilc1000: remove wilc1000_spi_ops as it is not used

2016-02-15 Thread Greg Kroah-Hartman
On Mon, Feb 15, 2016 at 03:18:27PM +, Colin King wrote: > From: Colin Ian King > > building with gcc 6 I hit a build failure: > > CC drivers/staging/wilc1000/wilc_spi.o > drivers/staging/wilc1000/wilc_spi.c:123:34: error: storage size of >

Google Summer of Code 2016 - Project ideas page for the Linux Foundation online

2016-02-15 Thread Till Kamppeter
Hi, I have set up a page for project ideas for the Linux Foundation's participation in the Google Summer of Code 2016: https://www.linuxfoundation.org/collaborate/workgroups/gsoc/google-summer-code-2016 Please add your ideas to the sub-page of your work group. If you have problems mail me with

Google Summer of Code 2016 - Backup organization administrator needed

2016-02-15 Thread Till Kamppeter
Hi, I am applying for the Linux Foundation as mentoring organization for the Google Summer of Code 2016. I need a backup administrator (a second org admin) to complete the application and he needs to confirm before the deadline on Friday. Note that usually the role as backup admin will not

Re: [PATCH 3/3] mwifiex: Added missing spaces around brackets

2016-02-15 Thread Souptick Joarder
Looks fine. On Thu, Feb 11, 2016 at 12:17 PM, Ujjal Roy wrote: > This patch fixes the missing spaces issue in coding style. > > Signed-off-by: Ujjal Roy > --- > drivers/net/wireless/marvell/mwifiex/usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH] rtlwifi: Change long delays to sleeps

2016-02-15 Thread Souptick Joarder
On Tue, Feb 16, 2016 at 3:42 AM, Larry Finger wrote: > Routine rtl_addr_delay() uses delay statements in code that can > sleep. To improve system responsiveness, the various delay statements > are changed. > > In addition, routines rtl_rfreg_delay() and rtl_bb_delay()

Re: [PATCH] rt2x00: unterminated strlen of user data

2016-02-15 Thread Souptick Joarder
On Tue, Feb 16, 2016 at 12:34 AM, Alan wrote: > The buffer needs to be zero terminated in case the user data is not. > Otherwise we run off the end of the buffer. > > Signed-off-by: Alan Cox > --- >

whitespace error in some of commits

2016-02-15 Thread Tony Cho
Hi Janani, I can find the whitespace errors in your commits which is already accepted in staging-testing branch. The commit number is c611d48e65e25af2dc0176e9ac135116095ed03d and c611d48e65e25af2dc0176e9ac135116095ed03d. I don't know why I couldn't find your patch emails from the community.

Re: whitespace error in some of commits

2016-02-15 Thread Tony Cho
Hi Janani, Please refer to the commit numbers again in the wilc1000 driver: c611d48e65e25af2dc0176e9ac135116095ed03d 24c6c29d85af3748b2d79b46f72188b335566340 Thanks, Tony. On 2016년 02월 16일 15:47, Tony Cho wrote: Hi Janani, I can find the whitespace errors in your commits which is already