Question on rhashtable in worst-case scenario.

2016-03-28 Thread Ben Greear
Hello! I have a use case for mac80211 where I create multiple stations to the same remote peer MAC address. I'm seeing cases where the rhashtable logic is returning -16 (EBUSY) on insert (see sta_info_hash_add). This is with the 4.4.6+ (plus local patches) kernel, and it has the patch

[PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-28 Thread Wei-Ning Huang
"single skb allocation failure" happens when system is under heavy memory pressure. Add __GFP_REPEAT to skb allocation call so kernel attempts to reclaim pages and retry the allocation. Signed-off-by: Wei-Ning Huang --- drivers/net/wireless/marvell/mwifiex/sdio.c | 12

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-28 Thread James Cameron
On Tue, Mar 29, 2016 at 12:47:20PM +0800, Wei-Ning Huang wrote: > "single skb allocation failure" happens when system is under heavy > memory pressure. Add __GFP_REPEAT to skb allocation call so kernel > attempts to reclaim pages and retry the allocation. Oh, that's interesting, we're back to

Re: [PATCH 3/4] wcn36xx: Transition driver to SMD client

2016-03-28 Thread Bjorn Andersson
On Mon, Jan 11, 2016 at 1:02 AM, Eugene Krasnikov wrote: > Better late than never! Looks good to me. > Unfortunately I ran into an issue with ordering of operations between the WiFi driver and the wcnss_ctrl driver. So an updated series is on the way, but this depends on

Re: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats

2016-03-28 Thread Grumbach, Emmanuel
On Mon, 2016-03-28 at 12:33 +0100, Colin King wrote: > From: Colin Ian King > > isr_stats is written twice with the same value, remove one of the > redundant assignments to isr_stats. > > Signed-off-by: Colin Ian King > --- Applied -

[PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats

2016-03-28 Thread Colin King
From: Colin Ian King isr_stats is written twice with the same value, remove one of the redundant assignments to isr_stats. Signed-off-by: Colin Ian King --- drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] mwifiex: ie_list is an array, so no need to check if NULL

2016-03-28 Thread Colin King
From: Colin Ian King ap_ie->ie_list is an array of struct mwifiex_ie and can never be null, so the null check on this array is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 2

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

2016-03-28 Thread Greg KH
On Sat, Mar 26, 2016 at 03:07:18PM -0300, Till Kamppeter wrote: > >If there's anything else I need to do here, becides try to find a > >co-mentor, please let me know. > > > > I am grateful if you could enter as co-mentor, especially if there is any > kernel project now which has only one mentor.

Re: hashing error in hacked 4.4.6+ kernel.

2016-03-28 Thread Ben Greear
So, it appears at least part of the problem is that the station is not added to the hash to begin with, and existing code does not check for that failure or deal with it. I added a check and I see this below. That -16 value means EBUSY from what I can tell, because two rehashes are scheduled