Re: [PATCH 03/21] ath10k: Support setting debug mask from driver code.

On 10 May 2016 at 01:10, wrote: > From: Ben Greear > > Might want to turn off verbose debug as soon as you > see a firmware crash, for instance. Helps keep dmesg > output from over-running the stuff you care about. > > Signed-off-by: Ben Greear

Re: [PATCH 03/21] ath10k: Support setting debug mask from driver code.

On 05/11/2016 03:40 AM, Michal Kazior wrote: On 10 May 2016 at 01:10, wrote: From: Ben Greear Might want to turn off verbose debug as soon as you see a firmware crash, for instance. Helps keep dmesg output from over-running the stuff you

[PATCH v2 07/21] ath10k: save firmware RAM and ROM BSS sections on crash

From: Ben Greear This can be used to get a useful back trace out of a firmware crash that involves an interrupt handler. For instance, a null-pointer-exception would be this kind of trace. A user-space tool can read the debugfs file and decode things as wished. This

[PATCH v2 19/21] ath10k: Enable adhoc mode for CT firmware.

From: Ben Greear CT firmware can support IBSS mode, so allow users to configure this. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v2 05/21] ath10k: save firmware debug log messages.

From: Ben Greear They may be dumped through the firmware dump debugfs file. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/core.h | 18 ++ drivers/net/wireless/ath/ath10k/debug.c | 97 +++-

[PATCH v2 21/21] ath10k: Read dbglog buffers over register ping-pong.

From: Ben Greear This gives much better debugging capability when debugging crashes in the firmware that cause CE transport loss. (Such as AXI errors). Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/pci.c | 46

[PATCH v2 09/21] ath10k: print fw debug messages in hex.

From: Ben Greear This allows user-space tools to decode debug-log messages by parsing dmesg or /var/log/messages. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/debug.c | 72 +

[PATCH v2 11/21] ath10k: add fw-powerup-fail to ethtool stats.

From: Ben Greear This gives user-space a normal-ish way to detect that firmware has failed to start and that a reboot is probably required. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/core.h | 1 +

[PATCH v2 15/21] ath10k: support CT firmware flag.

From: Ben Greear Add placeholder so CT firmware can more easily co-exist with upstream kernel. CT firmware should be backwards compatible with existing kernels, but it also has many new features. Subsequent patches, if acceptable for upstream, can enable and further

[PATCH v2 13/21] ath10k: Document cycle count related counters.

From: Ben Greear They are not necessarily named in an intuitive manner, so at least add some comments to help the next person. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/core.h | 8

[PATCH v2 14/21] ath10k: Add tx/rx bytes, cycle counters to ethtool stats.

From: Ben Greear The firmware does not offer tx/rx bytes counters, so just keep track of it in the driver. For the cycle counters: Note these counters are since the chip reset, though the counters wrap often. When cycle-counters counter overflows on certain hardware,

[PATCH v2 08/21] ath10k: make firmware text debug messages more verbose.

From: Ben Greear There are not many of these messages producted by the firmware, but they are generally fairly useful, so print them at info level. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1

[PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

From: Ben Greear Helps keep messages off of (serial) console when that is desired. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/debug.c | 5 - drivers/net/wireless/ath/ath10k/debug.h | 6 ++ 2 files changed, 10

[PATCH v2 20/21] ath10k: read firmware crash over ioread32 if CE fails.

From: Ben Greear This might work around problem where sometimes host cannot access firmware crash over normal CE transport. Requires CT firmware with matching logic in it's assert handler (-13 and higher releases). Signed-off-by: Ben Greear

[PATCH v2 06/21] ath10k: save firmware stacks upon firmware crash

From: Ben Greear Should help debug firmware crashes, and give users a way to provide some useful debug reports to firmware developers. Signed-off-by: Ben Greear Signed-off-by: Kalle Valo ---

[PATCH v2 02/21] ath10k: fix typo in logging message

From: Ben Greear Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index

[PATCH v2 04/21] ath10k: rate-limit packet tx errors

From: Ben Greear When firmware crashes, stack can continue to send packets for a bit, and existing code was spamming logs. So, rate-limit the error message for tx failures. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c |

[PATCH v2 12/21] ath10k: Support up to 64 vdevs.

From: Ben Greear The (1 << x) - 1 trick won't work when you are trying to fill up all 64 bits, so add special case for that. And, move the limits to the per-nic structure instead of per-driver to allow better dynamic use of the limits. Signed-off-by: Ben Greear

Re: [PATCH 12/41] iwlwifi: trans: don't call the trans-specific ref/unref directly

Luca Coelho writes: > From: Luca Coelho > > It's cleaner to always call the iwl_trans_ref/unref() functions > instead of sometimes calling the trans-specific ops directly. This > also prepares for moving some of the code from the trans-specific ops >

Re: [PATCH 12/41] iwlwifi: trans: don't call the trans-specific ref/unref directly

On Wed, 2016-05-11 at 19:34 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > > > From: Luca Coelho > > > > It's cleaner to always call the iwl_trans_ref/unref() functions > > instead of sometimes calling the trans-specific ops directly.  This > >

[PATCH v2 17/21] ath10k: Enable detecting failure to install key in firmware (CT).

From: Ben Greear CT firmware has been modified so that it will always return a response message when user requests to add a key, even if the key could not actually be added. Upstream firmware may assert or just not respond in a failure case. This change should be

[PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

From: Ben Greear Using debugfs. More convenient than module options in some cases. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/debug.c | 62 + 1 file changed, 62 insertions(+) diff --git

[PATCH v2 01/21] ath10k: Fix crash related to printing features.

From: Ben Greear This looks like a regression from c4cdf753 (move fw_features to struct ath10k_fw_file) Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 18/21] ath10k: Note limitation on beaconing vdevs.

From: Ben Greear This only pertains to CT firmware, as standard firmware can't do anywhere near this many vdevs anyway. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 16 1 file changed, 16 insertions(+)

[PATCH v2 16/21] ath10k: Support 32+ stations.

From: Ben Greear Support up to 32 stations when using CT firmware. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/core.c | 14 +++ drivers/net/wireless/ath/ath10k/hw.h | 6 + drivers/net/wireless/ath/ath10k/mac.c

Re: [PATCH] brcmfmac: Fix 'did not remove int handler' warning

Christian Daudt writes: > brcmf_sdiod_intr_unregister call that removes both func1 and > func2 interrupt handlers only called when brcmf_ops_sdio_remove > is called for func 1 (which is the 2nd call) but sdio is expecting > it to be removed at the end of each sdio_remove call.

Re: pull-request: iwlwifi-next 2016-05-10

Luca Coelho writes: > Here's another pull request that we would like to get into 4.7, if > possible.  I know it's a bit late, I was trying to send it out earlier, > but it took me much longer time than I expected.  I hope it can still > make it. > > We're mostly continuing work

Re: [PATCH] wlcore/wl12xx: Fix fw logger over sdio

Guy Mishol writes: > The commit fb724ed5c617 ("wlcore: Fix regression in > wlcore_set_partition()") fixed wl12xx functionality. > However, it reverted the support in fw logger > over sdio in wl18xx. > > This patch reverts the changes made and also fixes > the original functionality

Re: wlcore/wl12xx: Fix fw logger over sdio

Guy Mishol wrote: > The commit fb724ed5c617 ("wlcore: Fix regression in > wlcore_set_partition()") fixed wl12xx functionality. > However, it reverted the support in fw logger > over sdio in wl18xx. > > This patch reverts the changes made and also fixes > the original functionality

Re: [PATCH] brcmfmac: add fallback for devices that do not report per-chain values

On 11-05-16 21:40, Jaap Jan Meijer wrote: > If brcmf_cfg80211_get_station fails to determine the RSSI from the > per-chain values get all values individually as a fallback. That commit message looks good. > Signed-off-by: Jaap Jan Meijer > --- >

[PATCH v1] ath10k: Fix 10.4 extended peer stats update

From: Mohammed Shafi Shajakhan 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration for per

Re: [PATCH 13/21] ath10k: Document cycle count related counters.

On 10 May 2016 at 01:11, wrote: > From: Ben Greear > > They are not necessarily named in an intuitive manner, > so at least add some comments to help the next person. > > Signed-off-by: Ben Greear > --- >

Re: Limit rate of BCM34348 on Raspberry PI-3 via brcmfmac

On 11-5-2016 4:39, Barry Reinhold wrote: > Arend, > > I have done some follow up testing by disabling Bluetooth. The AP works fine > in this case. > However, if I enable wlan0 then the AP fails. I am missing quite some information here or it is just me ;-p What do you mean by "enable wlan0".

Re: [PATCH 4/4] ath10k: Enable support for QCA9984

On Wednesday 11 May 2016 12:23 PM, Archisman Maitra wrote: > Hi, > > Thank you for providing me the binaries. > > I have started working on the mac80211 driver and have some questions:- > > a) I am working with OpenWRT framework, which uses mac80211 driver dated > 1-10-2016. I have noticed that

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote: > Recent new hardware has the ability to switch between tablet mode and > clamshell mode. To optimize WiFi performance, we want to be able to > use different power table between modes. This patch adds a new > netlink message type and

Re: [v2] rtlwifi: Fix logic error in enter/exit power-save mode

wang yanqing wrote: > In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and > rtl_lps_enter() to use work queue"), the tests for enter/exit > power-save mode were inverted. With this change applied, the > wifi connection becomes much more stable. > > Fixes:

Re: mwifiex: Drop unnecessary include pcieport_if.h

Lukas Wunner wrote: > This header file is only needed for drivers binding to a PCI bridge > device allocated by drivers/pci/pcie/portdrv_core.c. The mwifiex driver > doesn't do that nor use any symbols defined in pcieport_if.h. > > Cc: Amitkumar Karwar >

Re: [v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb inrtl_pci_reset_trx_ring

wang yanqing wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. > > This patch fix below kernel warning: > [

Re: mwifiex: fixup error messages

Wei-Ning Huang wrote: > Use dev_err instead of pr_err and add newline character at the end. > > Signed-off-by: Wei-Ning Huang Thanks, 1 patch applied to wireless-drivers-next.git: 50d4d8feb913 mwifiex: fixup error messages -- Sent by pwcli

Re: airo: prevent potential underflow in airo_set_freq()

Dan Carpenter wrote: > I'm not sure if this can underflow but Smatch complains. It seems > harmless to add a check for negatives. > > Signed-off-by: Dan Carpenter Thanks, 1 patch applied to wireless-drivers-next.git: 03ba4a1b718e airo:

Re: [PATCH v2 7/7] wil6210: add support for device led configuration

me...@codeaurora.org writes: > On 2016-04-25 21:56, Kalle Valo wrote: >> Maya Erez writes: >> >>> Add the ability to configure the device led to be used for notifying >>> the AP activity (60G device supports leds 0-2). >>> The host can also configure the blinking

Re: [v2,7/7] wil6210: add support for device led configuration

Maya Erez wrote: > Add the ability to configure the device led to be used for notifying > the AP activity (60G device supports leds 0-2). > The host can also configure the blinking frequency of the led in > three states. > > Signed-off-by: Maya Erez

[PATCH] brcmfmac: add fallback for devices that do not report per-chain values

If brcmf_cfg80211_get_station fails to determine the RSSI from the per-chain values get all values individually as a fallback. Signed-off-by: Jaap Jan Meijer --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 42 ++ 1 file changed, 42

Re: [1/2] ath10k: suppress warnings when getting wmi peer_rate_code_listevent

Vasanthakumar Thiagarajan wrote: > In 10.4, fw sends WMI PEER_RATECODE_LIST_EVENTID after successful > peer_assoc cmd. As of now this event is not of much use and not > implemented. Change the debug level and messsage as appropriate > to suppress "Unknown eventid:

Re: rtlwifi: rtl818x: constify rtl_intf_ops structures

Julia Lawall wrote: > The rtl_intf_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to wireless-drivers-next.git: 1bfcfdcca142 rtlwifi:

Re: rtlwifi: rtl818x: silence uninitialized variable warning

Dan Carpenter wrote: > What about if "rtlphy->pwrgroup_cnt" is 2? In that case we would use an > uninitialized "chnlgroup" variable and probably crash. Maybe that can't > happen for some reason which is not obvious but in that case this patch > is harmless. > >

Re: brcmfmac: Add 4356 sdio support

Christian Daudt wrote: > This adds support for the 4356-sdio wireless chip. > > Signed-off-by: Christian Daudt Thanks, 1 patch applied to wireless-drivers-next.git: 496aec577b51 brcmfmac: Add 4356 sdio support -- Sent by pwcli

Re: [v2] rtlwifi: Remove double check for cnt_after_linked

wang yanqing wrote: > rtl_lps_enter does two successive check for cnt_after_linked > to make sure some time has elapsed after linked. The second > check isn't necessary, because if cnt_after_linked is bigger > than 5, it is bigger than 2 of course! > > This patch remove the

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

On Wed, 2016-05-11 at 13:03 +0800, Wei-Ning Huang wrote: > On Fri, May 6, 2016 at 4:19 PM, Wei-Ning Huang > wrote: > > > > On Fri, May 6, 2016 at 12:07 AM, Dan Williams > > wrote: > > > > > > > > > On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote: >

Re: atmel: potential underflow in atmel_set_freq()

Dan Carpenter wrote: > Smatch complains that we cap the upper bound of "fwrq->m" but not the > lower bound. I don't know if it can actually happen but it's simple > enough to check for negatives. > > Signed-off-by: Dan Carpenter Thanks, 1

[PATCH v2 1/2] brcmfmac: Fix kernel oops in failed chip_attach

When chip attach fails, brcmf_sdiod_intr_unregister is being called but that is too early as sdiodev->settings has not been set yet nor has brcmf_sdiod_intr_register been called. Change to use oob_irq_requested + newly created sd_irq_requested to decide on what to unregister at intr_unregister

[PATCH v2 2/2] brcmfmac: Fix 'did not remove int handler' warning

brcmf_sdiod_intr_unregister call that removes both func1 and func2 interrupt handlers only called when brcmf_ops_sdio_remove is called for func 1 (which is the 2nd call) but sdio is expecting it to be removed at the end of each sdio_remove call. This is causing 'rmmod bcmrfmac' on a 4356-sdio chip

[PATCH v2 0/2] brcmfmac: fixes for some corner cases

A couple of patches against v4.6-rc6 which fix an oops when handling buggy FW and clear int handler warnings on module unload Changes from v1: - combined the patches into a series since "Fix 'did not remove..." depends on "Fix kernel oops..." patch Christian Daudt (2): brcmfmac: Fix kernel