Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Grumbach, Emmanuel
On Mon, 2017-08-14 at 13:08 -0700, Igor Mitsyanko wrote: > On 08/14/2017 12:22 PM, Arend van Spriel wrote: > > On 14-08-17 15:49, Emmanuel Grumbach wrote: > > > User space can now allow the kernel to associate to an AP > > > that requires MFP or that doesn't have MFP enabled in the > > > same

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Grumbach, Emmanuel
On Mon, 2017-08-14 at 20:14 +0300, Kalle Valo wrote: > Emmanuel Grumbach writes: > > > User space can now allow the kernel to associate to an AP > > that requires MFP or that doesn't have MFP enabled in the > > same NL80211_CMD_CONNECT command. > > The driver /

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Igor Mitsyanko
On 08/14/2017 06:49 AM, Emmanuel Grumbach wrote: User space can now allow the kernel to associate to an AP that requires MFP or that doesn't have MFP enabled in the same NL80211_CMD_CONNECT command. The driver / firmware will decide whether to use it or not. Signed-off-by: Emmanuel Grumbach

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Igor Mitsyanko
On 08/14/2017 06:49 AM, Emmanuel Grumbach wrote: User space can now allow the kernel to associate to an AP that requires MFP or that doesn't have MFP enabled in the same NL80211_CMD_CONNECT command. The driver / firmware will decide whether to use it or not. Signed-off-by: Emmanuel Grumbach

Re: [PATCH v2 09/10] rtlwifi: use debugfs to debug.

2017-08-14 Thread Arend van Spriel
On 14-08-17 20:56, Joe Perches wrote: On Sun, 2017-06-25 at 10:43 -0500, Larry Finger wrote: From: Ping-Ke Shih Also the subject line is kinda generic. At least it made me smile ;-p Use debugfs to dump register and btcoex status. [] diff --git

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Igor Mitsyanko
On 08/14/2017 12:22 PM, Arend van Spriel wrote: On 14-08-17 15:49, Emmanuel Grumbach wrote: User space can now allow the kernel to associate to an AP that requires MFP or that doesn't have MFP enabled in the same NL80211_CMD_CONNECT command. The driver / firmware will decide whether to use it

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Igor Mitsyanko
On 08/14/2017 01:13 PM, Grumbach, Emmanuel wrote: It is kind of not clear right now for drivers where to get information from: - NL attributes passed from userspace and forwarded to a driver Since those exist, it seems to make more sense to me to use those rather than any in-driver decided

Re: [PATCH 05/11] rsi: handle station connection in AP mode

2017-08-14 Thread Arend van Spriel
On 14-08-17 08:53, Prameela Rani Garnepudi wrote: Hi Kalle, I will change the debug level and send the updated patches again. Thanks, Prameela Please do not top-post. On Mon, Aug 14, 2017 at 10:24 AM, Kalle Valo wrote: Amitkumar Karwar writes:

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Arend van Spriel
On 14-08-17 15:49, Emmanuel Grumbach wrote: User space can now allow the kernel to associate to an AP that requires MFP or that doesn't have MFP enabled in the same NL80211_CMD_CONNECT command. The driver / firmware will decide whether to use it or not. Signed-off-by: Emmanuel Grumbach

Re: [PATCH v2 09/10] rtlwifi: use debugfs to debug.

2017-08-14 Thread Larry Finger
On 08/14/2017 01:56 PM, Joe Perches wrote: On Sun, 2017-06-25 at 10:43 -0500, Larry Finger wrote: From: Ping-Ke Shih Use debugfs to dump register and btcoex status. [] diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c

Re: [PATCH v2 1/2] rtlwifi: use debugfs to debug.

2017-08-14 Thread Larry Finger
On 08/13/2017 11:49 PM, Barry Day wrote: On Thu, Aug 10, 2017 at 11:47:43AM -0500, Larry Finger wrote: +struct rtl_debgufs_priv { spelling mistake ? Yes, but a philosophical question remains: I understand that a comment can contain a typo. but is it really possible for the name of a

Re: [PATCH v2 09/10] rtlwifi: use debugfs to debug.

2017-08-14 Thread Larry Finger
On 08/14/2017 02:08 PM, Arend van Spriel wrote: On 14-08-17 20:56, Joe Perches wrote: On Sun, 2017-06-25 at 10:43 -0500, Larry Finger wrote: From: Ping-Ke Shih Also the subject line is kinda generic. At least it made me smile ;-p Subject now changed to "rtlwifi: Use

Re: AP mode with Broadcom 4330

2017-08-14 Thread Russell King - ARM Linux
On Fri, Jul 28, 2017 at 09:50:21PM +0200, Arend van Spriel wrote: > On 28-07-17 19:49, Russell King - ARM Linux wrote: > > Replacing that "(!mbss)" with "mbss" results in AP mode working on the > > 4330. However, I suspect: > > > > if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_MBSS)) > >

Re: [PATCH 3/3] mwifiex: debugfs: trigger device dump for usb interface

2017-08-14 Thread Brian Norris
Hi, On Mon, Aug 14, 2017 at 12:19:03PM +, Xinming Hu wrote: > From: Xinming Hu > > This patch extend device_dump debugfs function to make it > works for usb interface. > > Signed-off-by: Xinming Hu > Signed-off-by: Cathy Luo >

Re: [PATCH 2/3] mwifiex: device dump support for usb interface

2017-08-14 Thread Brian Norris
Hi, On Mon, Aug 14, 2017 at 12:19:02PM +, Xinming Hu wrote: > From: Xinming Hu > > Firmware dump on usb interface is different with current > sdio/pcie chipset, which is based on register operation. > > When firmware hang on usb interface, context dump will be > upload to

Re: [PATCH 1/3] mwifiex: refactor device dump code to make it generic for usb interface

2017-08-14 Thread Brian Norris
On Mon, Aug 14, 2017 at 12:19:01PM +, Xinming Hu wrote: > From: Xinming Hu > > This patch refactor current device dump code to make it generic > for subsequent implementation on usb interface. > > Signed-off-by: Xinming Hu > Signed-off-by: Cathy Luo

Re: [PATCH v2 09/10] rtlwifi: use debugfs to debug.

2017-08-14 Thread Joe Perches
On Mon, 2017-08-14 at 16:17 -0500, Larry Finger wrote: > On 08/14/2017 01:56 PM, Joe Perches wrote: > > On Sun, 2017-06-25 at 10:43 -0500, Larry Finger wrote: > > > From: Ping-Ke Shih > > > > > > Use debugfs to dump register and btcoex status. > > > > [] > > > diff --git

Re: [PATCH v2 09/10] rtlwifi: use debugfs to debug.

2017-08-14 Thread Joe Perches
On Sun, 2017-06-25 at 10:43 -0500, Larry Finger wrote: > From: Ping-Ke Shih > > Use debugfs to dump register and btcoex status. [] > diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c > b/drivers/net/wireless/realtek/rtlwifi/debug.c [] > +void rtl_debug_add_one(struct

Re: [for-4.13] brcmfmac: feature check for multi-scheduled scan fails on bcm4343x devices

2017-08-14 Thread Kalle Valo
Arend Van Spriel wrote: > The firmware feature check introduced for multi-scheduled scan turned out > to be failing for bcm4343{0,1,8} devices resulting in a firmware crash. > The reason for this crash has not yet been root cause so this patch avoids > the feature

Re: [PATCH 05/11] rsi: handle station connection in AP mode

2017-08-14 Thread Prameela Rani Garnepudi
Hi Kalle, I will change the debug level and send the updated patches again. Thanks, Prameela On Mon, Aug 14, 2017 at 10:24 AM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> Station

[v7 wlcore: add missing nvs file name info for wilink8

2017-08-14 Thread Reizer, Eyal
The following commits: commit c815fdebef44 ("wlcore: spi: Populate config firmware data") commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well. This broke user space backward

[PATCH 3/3] mwifiex: debugfs: trigger device dump for usb interface

2017-08-14 Thread Xinming Hu
From: Xinming Hu This patch extend device_dump debugfs function to make it works for usb interface. Signed-off-by: Xinming Hu Signed-off-by: Cathy Luo Signed-off-by: Ganapathi Bhat ---

[PATCH 2/3] mwifiex: device dump support for usb interface

2017-08-14 Thread Xinming Hu
From: Xinming Hu Firmware dump on usb interface is different with current sdio/pcie chipset, which is based on register operation. When firmware hang on usb interface, context dump will be upload to host using 0x73 firmware debug event. This patch store dump data from debug

[PATCH 1/3] mwifiex: refactor device dump code to make it generic for usb interface

2017-08-14 Thread Xinming Hu
From: Xinming Hu This patch refactor current device dump code to make it generic for subsequent implementation on usb interface. Signed-off-by: Xinming Hu Signed-off-by: Cathy Luo Signed-off-by: Ganapathi Bhat ---

[4.13 REGRESSION] Re: brcm43430 sdio wifi regression with 4.13-rc1

2017-08-14 Thread Hans de Goede
Hi, On 23-07-17 09:08, Hans de Goede wrote: Hi, On 22-07-17 21:53, Arend van Spriel wrote: On 22-07-17 21:19, Ian Molton wrote: On 22/07/17 20:18, Ian Molton wrote: On 22/07/17 19:43, Hans de Goede wrote: Hi, When upgrading my devel environment to 4.13-rc1+ I noticed that the brcm43430

Re: [4.13 REGRESSION] Re: brcm43430 sdio wifi regression with 4.13-rc1

2017-08-14 Thread Kalle Valo
Hans de Goede writes: >>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c >>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c >>> index d21258d..def120c 100644 >>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c >>> +++

[PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Emmanuel Grumbach
User space can now allow the kernel to associate to an AP that requires MFP or that doesn't have MFP enabled in the same NL80211_CMD_CONNECT command. The driver / firmware will decide whether to use it or not. Signed-off-by: Emmanuel Grumbach --- A short tour of the

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-14 Thread Kalle Valo
Emmanuel Grumbach writes: > User space can now allow the kernel to associate to an AP > that requires MFP or that doesn't have MFP enabled in the > same NL80211_CMD_CONNECT command. > The driver / firmware will decide whether to use it or not. > > Signed-off-by:

Re: [v7 wlcore: add missing nvs file name info for wilink8

2017-08-14 Thread Tony Lindgren
* Reizer, Eyal [170814 05:15]: > The following commits: > commit c815fdebef44 ("wlcore: spi: Populate config firmware data") > commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") > > Populated the nvs entry for wilink6 and wilink7 only while it is > still needed for

Re: [4.13 REGRESSION] Re: brcm43430 sdio wifi regression with 4.13-rc1

2017-08-14 Thread Hans de Goede
Hi, On 14-08-17 17:46, Kalle Valo wrote: Hans de Goede writes: diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c index d21258d..def120c 100644 ---