RE: [PATCH] mwifiex: remove unnecessary call to memset

2017-09-11 Thread Xinming Hu
Hi Himanshu, > -Original Message- > From: Himanshu Jha [mailto:himanshujha199...@gmail.com] > Sent: 2017年9月11日 20:46 > To: amitkar...@gmail.com > Cc: Nishant Sarmukadam ; Ganapathi Bhat > ; Xinming Hu ; > kv...@codeaurora.org;

Re: [PATCH 3/3] brcmfmac: Add check for short event packets

2017-09-11 Thread Mattias Nissler
On Fri, Sep 8, 2017 at 9:13 PM, Kevin Cernekee wrote: > > The length of the data in the received skb is currently passed into > brcmf_fweh_process_event() as packet_len, but this value is not checked. > event_packet should be followed by DATALEN bytes of additional event >

Re: [RFC 2/4] mac80211_hwsim: add hwsim_tx_rate_flags to Netlink Attributes

2017-09-11 Thread Benjamin Beichler
Am 08.09.2017 um 16:26 schrieb Johannes Berg: > On Fri, 2017-09-08 at 16:11 +0200, Benjamin Beichler wrote: >> For correct interpretation of a tx rate, the corresponding rate flags >> are needed (e.g. whether a HT-MCS rate or a legacy rate) and >> moreover for more correct simulation the other

QCA6174 fw logs howto

2017-09-11 Thread Bartosz Chronowski
Hi everyone, What are the steps necessary to read QCA6174 firmware logs? I'm using: echo 0x 0 > /sys/kernel/debug/ieee80211/phy*/ath10k/fw_dbglog trace-cmd record -e ath10k trace-cmd report > file But cannot see fw logs. Are those in binary format in "file" ? If so , how to convert them to

[PATCH] mwifiex: remove unnecessary call to memset

2017-09-11 Thread Himanshu Jha
call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value. Semantic patch used to resolve this issue: @@ expression e,e2; constant c; statement S; @@ e = kzalloc(e2, c); if(e == NULL) S - memset(e, 0,

Re: [PATCH 3/3] brcmfmac: Add check for short event packets

2017-09-11 Thread Arend van Spriel
On 11-09-17 11:19, Mattias Nissler wrote: On Fri, Sep 8, 2017 at 9:13 PM, Kevin Cernekee wrote: The length of the data in the received skb is currently passed into brcmf_fweh_process_event() as packet_len, but this value is not checked. event_packet should be followed

Re: [PATCH V2 1/3] brcmfmac: Avoid possible out-of-bounds read

2017-09-11 Thread Kalle Valo
Arend van Spriel writes: > On 09-09-17 21:30, Kevin Cernekee wrote: >> In brcmf_p2p_notify_rx_mgmt_p2p_probereq(), chanspec is assigned before >> the length of rxframe is validated. This could lead to uninitialized >> data being accessed (but not printed). Since