Re: [PATCH 11/17] rtlwifi: halmac: add files to implement halmac ops

On Fri, 2018-03-30 at 21:17 +0200, Johannes Berg wrote: > On Fri, 2018-03-30 at 15:19 +0800, pks...@realtek.com wrote: > >  > > +static struct rtl_halmac_ops rtl_halmac_operation = { > > You should make this const, if at all possible (it looks like it should > be). > I'll do it. > > +

Re: [PATCH] mt7601u: phy: mark expected switch fall-through

On Fri, 30 Mar 2018 16:12:23 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Jakub Kicinski

[PATCH 09/12] iwlwifi: Remove local iwl_bcast_addr and use ether_broadcast_addr

Use the new global to save a little bit of object code. Signed-off-by: Joe Perches --- drivers/net/wireless/intel/iwlwifi/dvm/dev.h | 1 - drivers/net/wireless/intel/iwlwifi/dvm/scan.c | 2 +- drivers/net/wireless/intel/iwlwifi/dvm/sta.c | 4 +--- 3 files changed, 2

[PATCH 00/12] Ethernet: Add and use ether__addr globals

There are many local static and non-static arrays that are used for Ethernet broadcast address output or comparison. Centralize the array into a single separate file and remove the local arrays. Joe Perches (12): ethernet: Add generic ether__addr addresses treewide/net: Rename eth_stp_addr

[PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr

Remove the local ALLFFMAC extern array and use the new global instead. Miscellanea: o Convert char *mac to const char *mac as it can't be modified Signed-off-by: Joe Perches --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 --

[PATCH 03/12] net: mac80211: Use global ether_broadcast_addr

Remove statics and use the new global ether_broadcast_addr instead to save some overall object code size. Signed-off-by: Joe Perches --- net/mac80211/iface.c| 5 + net/mac80211/key.c | 6 ++ net/mac80211/mesh_hwmp.c| 19 ++-

[PATCH 08/12] iwlegacy: Remove EXPORT_SYMBOL(il_bcast_addr) and use ether_broadcast_addr

Remove the local array and use the new global instead to save some small amount of object code. Signed-off-by: Joe Perches --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

On Sat, 2018-03-31 at 14:01 +, Pkshih wrote: > On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote: > > Use the new ether_broadcast_addr global instead to save some object code. [] > > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c [] > > @@ -1649,7 +1648,7 @@ static int

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote: > Use the new ether_broadcast_addr global instead to save some object code. > > Signed-off-by: Joe Perches > --- >  drivers/net/wireless/admtek/adm8211.c   | 3 +-- >  drivers/net/wireless/ath/carl9170/mac.c |