Re: iwlwifi-7265-ucode-25.30.14.0.tgz. in Centos 7

On Sun, Apr 08, 2018 at 08:58:35AM +0200, Dusan Bruncko wrote: > My problem is following: This firmware was created for kernel 4.2+, > but I am using > Centos 7 with kernels a la 3.10. Therefore I see during booting and Wireless stack and drivers are regularly updated in Centos kernel, (for

Re: [PATCH] ath9k: introduce endian_check module parameter

On 14-03-18 15:34, Kalle Valo wrote: Bas Vermeulen writes: --- a/drivers/net/wireless/ath/ath9k/init.c +++ b/drivers/net/wireless/ath/ath9k/init.c @@ -67,6 +67,9 @@ static int ath9k_ps_enable; module_param_named(ps_enable, ath9k_ps_enable, int, 0444);

Re: [ANN] mt76x0 usb driver

Hi On Mon, Apr 09, 2018 at 08:45:20PM +0200, Hans Ulli Kroll wrote: > here are my changes for working 5Ghz band and more USB ID's form my side I applied the changes and pushed to github repo. Thanks Stanislaw

Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

Am 09.04.2018 um 17:49 schrieb Kalle Valo: Sebastian Gottschall writes: you removed the call to leds_start from certain locations but you seem to have ignored the comment i wrote above the function call. IIRC I moved the comment to ath10k_leds_start(). there is a

Re: [ANN] mt76x0 usb driver

On Mon, Apr 09, 2018 at 04:53:44PM +0200, Lorenzo Bianconi wrote: > On Apr 09, Stanislaw Gruszka wrote: > > On Mon, Apr 09, 2018 at 04:26:42PM +0200, Lorenzo Bianconi wrote: > > > > I would like to integrate the driver to kernel via mt76 driver, i.e. > > > > add USB hooks and mt76x0 mac/phy code

[PATCH 1/2] net: wireless: zydas: Replace mdelay with msleep in zd1201_probe

zd1201_probe() is never called in atomic context. zd1201_probe() is only set as ".probe" in struct usb_driver. Despite never getting called from atomic context, zd1201_probe() calls mdelay() to busily wait. This is not necessary and can be replaced with msleep() to avoid busy waiting. This is

[PATCH 2/2] net: wireless: zydas: Replace GFP_ATOMIC with GFP_KERNEL in zd1201_fw_upload

zd1201_probe() is never called in atomic context. zd1201_fw_upload() is only called by zd1201_probe(), which is only set as ".probe" in struct usb_driver. Despite never getting called from atomic context, zd1201_fw_upload() calls kmalloc() with GFP_ATOMIC, which does not sleep for allocation.

[PATCH] net: wireless: cisco: airo: Replace mdelay with usleep_range in flashgchar

flashgchar() is never called in atomic context. flashgchar() is only called by flashcard(). flashcard() calls copy_from_user() and kmalloc(GFP_KERNEL), which indicates this function is not called in atomic context. Despite never getting called from atomic context, flashgchar() calls mdelay() to

Re: [v2,13/13] dt: bindings: add bindings for wcn3990 wifi block

Govind Singh wrote: > Add device tree binding documentation details for wcn3990 > wifi block present in Qualcomm SDM845/APQ8098 SoC into > "qcom,ath10k.txt". > > Signed-off-by: Govind Singh > Signed-off-by: Kalle Valo

Re: ath10k: sdio: fix memory leak for probe allocations

Marcus Folkesson wrote: > These allocations are not freed upon release. > When on it; go for managed resources instead. > > Signed-off-by: Marcus Folkesson > [kvalo: fix two checkpatch warnings] > Signed-off-by: Kalle Valo

Re: [next] wil6210: fix potential null dereference of ndev before null check

Colin Ian King wrote: > The pointer ndev is being dereferenced before it is being null checked, > hence there is a potential null pointer deference. Fix this by only > dereferencing ndev after it has been null checked > > Detected by CoverityScan, CID#1467010

Re: wcn36xx: Add missing fall through comment in smd.c

Loic Poulain wrote: > This prevents GCC warning. > > Reported-by: Dan Carpenter > Signed-off-by: Loic Poulain > Acked-by: Bjorn Andersson > Signed-off-by: Kalle Valo

[PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block

Remove unnecessary braces {} around an 'if' statement block with a single statement. Issue found by checkpatch. Signed-off-by: Eyal Ilsar --- This is part of my take on the Eudyptula challenge drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- 1 file changed, 1

[PATCH 0/4] Support for STA idle mode power save(IMPS)

From: Rakesh Pillai Enable STA idle mode power save(IMPS) for WCN3990 TLV target. In-order to support STA idle mode ps direct access to CE registers are protected via 2 mechanism. As target can power collapse based on idle inactivity and any target register access during

[PATCH 1/4] ath10k: Add hw params for shadow register support

From: Rakesh Pillai wcn3990 supports shadow register for ce write. Add a hw param for shadow register support. Signed-off-by: Rakesh Pillai --- drivers/net/wireless/ath/ath10k/core.c | 13 + drivers/net/wireless/ath/ath10k/hw.h |

Re: ath10k: fix spelling mistake: "tiggers" -> "triggers"

Colin Ian King wrote: > Trivial fix to spelling mistake in message text > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6ce36faeac35 ath10k: fix

Re: [1/3] wcn36xx: check for DMA mapping errors in wcn36xx_dxe_tx_frame()

Daniel Mack wrote: > Bail out if the mapping fails. Even though this hasn't occured during > tests, this unlikely case should still be handled. > > Signed-off-by: Daniel Mack > Acked-by: Ramon Fried > Signed-off-by: Kalle Valo

Re: wcn36xx: Remove useless skb spinlock

Loic Poulain wrote: > Each DXE control block is associated to a specific channel. > The channel lock is always taken before accessing a control block. > There is no need to have an extra (useless) spinlock for the control > block skb. > > Signed-off-by: Loic Poulain

Re: ath10k: avoid possible string overflow

Arnd Bergmann wrote: > The way that 'strncat' is used here raised a warning in gcc-8: > > drivers/net/wireless/ath/ath10k/wmi.c: In function > 'ath10k_wmi_tpc_stats_final_disp_tables': > drivers/net/wireless/ath/ath10k/wmi.c:4649:4: error: 'strncat' output > truncated before

Re: ath9k: dfs: remove accidental use of stack VLA

"Gustavo A. R. Silva" wrote: > In preparation to enabling -Wvla, remove accidental use of stack VLA. > > This avoids an accidental stack VLA (since the compiler thinks > the value of FFT_NUM_SAMPLES can change, even when marked > "const"). This just replaces it with a

Re: wcn36xx: allocate skbs with GFP_KERNEL during init

Daniel Mack wrote: > GFP_ATOMIC should only be used when the allocation is done from atomic > context. Introduce a new flag to wcn36xx_dxe_fill_skb() and use GFP_KERNEL > when pre-allocating buffers during init. > > This doesn't fix an issue that was observed in the wild, but

[PATCH 3/4] ath10k: Enable SRRI/DRRI support on ddr for WCN3990

From: Govind Singh SRRI/DRRI are not mapped in the HW Shadow block and can lead to un-clocked access if common subsystem in the target is powered down due to idle mode. To mitigate this problem SRRI/DRRI can be read from DDR instead of doing an actual hardware read. Host

[PATCH 4/4] ath10k: Enable sta idle power save

From: Govind Singh Enable sta power save in fw for the targets that supports idle power save. The idle ps enable command will be ignored by the firmware which does not support this feature. Signed-off-by: Govind Singh Signed-off-by: Rakesh Pillai

[PATCH 2/4] ath10k: Add support for shadow register for WNC3990

From: Rakesh Pillai WCN3990 needs shadow register write operation support for copy engine for regular operation in powersave mode. Add support for copy engine shadow register write in datapath tx for WCN3990 Signed-off-by: Rakesh Pillai ---

Re: [v2 PATCH] mwifiex: parse key management suite from RSN IE

On Tue, 2018-04-10 at 02:19 +, Xinming Hu wrote: > Hi Kalle, > > > -Original Message- > > From: Kalle Valo [mailto:kv...@codeaurora.org] > > Sent: 2018年4月9日 18:51 > > To: Xinming Hu > > Cc: Linux Wireless ; Brian Norris > >

[v2 2/7] rsi: device bootup parameter configuration

From: Amitkumar Karwar Some device configuration flags need to be enabled while sending 'bootup params' internal frame to firmware. This patch takes care of it. Signed-off-by: Amitkumar Karwar Signed-off-by: Siva Rebbagondla

[v2 3/7] rsi: use appropriate interface for power save configuration

From: Amitkumar Karwar Power save request should be sent on station interface. Virtual interface which is connected should be preferred. This patch resolves device not entering power save problem in certain situations Signed-off-by: Amitkumar Karwar

[v2 1/7] rsi: disable fw watchdog timer during reset

From: Amitkumar Karwar Firmware's watchdog timer should be disabled as a part of reset sequence. This change fixes a firmware hang issue observed during stress tests. Signed-off-by: Amitkumar Karwar Signed-off-by: Siva Rebbagondla

[v2 5/7] rsi: parse TID from data frame correctly

From: Amitkumar Karwar Currently TID is extracted by checking at specific offset in data frame. This approach doesn't work for some of the frames. This patch uses mac80211 API and do it correctly Signed-off-by: Amitkumar Karwar

[v2 7/7] rsi: advertise 5GHz support based on device capability

From: Amitkumar Karwar Currently 5GHz gets advertised even for the device which supports only 2.4Ghz band. This patch fixes the issue Signed-off-by: Amitkumar Karwar Signed-off-by: Siva Rebbagondla

[v2 6/7] rsi: enable power save by default for coex

From: Amitkumar Karwar Power save is by default enabled for WLAN and BT coex mode. Signed-off-by: Amitkumar Karwar Signed-off-by: Siva Rebbagondla ---

[v2 4/7] rsi: increase max supported aggregation subframes

From: Amitkumar Karwar Maximum number of supported aggregation subframes has been increased to 8. This is the optimal number for the driver. Signed-off-by: Amitkumar Karwar Signed-off-by: Siva Rebbagondla

[PATCH] wcn36xx: use READ_ONCE() to access desc->ctrl

When accessing shared memory to check for the stat of submitted descriptors, make sure to use READ_ONCE(). This will guarantee the compiler treats these memory locations as volatile and doesn't apply any caching. While this doesn't fix any particular problem I ran into, it's best practice to do

Re: [PATCH] net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment

On Tue, 10 Apr 2018 21:54:19 +0800 Jia-Ju Bai wrote: > dma_tx_fragment() is never called in atomic context. > > dma_tx_fragment() is only called by b43legacy_dma_tx(), which is > only called by b43legacy_tx_work(). > b43legacy_tx_work() is only set a parameter of

[PATCH] net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment

dma_tx_fragment() is never called in atomic context. dma_tx_fragment() is only called by b43legacy_dma_tx(), which is only called by b43legacy_tx_work(). b43legacy_tx_work() is only set a parameter of INIT_WORK() in b43legacy_wireless_init(). Despite never getting called from atomic context,

[v2 0/7] rsi driver improvements

From: Siva Rebbagondla This patch series brings in some improvements in power save, Tx data path etc. Changes in v2: Below patches are split and created smaller incremental patches[Kalle] [08/10] rsi: device disconnect changes [09/10]

[PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block

Add device tree binding documentation details for wcn3990 wifi block present in Qualcomm SDM845/APQ8098 SoC into "qcom,ath10k.txt". Signed-off-by: Govind Singh --- .../bindings/net/wireless/qcom,ath10k.txt | 31 ++ 1 file changed, 31

[PATCH 0/1] RFC: memory coherency and data races on TX path

I found something that I believe might be an issue, and I have an idea on how to correct this, but unfortunately, this doesn't solve the issues I occasionally see with this driver. I'd still like to share it, because I might be totally mistaken in my understanding. With no firmware code or

[PATCH 1/1 RFC] wcn36xx: fix buffer commit logic on TX path

When wcn36xx_dxe_tx_frame() is entered while the device is still processing the queue asyncronously, we are racing against the firmware code with updates to the buffer descriptors. Presumably, the firmware scans the ring buffer that holds the descriptors and scans for a valid control descriptor,

second wifi card enforce CN reg dom

hi. I am trying to capture on 2 channels at the same time with 2 cards. One card is TP-Link TL-W722N v1 using ath9k_htc and the second one is an Alfa AWUS051NH v2 using rt2800usb. I have tried this, first, on raspberry pi 0 W using archlinux-arm and reproduced the issue on a netbook using

Re: [PATCH v3 1/2] dma-mapping: move dma configuration to bus infrastructure

On Fri, Mar 30, 2018 at 01:24:44PM +0530, Nipun Gupta wrote: > It is bus specific aspect to map a given device on the bus and > relevant firmware description of its DMA configuration. > So, this change introduces 'dma_configure' as bus callback > giving flexibility to busses for implementing its

Re: [PATCH] wcn36xx: use READ_ONCE() to access desc->ctrl

On 10 April 2018 at 20:35, Daniel Mack wrote: > When accessing shared memory to check for the stat of submitted > descriptors, make sure to use READ_ONCE(). This will guarantee the > compiler treats these memory locations as volatile and doesn't apply > any caching. The

Re: [PATCH 0/1] RFC: memory coherency and data races on TX path

On 10 April 2018 at 20:42, Daniel Mack wrote: > I found something that I believe might be an issue, and I have an > idea on how to correct this, but unfortunately, this doesn't solve > the issues I occasionally see with this driver. I'd still like to > share it, because I might

Re: [PATCH v3 2/2] drivers: remove force dma flag from buses

On Fri, Mar 30, 2018 at 01:24:45PM +0530, Nipun Gupta wrote: > With each bus implementing its own DMA configuration callback, > there is no need for bus to explicitly have force_dma in its > global structure. This patch modifies of_dma_configure API to > accept an input parameter which specifies

Re: [PATCH v2] dt: bindings: add bindings for wcn3990 wifi block

Thanks Rob for the review comments. I have addressed the review comments in [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block. diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt

[PATCH] ath10k: fixed scan crash

From: Zhi Chen Length of WMI scan message was not calculated correctly. The allocated buffer was smaller than what we expected. So WMI message corrupted skb_info, which is at the end of skb->data. This fix takes TLV header into account even if the element is zero-length.

[PATCH] ath10k: fix tlv 5ghz channel missing issue

From: Zhi Chen The 5ghz channel parameters of TLV target wasn't passed to host, it caused host can only use lower channels from 36 to 64. Signed-off-by: Zhi Chen --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++ 1 file changed, 2

Re: iwlwifi: FW error in SYNC CMD TIME_QUOTA_CMD

On Mon, 2018-04-09 at 15:37 +0200, Daniel Borkmann wrote: > On 04/09/2018 12:13 AM, Daniel Borkmann wrote: > > Hi Luciano, > > > > On 04/07/2018 08:54 AM, Luciano Coelho wrote: > > > On Thu, 2018-04-05 at 16:55 +0200, Daniel Borkmann wrote: > > > > [...] > > > > after upgrading to 4608f064532c