RE: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-10-29 Thread Sharma, Sanjeev
-Original Message- From: Jes Sorensen [mailto:jes.soren...@redhat.com] Sent: Monday, October 27, 2014 2:13 PM To: Sharma, Sanjeev Cc: larry.fin...@lwfinger.net; gre...@linuxfoundation.org; linux-wireless@vger.kernel.org; de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org Subject:

RE: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-10-29 Thread Sharma, Sanjeev
-Original Message- From: Joe Perches [mailto:j...@perches.com] Sent: Monday, October 27, 2014 8:23 PM To: Jes Sorensen Cc: Sharma, Sanjeev; larry.fin...@lwfinger.net; gre...@linuxfoundation.org; linux-wireless@vger.kernel.org; de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org

Re: [PATCH 00/16] brcmfmac: wowl support and cleanup

2014-10-29 Thread Arend van Spriel
On 10/28/14 15:54, Joe Perches wrote: On Tue, 2014-10-28 at 14:56 +0100, Arend van Spriel wrote: This series has a couple of wowl patches that were too late to make the 3.18 merge window. Apart from those there are a number of rename and rework patches that get rid of the terms dhd and wl. The

RE: mwifiex_usb_submit_rx_urb: dev_alloc_skb failed when conected to 5GHz

2014-10-29 Thread Amitkumar Karwar
Hi Marek, We have one fix in Rx reorder logic and have handled dev_alloc_skb failure by resubmitting the urbs. Could you please test attached experimental patches? [ 76.769662] usb 1-1: Received between 2 BAR:2918 [ 76.775047] usb 1-1: Networking send size:2914 [ 77.067491] usb 1-1:

Re: MediaTek WiFi hardware support in upstream kernel

2014-10-29 Thread Felix Fietkau
Hi Hackers, Just a quick heads up: I'm working on a new driver for MT7662E/MT7612E, written from scratch. It is already able to bring up the firmware, init the MAC and do basic TX/RX DMA communication with the firmware. I've decided to not integrate it with rt2x00, because I want to avoid dealing

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Junjie Mao
I was not familiar with the acquiring/releasing API either, until I met with this bug... Perhaps we can use static checkers to avoid these issues as early as possible. Any suggestions? Best Regards Junjie Mao Martin Pitt martin.p...@ubuntu.com writes: Acked-By: Martin Pitt

Re: [PATCH] wireless: rt2x00: add new rt2800usb device

2014-10-29 Thread Stanislaw Gruszka
On Tue, Oct 28, 2014 at 04:42:41PM +0100, Cyril Brulebois wrote: 0x1b75 0xa200 AirLive WN-200USB wireless 11b/g/n dongle References: https://bugs.debian.org/766802 Reported-by: Martin Mokrejs mmokr...@fold.natur.cuni.cz Was this patch tested by reporter? I would rather see

Re: Channel Estimation Question

2014-10-29 Thread jeremy lansman
Emmanul; Thank you for that. I am a newbe to changing things at this low a level, so before I take the time to learn something new, I decided to do a test. On the page it says, When mac80211 wants to ensure that a frame is sent, it calls the flush() callback. Until now, iwldvm implemented

Re: [PATCH] wireless: rt2x00: add new rt2800usb device

2014-10-29 Thread Cyril Brulebois
Stanislaw Gruszka sgrus...@redhat.com (2014-10-29): On Tue, Oct 28, 2014 at 04:42:41PM +0100, Cyril Brulebois wrote: 0x1b75 0xa200 AirLive WN-200USB wireless 11b/g/n dongle References: https://bugs.debian.org/766802 Reported-by: Martin Mokrejs mmokr...@fold.natur.cuni.cz Was this

[PATCH] mwifiex: restart rxreorder timer correctly

2014-10-29 Thread Avinash Patil
From: Marc Yang yangy...@marvell.com During 11n RX reordering, if there is a hole in RX table, driver will not send packets to kernel until the rxreorder timer expires or the table is full. However, currently driver always restarts rxreorder timer when receiving a packet, which causes the timer

pull request: iwlwifi-next 2014-10-29

2014-10-29 Thread Emmanuel Grumbach
Hi John, Here is a pull request for 3.19. More details below. Thanks! The following changes since commit 35a9ad8af0bb0fa3525e6d0d20e32551d226f38e: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next (2014-10-08 21:40:54 -0400) are available in the git repository at:

[PATCH 06/25] iwlwifi: mvm: spin off a function to start scan offload

2014-10-29 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com The net-detect feature will require a scan offload to be started in the same way it is done now for scheduled scan. Spin a new function off of the sched_scan_start op code for reuse. Additionally, restructure the function a bit for more readability.

[PATCH 05/25] iwlwifi: mvm: move the check if associated outside of the iterator for wowlan

2014-10-29 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com Instead of checking if we are associated when suspending with wowlan enabled in the interface iterator, allow it to return an unassociated vif and move the check to the main suspend function. This will be needed by netdetect, since it should also

[PATCH 03/25] iwlwifi: mvm: hold the rtnl when resuming from a d3 test

2014-10-29 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com We use ieee80211_iter_keys() which requires the rtnl to be held. If we don't lock the rtnl, like we do when we suspend during a d3 test, we get the following splat: RTNL: assertion failed at net/mac80211/key.c (566) CPU: 1 PID: 26529 Comm: cat

[PATCH 01/25] iwlwifi: rs: option to easily disable Tx MIMO

2014-10-29 Thread Emmanuel Grumbach
From: Eyal Shapira e...@wizery.com The current TLC isn't optimized for low latency and some devices have issues with MIMO. This kind of combo creates latency issues. Allow to temporarily disable MIMO for tests in order to solve the latency issues without the added complexity of MIMO.

[PATCH 04/25] iwlwifi: mvm: split wowlan handling out of the main suspend function

2014-10-29 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com Take the WoWLAN handling code out of the main suspend function, dividing it into three parts: get_config (which is used before the firmware is switched), switch_to_d3 (which handles the rebooting of the hardware with the D3 firmware) and config (which

[PATCH 20/25] iwlwifi: dvm: Fix probable mask then right shift defect

2014-10-29 Thread Emmanuel Grumbach
From: Joe Perches j...@perches.com Precedence of and is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Emmanuel Grumbach

[PATCH 19/25] iwlwifi: mvm: remove unnecessary includes in tt.c

2014-10-29 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com We used to need to include some headers in order to read the registers and do all the calculations by ourselves, but this is not done anymore (i.e. we let the firmware do this for us), so we don't need to include those headers anymore. Signed-off-by:

[PATCH 21/25] iwlwifi: enable STBC support for 8000 chips

2014-10-29 Thread Emmanuel Grumbach
From: Eyal Shapira e...@wizery.com These chips support STBC in both Tx and Rx. Given that we've added STBC Tx support enable it. Signed-off-by: Eyal Shapira eyalx.shap...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/iwl-8000.c | 1 + 1

[PATCH 12/25] iwlwifi: always run the secured flow for family 8000

2014-10-29 Thread Emmanuel Grumbach
From: Eran Harary eran.har...@intel.com In the new format the CSS section has the same TLV type as the mem section. So we need to run the secured flow for all the 8000 products. Signed-off-by: Eran Harary eran.har...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com ---

[PATCH 14/25] iwlwifi: mvm: add MVM_FW_BCAST_FILTER_PASS_ALL option

2014-10-29 Thread Emmanuel Grumbach
From: Max Stepanov max.stepa...@intel.com The MVM_FW_BCAST_FILTER_PASS_ALL option defined in iwl-dbg-cfg.ini configuration file allows to enable/disable FW broadcast filtering. If MVM_FW_BCAST_FILTER_PASS_ALL is not defined in iwl-dbg-cfg.ini or its value is 0, the mvm broadcast filtering is

[PATCH 23/25] iwlwifi: mvm: fix scan condition iterator

2014-10-29 Thread Emmanuel Grumbach
From: David Spinadel david.spina...@intel.com Scan condition iterator assumes that an interface is associated if phy_ctxt is assigned, but this isn't the sutuation in P2P device. OTOH P2P device is never associated so we can simply ignore it. Signed-off-by: David Spinadel

[PATCH 22/25] iwlwifi: mvm: port to devcoredump framework

2014-10-29 Thread Emmanuel Grumbach
From: Johannes Berg johannes.b...@intel.com iwlwifi features a debug mechanism that allows to dump binary data which is helpful to debug the firmware. Until now, this data was made available for the userspace through debugfs. For this exact purpose, devcoredump was created. Move to the new

[PATCH 08/25] iwlwifi: mvm: change the iwl_mvm_d3_iface_iterator into a generic function

2014-10-29 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com Getting the BSS station vif is something that may be needed by other parts of the code. So, instead of having an iterator specifically for d3, change it into a generic one in utils.c. Additionally, add a iwl_mvm_get_bss_vif() function to make it

[PATCH 13/25] iwlwifi: mvm: BT Coex - move BT_ANTENNA_COUPLING_THRESHOLD to constants

2014-10-29 Thread Emmanuel Grumbach
From: Emmanuel Grumbach emmanuel.grumb...@intel.com This is were it really needs to be. Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/coex.c| 4 +--- drivers/net/wireless/iwlwifi/mvm/coex_legacy.c | 5 ++---

[PATCH 11/25] iwlwifi: pcie: fix recovery from ARC reset in WoWLAN

2014-10-29 Thread Emmanuel Grumbach
From: Emmanuel Grumbach emmanuel.grumb...@intel.com When the ARC is reset when we exit from Sx in case we had WoWLAN running, we can't access the prph before we reset the NIC. Reviewed-by: Johannes Berg johannes.b...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com ---

[PATCH 16/25] iwlwifi: mvm: BT Coex - make the multiprio lut a constant

2014-10-29 Thread Emmanuel Grumbach
From: Emmanuel Grumbach emmanuel.grumb...@intel.com This makes it easier to tune the values during the testing. Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/coex.c| 9 ++--- drivers/net/wireless/iwlwifi/mvm/coex_legacy.c | 9

[PATCH 25/25] iwlwifi: mvm: unref SCAN ref on scan completion

2014-10-29 Thread Emmanuel Grumbach
From: Eliad Peller el...@wizery.com The scan reference wasn't released in case of offloaded scan, causing the refcount to go wrong and prevent the device from going into d0i3. Signed-off-by: Eliad Peller eliadx.pel...@intel.com Reviewed-by: Johannes Berg johannes.b...@intel.com Signed-off-by:

[PATCH 10/25] iwlwifi: pcie: warn if extern fw_debug buffer failed

2014-10-29 Thread Emmanuel Grumbach
From: Emmanuel Grumbach emmanuel.grumb...@intel.com Otherwise we have no way to know that the buffer hasn't been allocated. Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/pcie/trans.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 18/25] iwlwifi: mvm: flush queues without mutex held

2014-10-29 Thread Emmanuel Grumbach
From: Johannes Berg johannes.b...@intel.com For WMM-AC we may have to be changing QoS parameters while the queues are being flushed. This is not relevant in the drop case, but matters when we wait for the device to finish the transmissions. To allow this, do the actual waiting without holding

[PATCH 09/25] iwlwifi: allow to restrict Tx aggregation size per-device

2014-10-29 Thread Emmanuel Grumbach
From: Gregory Greenman gregory.green...@intel.com A few slave bus devices show better performance when we reduce the size of the Tx A-MPDU. Signed-off-by: Gregory Greenman gregory.green...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com ---

[PATCH 17/25] iwlwifi: mvm: improve MCS rate warning

2014-10-29 Thread Emmanuel Grumbach
From: Johannes Berg johannes.b...@intel.com The warning gives no information about the frame, and presents the flags so that one might think they're the frame. Clarify and add more information. Signed-off-by: Johannes Berg johannes.b...@intel.com Signed-off-by: Emmanuel Grumbach

[PATCH 24/25] iwlwifi: mvm: rs: add Tx STBC support

2014-10-29 Thread Emmanuel Grumbach
From: Eyal Shapira e...@wizery.com STBC is enabled on HT/VHT SISO rates in case we don't care about power consumption and it won't hurt BT. This is done only in case the peer and our chip support STBC of course. While at it fixed a bug which was causing bw and ldpc flags to be set incorrectly in

Re: [PATCH] wireless: rt2x00: add new rt2800usb device

2014-10-29 Thread Stanislaw Gruszka
On Wed, Oct 29, 2014 at 12:12:24PM +0100, Cyril Brulebois wrote: Stanislaw Gruszka sgrus...@redhat.com (2014-10-29): On Tue, Oct 28, 2014 at 04:42:41PM +0100, Cyril Brulebois wrote: 0x1b75 0xa200 AirLive WN-200USB wireless 11b/g/n dongle References: https://bugs.debian.org/766802

[PATCH 15/25] iwlwifi: mvm: remove mvm argument from get_queues_mask

2014-10-29 Thread Emmanuel Grumbach
From: Arik Nemtsov a...@wizery.com It is unused and won't be available in some future invocations of the function. Signed-off-by: Arik Nemtsov arikx.nemt...@intel.com Reviewed-by: Johannes Berg johannes.b...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com ---

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Fengguang Wu
On Wed, Oct 29, 2014 at 06:23:02PM +0800, Junjie Mao wrote: I was not familiar with the acquiring/releasing API either, until I met with this bug... Perhaps we can use static checkers to avoid these issues as early as possible. Any suggestions? CC Dan. His smatch checker might be able (or

[PATCH] ath10k: handle ieee80211 header and payload tracing separately

2014-10-29 Thread Rajkumar Manoharan
For packet log, the transmitted frame 802.11 header alone is sufficient. Recording entire packet is also consuming lot of disk space. To optimize this, tx and rx data tracepoints are splitted into header and payload tracepoints. To record tx ieee80211 headers trace-cmd record -e

[PATCH 2/2] brcmsmac: expose 802.11 core statistics in debugfs

2014-10-29 Thread Arend van Spriel
The 802.11 statistics obtained from the device can be retrieved dumping the 'macstat' file in debugfs folder. Reviewed-by: Hante Meuleman meule...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com ---

[PATCH 0/2] brcmsmac: fix and expose 802.11 core statistics

2014-10-29 Thread Arend van Spriel
When looking at exposing the 802.11 core statistics a problem was found in code obtaining the statistics from the device. This series fixes that and exposes the statistics in debugfs. Hopefully this can reveal what is causing connectivity issues on certain bcm4313 chipsets. The series is intended

[PATCH 1/2] brcmsmac: fix statistic counter update function

2014-10-29 Thread Arend van Spriel
The 802.11 core statistics are retrieved from the core registers but not stored. So the debug code was never triggered to give a warning message on tx underruns or rx overflows. This patch fixes this and assures the statistics are stored in the snapshot. Reviewed-by: Hante Meuleman

Re: [PATCH] ath10k: handle ieee80211 header and payload tracing separately

2014-10-29 Thread Johannes Berg
On Wed, 2014-10-29 at 19:39 +0530, Rajkumar Manoharan wrote: + u32 hdr_len = ieee80211_hdrlen(hdr-frame_control); + trace_ath10k_rx_hdr(ar, hdr, hdr_len); + trace_ath10k_rx_payload(ar, skb-data + hdr_len, skb-len - hdr_len); Another note, since you're taking my suggestion :-) It

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Johannes Berg
On Tue, 2014-10-28 at 09:31 +0800, Junjie Mao wrote: The driver is not released when ieee80211_register_hw fails in mac80211_hwsim_create_radio, leading to the access to the unregistered (and possibly freed) device in platform_driver_unregister: Applied. johannes -- To unsubscribe from this

Re: [PATCH 3.18] mac80211: flush keys for AP mode on ieee80211_do_stop

2014-10-29 Thread Johannes Berg
On Mon, 2014-10-27 at 11:56 +0100, Felix Fietkau wrote: Userspace can add keys to an AP mode interface before start_ap has been called. If there have been no calls to start_ap/stop_ap in the mean time, the keys will still be around when the interface is brought down. I applied the following

Re: [PATCH 0/2] mac80211: fix HT+ to HT- (and vice-versa) CSA

2014-10-29 Thread Johannes Berg
On Tue, 2014-10-28 at 15:32 +0200, Luca Coelho wrote: (fixed Johannes' email address) Both these bugs go far back, so IMHO they should go to 3.8 and stable. Both applied. I think you meant 3.18 :) johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the

Re: [PATCH 1/2] staging: rtl8723au: core: pointer issue

2014-10-29 Thread Greg KH
On Sun, Oct 26, 2014 at 04:17:46PM +, Paul McQuade wrote: ERROR: foo * bar should be foo *bar Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Again with the odd subject

Re: [PATCH 2/2] staging: rtl8723au: core style issue

2014-10-29 Thread Greg KH
On Mon, Oct 27, 2014 at 12:16:08AM +, Paul McQuade wrote: spaces required around % Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Your subject does not make sense :( -- To

Re: [PATCH][V2] Staging:rtl8723au: open/closed brace issue

2014-10-29 Thread Greg KH
On Sun, Oct 26, 2014 at 03:10:22PM +, Paul McQuade wrote: ERROR: that open brace { should be on the previous line Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 130 ++-- 1 file changed, 40 insertions(+), 90

Re: [PATCH] wireless: nl80211: Broadcast CMD_NEW_INTERFACE and CMD_DEL_INTERFACE

2014-10-29 Thread Johannes Berg
On Mon, 2014-10-27 at 14:43 +0200, Tomasz Bursztyka wrote: Let the other listeners being notified when a new or del interface command has been issued, thus reducing later necessary request to be in sync with current context. I see no reason to list wireless: in the subject - please just use

Re: [PATCH] wireless: nl80211: Broadcast CMD_NEW_INTERFACE and CMD_DEL_INTERFACE

2014-10-29 Thread Johannes Berg
On Wed, 2014-10-29 at 16:44 +0100, Johannes Berg wrote: + nl80211_notify_iface(rdev, NULL, iftype, id, address, dev, +0, NULL, false, info-snd_portid); I'm not sure why this needs to be so late in the command, if you put it first you don't have the whole argument

Re: [PATCH 01/48] staging: vt6655: s_cbFillTxBufHead remove unused parameters

2014-10-29 Thread Greg KH
On Sat, Oct 25, 2014 at 09:39:39AM +0100, Malcolm Priestley wrote: Remove the following parameters PSEthernetHeader psEthHeader PSKeyItem pTransmitKey bool bNeedEncrypt Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/rxtx.c | 14 ++ 1 file

Re: [PATCH 0/2] mac80211: fix HT+ to HT- (and vice-versa) CSA

2014-10-29 Thread Luca Coelho
On October 29, 2014 5:37:35 PM EET, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2014-10-28 at 15:32 +0200, Luca Coelho wrote: (fixed Johannes' email address) Both these bugs go far back, so IMHO they should go to 3.8 and stable. Both applied. I think you meant 3.18 :) Oops!

Re: [PATCH 00/31] staging: vt6655: Conversion to mac80211

2014-10-29 Thread Greg KH
On Sat, Oct 25, 2014 at 09:20:10AM +0100, Malcolm Priestley wrote: The patches in this series convert the driver to mac80211. As well as infrastructure mode the driver now operates in IBSS and access point modes. Host access point is now working with hostapd in nl80211 mode. The driver

[patch] ath9k: fix some debugfs output

2014-10-29 Thread Dan Carpenter
The right shift operation has higher precedence than the mask so we left shift by (i * 3) and then immediately right shift by (i * 3) then we mask. It should be left shift, mask, and then right shift. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

Re: [PATCH 2/3] mac80211-hwsim: Provide multicast event for HWSIM_CMD_NEW_RADIO

2014-10-29 Thread Johannes Berg
On Mon, 2014-10-27 at 12:44 +0200, Jukka Rissanen wrote: +static void mcast_msg(struct sk_buff *mcast_skb, struct genl_info *info) +{ + if (info) + genl_notify(hwsim_genl_family, mcast_skb, + genl_info_net(info), info-snd_portid, +

Re: [PATCH 2/3] mac80211-hwsim: Provide multicast event for HWSIM_CMD_NEW_RADIO

2014-10-29 Thread Johannes Berg
On Wed, 2014-10-29 at 16:50 +0100, Johannes Berg wrote: On Mon, 2014-10-27 at 12:44 +0200, Jukka Rissanen wrote: +static void mcast_msg(struct sk_buff *mcast_skb, struct genl_info *info) +{ + if (info) + genl_notify(hwsim_genl_family, mcast_skb, +

Re: [PATCH 1/3] mac80211-hwsim: Rename CREATE and DESTROY radio to NEW and DEL radio

2014-10-29 Thread Johannes Berg
On Mon, 2014-10-27 at 12:44 +0200, Jukka Rissanen wrote: Using the name HWSIM_CMD_NEW_RADIO and HWSIM_CMD_DEL_RADIO is more fitting on how other pieces of the wireless system work. Applied. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a

Re: [PATCH 2/3] mac80211-hwsim: Provide multicast event for HWSIM_CMD_NEW_RADIO

2014-10-29 Thread Johannes Berg
On Mon, 2014-10-27 at 12:44 +0200, Jukka Rissanen wrote: +static void mcast_new_radio(int id, struct genl_info *info, + int channels, const char *reg_alpha2, + const struct ieee80211_regdomain *regd, + bool reg_strict,

Re: [PATCH] mac80211-hwsim: support SGI-20

2014-10-29 Thread Johannes Berg
On Fri, 2014-10-24 at 11:12 -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com This lets hostapd start if you have SGI-20 configured as one of your HT capabilities. Applied. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in

Re: [patch] ath9k: fix some debugfs output

2014-10-29 Thread Joe Perches
On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: The right shift operation has higher precedence than the mask so we left shift by (i * 3) and then immediately right shift by (i * 3) then we mask. It should be left shift, mask, and then right shift. Hey Dan. My grep pattern doesn't

[patch] iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco()

2014-10-29 Thread Dan Carpenter
The shift operation is higher precedence so the code is wrong and it sets of a static checker warning. But it doesn't affect real life because BT_UART_MSG_FRAME3SCOESCO_POS is zero so the shift is a no-op. I have re-written it in normal style and with parenthesis as a cleanup and to silence the

Re: [patch] ath9k: fix some debugfs output

2014-10-29 Thread Dan Carpenter
On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote: On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: The right shift operation has higher precedence than the mask so we left shift by (i * 3) and then immediately right shift by (i * 3) then we mask. It should be left shift,

Re: [PATCH] mac80211-hwsim: add frequency attribute to netlink pkts

2014-10-29 Thread Johannes Berg
On Wed, 2014-10-29 at 09:02 -0700, Ben Greear wrote: On 10/29/2014 08:55 AM, Johannes Berg wrote: On Mon, 2014-10-27 at 15:04 -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Add frequency attribute when sending to user-space over netlink socket. The

Re: [patch] ath9k: fix some debugfs output

2014-10-29 Thread Joe Perches
On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote: On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote: On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: The right shift operation has higher precedence than the mask so we left shift by (i * 3) and then immediately right

Re: [patch] iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco()

2014-10-29 Thread Emmanuel Grumbach
On Wed, Oct 29, 2014 at 6:08 PM, Dan Carpenter dan.carpen...@oracle.com wrote: The shift operation is higher precedence so the code is wrong and it sets of a static checker warning. But it doesn't affect real life because BT_UART_MSG_FRAME3SCOESCO_POS is zero so the shift is a no-op. I have

[PATCH] mac80211-hwsim: remove un-used variable

2014-10-29 Thread greearb
From: Ben Greear gree...@candelatech.com Remove un-used variable added in recent patch. Can re-add this when we have an idea how to deal with receiving pkts from user-space on channels not supported by current operating mode of the virual radio. Signed-off-by: Ben Greear gree...@candelatech.com

Re: [PATCH 01/48] staging: vt6655: s_cbFillTxBufHead remove unused parameters

2014-10-29 Thread Malcolm Priestley
On 29/10/14 09:15, Greg KH wrote: On Sat, Oct 25, 2014 at 09:39:39AM +0100, Malcolm Priestley wrote: Remove the following parameters PSEthernetHeader psEthHeader PSKeyItem pTransmitKey bool bNeedEncrypt Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/rxtx.c |

[PATCH v2 01/34] staging: vt6655: mac80211 conversion: add new rx functions

2014-10-29 Thread Malcolm Priestley
vnt_receive_frame which replaces device_receive_frame and vnt_rx_data which handles mac80211 rx data structures ieee80211_hw, ieee80211_vif and variable rx_rate are added in structure vnt_private --- drivers/staging/vt6655/device.h | 6 +- drivers/staging/vt6655/device_main.c | 13 ++--

[PATCH v2 02/34] staging: vt6655: mac80211 conversion: add new key functions

2014-10-29 Thread Malcolm Priestley
vnt_key_init_table to initialize the table vnt_set_keys to set the keys Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device.h | 1 + drivers/staging/vt6655/key.c| 136 drivers/staging/vt6655/key.h| 17 + 3

[PATCH v2 09/34] staging: vt6655: mac80211 conversion add channel bands

2014-10-29 Thread Malcolm Priestley
Add rates and channels according to rf type for vnt_init_bands which is a mac80211 replacement for init_channel_table. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/channel.c | 140 +++ drivers/staging/vt6655/channel.h |

[PATCH v2 06/34] staging: vt6655: mac80211 conversion: s_vFillRTSHead convert to using struct ieee80211_hdr

2014-10-29 Thread Malcolm Priestley
Removing PSEthernetHeader Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/rxtx.c | 91 ++- 1 file changed, 12 insertions(+), 79 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index

[PATCH v2 10/34] staging: vt6655: mac80211 conversion replace suspend resume functions

2014-10-29 Thread Malcolm Priestley
add vt6655_suspend and vt6655_resume remove viawget_suspend and viawget_resume. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 104 --- 1 file changed, 34 insertions(+), 70 deletions(-) diff --git

[PATCH v2 05/34] staging: vt6655: dead code remove s_vFillFragParameter.

2014-10-29 Thread Malcolm Priestley
s_vFillFragParameter is nolonger used. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/rxtx.c | 47 --- 1 file changed, 47 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index

[PATCH v2 08/34] staging: vt6655: mac80211 conversion add main mac80211 functions

2014-10-29 Thread Malcolm Priestley
Replace existing vt6655_probe with one converted to mac80211 with the following operations vnt_tx_80211 vnt_start vnt_stop vnt_add_interface vnt_remove_interface vnt_config vnt_bss_info_changed vnt_prepare_multicast vnt_configure vnt_set_key vnt_get_tsf vnt_set_tsf vnt_reset_tsf The following

[PATCH v2 12/34] staging: vt6655: mac80211 conversion: changes to device_intr

2014-10-29 Thread Malcolm Priestley
Remove net device code. Remove current measure code and function s_vCompleteCurrentMeasure and switch code which are now handled by mac80211 Change beaconing to mac80211. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 175

[PATCH v2 32/34] staging: vt6655: vnt_rx_data: uCurrRSSI should have the value of *rssi

2014-10-29 Thread Malcolm Priestley
Fixes issue of byBBVGANew is wrong in device_intr Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/dpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c index 036bbb0..11153ef 100644 ---

[PATCH v2 30/34] staging: vt6655: baseband.c timers replace spin lock

2014-10-29 Thread Malcolm Priestley
Use spin_lock_irqsave and spin_unlock_irqrestore in functions TimerSQ3CallBack and TimerState1CallBack Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/baseband.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[PATCH v2 27/34] staging: vt6655: baseband.c replace BIT0 with BIT(0)

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/baseband.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index b8a64c0..8adeea4 100644 ---

[PATCH v2 33/34] staging: vt6655: don't update bUpdateBBVGA when off channel

2014-10-29 Thread Malcolm Priestley
Check flag conf IEEE80211_CONF_OFFCHANNEL so that RSSI doesn't swing wildly on scanning. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vt6655/device_main.c

[PATCH v2 21/34] staging: vt6655: switch driver over to mac80211

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/Kconfig b/drivers/staging/vt6655/Kconfig index c3ba693..77cfc70 100644 --- a/drivers/staging/vt6655/Kconfig +++

[PATCH v2 25/34] staging: vt6655: mac80211 conversion: PSbIsNextTBTTWakeUp convert to mac80211

2014-10-29 Thread Malcolm Priestley
Wake up to listen to next beacon when struct ieee80211_conf - listen_interval == 1 Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/power.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vt6655/power.c

[PATCH v2 24/34] staging: vt6655: vt6655_probe remove management pointers

2014-10-29 Thread Malcolm Priestley
All these pointers are now dead. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 0bd2ca8..d7dd002 100644 ---

[PATCH v2 20/34] staging: vt6655: mac80211 conversion: device_free_info

2014-10-29 Thread Malcolm Priestley
Remove net device code and add mac80211 unregister code. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c

[PATCH v2 23/34] staging: vt6655: mac80211 conversion: device_error remove legacy functions

2014-10-29 Thread Malcolm Priestley
Remove netif_stop_queue, bCmdRunning and timer functions Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index

[PATCH v2 22/34] staging: vt6655: phy type same as bb type

2014-10-29 Thread Malcolm Priestley
To maintain functionality typedef enum _CARD_PHY_TYPE should have the same values as typedef enum _VIA_PKT_TYPE TODO both these types need merging. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/card.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 11/34] staging: vt6655: mac80211 conversion: device_print_info remove netdevice.

2014-10-29 Thread Malcolm Priestley
use dev_info for device name and pcid-irq for irq number. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c

[PATCH v2 17/34] staging: vt6655: mac80211 conversion: card.c use basic_rates

2014-10-29 Thread Malcolm Priestley
Use basic_rates to find cck and ofdm rates. wBasicRate will be removed later. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/card.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/card.c

[PATCH v2 18/34] staging: vt6655: CARDbSetPhyParameter replace s_vSetRSPINF with CARDvSetRSPINF

2014-10-29 Thread Malcolm Priestley
Removing s_vSetRSPINF Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/card.c | 120 +- 1 file changed, 1 insertion(+), 119 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index

[PATCH v2 20/48] staging: vt6655: deadcode remove aes_ccmp/rc4/tkip

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/Makefile | 3 - drivers/staging/vt6655/aes_ccmp.c | 374 -- drivers/staging/vt6655/aes_ccmp.h | 37 drivers/staging/vt6655/device.h | 2 - drivers/staging/vt6655/rc4.c

[PATCH v2 09/48] staging: vt6655: remove dead functions in power.c/h

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/power.c | 171 - drivers/staging/vt6655/power.h | 16 drivers/staging/vt6655/wcmd.c | 2 - drivers/staging/vt6655/wmgr.c | 6 -- 4 files changed, 195 deletions(-)

[PATCH v2 02/48] staging: vt6655: dead code remove zones and channel table elements

2014-10-29 Thread Malcolm Priestley
emply functions will be deleted later Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/channel.c | 605 +-- drivers/staging/vt6655/channel.h | 8 - 2 files changed, 2 insertions(+), 611 deletions(-) diff --git

[PATCH v2 18/48] staging: vt6655: deadcode remove wroute.c/h

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/Makefile | 1 - drivers/staging/vt6655/device_main.c | 1 - drivers/staging/vt6655/rxtx.c| 1 - drivers/staging/vt6655/wroute.c | 177 ---

[PATCH v2 07/48] staging: vt6655: dead code remove wpactl.c/h

2014-10-29 Thread Malcolm Priestley
All these functions are now dead. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/Makefile | 1 - drivers/staging/vt6655/device_main.c | 1 - drivers/staging/vt6655/wpactl.c | 893 --- drivers/staging/vt6655/wpactl.h

[PATCH v2 14/48] staging: vt6655: dead code remove bssdb.c

2014-10-29 Thread Malcolm Priestley
header will be removed later Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/Makefile |1 - drivers/staging/vt6655/bssdb.c | 1504 -- drivers/staging/vt6655/bssdb.h | 115 --- drivers/staging/vt6655/vntwifi.c | 16 -

[PATCH v2 22/48] staging: vt6655: dead code remove vntwifi.c functions

2014-10-29 Thread Malcolm Priestley
Header will be removed later Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/Makefile | 3 +- drivers/staging/vt6655/vntwifi.c | 658 --- drivers/staging/vt6655/vntwifi.h | 168 -- 3 files changed, 1 insertion(+), 828

[PATCH v2 13/48] staging: vt6655: s_cbFillTxBufHead remove unused parameters

2014-10-29 Thread Malcolm Priestley
Remove the following parameters PSEthernetHeader psEthHeader PSKeyItem pTransmitKey bool bNeedEncrypt Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/rxtx.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v2 16/48] staging: vt6655: dead code remove IEEE11.h.c/h

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/IEEE11h.c | 139 --- drivers/staging/vt6655/IEEE11h.h | 42 drivers/staging/vt6655/Makefile | 3 +- drivers/staging/vt6655/vntwifi.c | 3 - 4 files changed, 1

[PATCH v2 11/48] staging: vt6655: dead code remove wcmd.c

2014-10-29 Thread Malcolm Priestley
header will be removed later. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/Makefile | 1 - drivers/staging/vt6655/bssdb.c | 7 - drivers/staging/vt6655/wcmd.c | 958 drivers/staging/vt6655/wcmd.h | 32 -- 4

[PATCH v2 21/48] staging: vt6655: dead code remove michael.c/h

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/Makefile | 1 - drivers/staging/vt6655/michael.c | 148 --- drivers/staging/vt6655/michael.h | 52 -- drivers/staging/vt6655/rxtx.c| 1 - 4 files changed, 202

[PATCH v2 17/48] staging: vt6655: card.c/h remove dead functions

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/card.c | 724 -- drivers/staging/vt6655/card.h | 75 - 2 files changed, 799 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index

[PATCH v2 29/48] staging: vt6655: channel.c remove dead functions

2014-10-29 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/channel.c | 113 --- drivers/staging/vt6655/channel.h | 13 - 2 files changed, 126 deletions(-) diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c

  1   2   >