Re: [PATCH v2 08/10] mac80211: add max. lossless throughput per rate to rc_stats

2015-03-17 Thread Felix Fietkau
On 2015-02-13 15:57, Thomas Huehn wrote: This patch adds the new statistic maximum possible lossless throughput to Minstrels and Minstrel-HTs rc_stats (in debugfs). This enables comprehensive comparison between current per-rate throughput and max. achievable per-rate throughput.

Re: [1/3] rt2x00usb: initialize the read value in case of failure

2015-03-17 Thread Sebastian Andrzej Siewior
* Sebastian Andrzej Siewior | 2015-03-16 17:41:00 [+0100]: Just an update: … |ieee80211 phy0: rt2800usb_write_firmware: Info - Firmware loading not required - NIC in AutoRun mode |IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready |IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready switch

Re: [PATCH v2 04/10] mac80211: add new Minstrel-HT statistic output via csv

2015-03-17 Thread Felix Fietkau
On 2015-02-13 15:57, Thomas Huehn wrote: This patch adds a new debugfs file rc_stats_csv to output Minstrel-HTs statistics in a common csv format that is easy to parse. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de Signed-off-by: Stefan Venz ikstrea...@gmail.com --- ---

Re: [PATCH v2 03/10] mac80211: add new Minstrel statistic output via csv

2015-03-17 Thread Felix Fietkau
On 2015-02-13 15:57, Thomas Huehn wrote: This patch adds a new debugfs file rc_stats_csv to output Minstrels statistics in a common csv format that is easy to parse. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de Signed-off-by: Stefan Venz ikstrea...@gmail.com ---

Re: Broadcom 43340

2015-03-17 Thread Jürgen Bausa
Arend van Spriel arend@... writes: On 03/15/15 21:38, Jürgen Bausa wrote: would be nice, if you could make it clear. Maybe you need to mount it. This is what I found [1]: $ sudo mount -t efivarfs none /sys/firmware/efi/efivars Thanks, that worked. Now I have firmware and

[PATCH] iw: Print OSEN element for HotSpot 2.0 IE.

2015-03-17 Thread greearb
From: Ben Greear gree...@candelatech.com Re-uses most of the print-rsn logic since only the header differs. Example output: ... HotSpot 2.0 OSEN: * Group cipher: NO-GROUP * Pairwise ciphers: CCMP * Authentication suites: OSEN

Re: [PATCH] mac80211: initialize rate control earlier for tdls station

2015-03-17 Thread Johannes Berg
On Sun, 2015-03-08 at 18:04 +0200, Arik Nemtsov wrote: From: Marek Puzyniak marek.puzyn...@tieto.com Currently when TDLS station in driver goes from authorized from authenticated to associated state it can not use rate control parameters because rate control is not initialized yet. Some

Re: [PATCHv2 2/3] mac80211: ibss refactor ieee80211_rx_bss_info

2015-03-17 Thread Johannes Berg
On Mon, 2015-03-09 at 07:58 +0100, Janusz Dziedzic wrote: Put station specific code in ieee80211_update_sta_info function. Applied. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCHv2 3/3] mac80211: add VHT support for IBSS

2015-03-17 Thread Johannes Berg
On Mon, 2015-03-09 at 07:58 +0100, Janusz Dziedzic wrote: Add VHT support for IBSS. Drivers could activate this feature by setting NL80211_EXT_FEATURE_VHT_IBSS flag. I'm assuming this needs patch 1 to go in first, so am not applying this. If I'm wrong let me know, or just resend with the

Re: [PATCH iw 2/2] iw: add a delay option to net-detect

2015-03-17 Thread Johannes Berg
On Fri, 2015-03-13 at 14:17 +0200, Luca Coelho wrote: From: Luciano Coelho luciano.coe...@intel.com Add an option that allows the initial net-detect scan to be delayed by the specified number of seconds. Applied. johannes -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] mac80211: minstrel_ht: fix rounding issue in MCS duration calculation

2015-03-17 Thread Johannes Berg
On Fri, 2015-03-13 at 10:54 +0100, Felix Fietkau wrote: On very high MCS bitrates, the calculated duration of rates that are next to each other can be very imprecise, due to the small packet size used as reference (1200 bytes). This is most visible in VHT80 nss=2 MCS8/9, for which minstrel

Re: [PATCHv2 1/3] mac80211: IBSS fix scan request

2015-03-17 Thread Johannes Berg
On Mon, 2015-03-09 at 07:58 +0100, Janusz Dziedzic wrote: In case of wide bandwidth scan all channels we have in chandef. For example in case of 80MHz bandwidth we have four possible control channels. I think you misunderstood - this doesn't really say *why* either. It should probably say

[PATCH v4] mac80211: Get IV len from key conf and not cipher scheme

2015-03-17 Thread Cedric Izoard
When a key is installed using a cipher scheme, a new internal flag KEY_FLAG_CIPHER_SCHEME is set. This flag is used on TX path to test for cipher scheme key, instead of testing for sta-cipher_scheme as sta is NULL for bcast/mcast messages. For cipher scheme key, security header length is then

Re: Connection issues with BW Tracking in mac80211

2015-03-17 Thread Johannes Berg
On Thu, 2015-03-12 at 14:47 +0530, Krishna Chaitanya wrote: 1. Make the directed probe mandatory: a. Check for successful probe resp without depending on proberesp_ies. b. remove the proberesp_ies from the auth_data to trigger directed probe. 2. Timestamps for

Re: [PATCH] cfg80211: Process all pending regulatory requests/hints

2015-03-17 Thread Johannes Berg
On Thu, 2015-03-12 at 09:37 -0400, Ilan Peer wrote: From: Ben ben.rosenf...@intel.com It is possible that there are several regulatory requests pending, but the processing of the last one does not call CRDA, and thus the other requests are not handled. Fix this by rescheduling the work

Re: [PATCH v2] iw: display allowable channel bandwidth information

2015-03-17 Thread Johannes Berg
On Wed, 2015-03-04 at 12:34 +0530, Ashok Raj Nagarajan wrote: We already have allowable channel bandwidth information at userspace. Display this information with 'iw list'. Excerpt of iw list command Frequencies: * 5180 MHz [36] (17.0 dBm) (10MHZ, 20MHZ, HT40+, VHT80, VHT160)

Re: [PATCH v3] mac80211: Get IV len from key conf and not cipher scheme

2015-03-17 Thread Johannes Berg
On Wed, 2015-03-11 at 16:29 +, Cedric Izoard wrote: When a key is installed using a cipher scheme, a new flag IEE80211_KEY_FLAG_CIPHER_SCHEME is set. Should this flag really be visible to the driver? The driver should better know if it's a CS key anyway, no? And then we could use an

[PATCH v3] mac80211: add an intermediate software queue implementation

2015-03-17 Thread Felix Fietkau
This allows drivers to request per-vif and per-sta-tid queues from which they can pull frames. This makes it easier to keep the hardware queues short, and to improve fairness between clients and vifs. The task of scheduling packet transmission is left up to the driver - queueing is controlled by

Re: Mesh mode in ath10k

2015-03-17 Thread Bob Copeland
On Sat, Mar 14, 2015 at 08:09:27PM +0100, Dani Camps wrote: Dear all, Has anyone tested mesh mode (802.11s) with ath10k? Any feedback about potential problems encountered and hints to resolve them is appreciated. Hi Dani, I've spent a little bit of time on it (on the order of an hour or

[PATCH v3 10/10] mac80211: add standard deviation to Minstrels throughput statistic

2015-03-17 Thread Thomas Huehn
This patch adds the statistical descriptor standard deviation to better describe the current properties of Minstrel and Minstrel-HTs success probability distribution. The standard deviation (SD) is calculated as exponential weighted moving standard deviation (EWMSD) and its current value is added

[PATCH v3 05/10] mac80211: unify Minstrel Minstrel-HTs calculation of rate statistics

2015-03-17 Thread Thomas Huehn
This patch unifies the calculation of Minstrels and Minstrel-HTs per-rate statistic. The new common function minstrel_calc_rate_stats() is called when a statistic update is performed. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de --- net/mac80211/rc80211_minstrel.c| 44

[PATCH v3 07/10] mac80211: restructure per-rate throughput calculation into function

2015-03-17 Thread Thomas Huehn
This patch moves Minstrels and Minstrel-HTs per-rate throughput calculation (EWMA(thr)) into a dedicated function to be called. Therefore the variable unsigned int cur_tp within struct minstrel_rate_stats becomes obsolete. and is removed to free up its space. Signed-off-by: Thomas Huehn

[PATCH v3 06/10] mac80211: improve Minstrel variable function naming

2015-03-17 Thread Thomas Huehn
This patch ensures a consistent usage of variable names for type minstrel_rate_stats to be used as mrs and from type minstrel_rate as mr across both Minstrel Minstrel-HT. In addition some variable and function names got changed to more meaningful ones. Signed-off-by: Thomas Huehn

[PATCH v3 08/10] mac80211: add max. lossless throughput per rate to rc_stats

2015-03-17 Thread Thomas Huehn
This patch adds the new statistic maximum possible lossless throughput to Minstrels and Minstrel-HTs rc_stats (in debugfs). This enables comprehensive comparison between current per-rate throughput and max. achievable per-rate throughput. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de

[PATCH v3 09/10] mac80211: reduce calculation costs of EWMA

2015-03-17 Thread Thomas Huehn
This patch reduces the calculation costs of the EWMA macro from 2x multiplication and 1 addition down to 1x multiplication and 2x additions. This slightly improves performance depending on the CPU architecture. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de ---

[PATCH v3 03/10] mac80211: add new Minstrel statistic output via csv

2015-03-17 Thread Thomas Huehn
This patch adds a new debugfs file rc_stats_csv to output Minstrels statistics in a common csv format that is easy to parse. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de Signed-off-by: Stefan Venz ikstrea...@gmail.com --- net/mac80211/rc80211_minstrel.h | 6 +--

[PATCH v3 02/10] mac80211: enhance readability of Minstrel-HTs rc_stats output

2015-03-17 Thread Thomas Huehn
This patch restructures the rc_stats debugfs table of Minstrel-HT in order to achieve better human readability. A new layout of the statistics and a new header is added. In addition to the old layout there are two new columns of information added: idx - representing the rate index of each rate

[PATCH v3 04/10] mac80211: add new Minstrel-HT statistic output via csv

2015-03-17 Thread Thomas Huehn
This patch adds a new debugfs file rc_stats_csv to output Minstrel-HTs statistics in a common csv format that is easy to parse. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de Signed-off-by: Stefan Venz ikstrea...@gmail.com --- net/mac80211/rc80211_minstrel_ht.h | 1 +

[PATCH v3 01/10] mac80211: enhance readability of Minstrels rc_stats output

2015-03-17 Thread Thomas Huehn
This patch restructures the rc_stats debugfs table of Minstrel in order to achieve better human readability. A new layout of the statistics and a new header is added. In addition to the old layout there are two new columns of information added: idx - representing the rate index of each rate in

[PATCH 00/16 linux-next] drivers/net: constify of_device_id array

2015-03-17 Thread Fabian Frederick
This small patchset adds const to of_device_id arrays in drivers/net branch. Fabian Frederick (16): net: netcp: constify of_device_id array Altera TSE: constify of_device_id array net/fsl: constify of_device_id array net: ethoc: constify of_device_id array drivers: net: xgene: constify

[PATCH] mac80211: stop scan before connection

2015-03-17 Thread Emmanuel Grumbach
From: David Spinadel david.spina...@intel.com Stop scan before authentication or association to make sure that nothing interferes with connection flow. Currently mac80211 defers RX auth and assoc packets (among other ones) until after the scan is complete, so auth during scan is likely to fail

Re: [PATCH 00/16 linux-next] drivers/net: constify of_device_id array

2015-03-17 Thread David Miller
From: Fabian Frederick f...@skynet.be Date: Tue, 17 Mar 2015 19:37:31 +0100 This small patchset adds const to of_device_id arrays in drivers/net branch. Series applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: Broadcom 43340

2015-03-17 Thread Arend van Spriel
On 03/17/15 22:01, Jürgen Bausa wrote: Arend van Sprielarend@... writes: On 03/15/15 21:38, Jürgen Bausa wrote: would be nice, if you could make it clear. Maybe you need to mount it. This is what I found [1]: $ sudo mount -t efivarfs none /sys/firmware/efi/efivars Thanks, that

Re: [PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion

2015-03-17 Thread Joe Perches
On Tue, 2015-03-17 at 08:06 -0400, Nicholas Mc Guire wrote: Converting milliseconds to jiffies by val * HZ / 1000 is technically OK but msecs_to_jiffies(val) is the cleaner solution and handles all corner cases correctly. This is a minor API consolidation only and should make things more

Re: Broadcom 43340

2015-03-17 Thread Dan Williams
On Tue, 2015-03-17 at 21:01 +, Jürgen Bausa wrote: Arend van Spriel arend@... writes: On 03/15/15 21:38, Jürgen Bausa wrote: would be nice, if you could make it clear. Maybe you need to mount it. This is what I found [1]: $ sudo mount -t efivarfs none

[PATCH 10/16 linux-next] orinoco: constify of_device_id array

2015-03-17 Thread Fabian Frederick
of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/net/wireless/orinoco/airport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/orinoco/airport.c

[PATCH] mac80211: filter multicast data packets on AP_VLAN interfaces w/o sta

2015-03-17 Thread Michael Braun
Currently, multicast data packets are dropped on AP interfaces if there are no authorized stations connected. This avoids superflous data packets to be transmitted on air. But when using AP_VLAN, this does not happen, as the current check does not apply to AP_VLAN interfaces. Though, there can

[PATCH] mac80211: fix typo in debug output

2015-03-17 Thread Michael Braun
--- net/mac80211/cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index 74f509c..62007ca 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -2297,7 +2297,7 @@ int __ieee80211_request_smps_ap(struct ieee80211_sub_if_data

Re: [PATCH v3] mac80211: add an intermediate software queue implementation

2015-03-17 Thread Johannes Berg
On Tue, 2015-03-17 at 11:21 +0100, Felix Fietkau wrote: +/** + * DOC: mac80211 software tx queueing + * + * mac80211 provides an optional intermediate queueing implementation designed + * to allow the driver to keep hardware queues short and provide some fairness + * between different

Re: [PATCH v4] mac80211: Get IV len from key conf and not cipher scheme

2015-03-17 Thread Johannes Berg
On Tue, 2015-03-17 at 10:47 +, Cedric Izoard wrote: When a key is installed using a cipher scheme, a new internal flag KEY_FLAG_CIPHER_SCHEME is set. This flag is used on TX path to test for cipher scheme key, instead of testing for sta-cipher_scheme as sta is NULL for bcast/mcast

[PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion

2015-03-17 Thread Nicholas Mc Guire
+ CONFIG_BRCMFMAC=m Patch is agianst 4.0-rc4 (localversion-next is -next-20150317) Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211

[PATCH v4 3/7] ath10k: implement adaptive qcs command

2015-03-17 Thread Michal Kazior
This command will be used to configure multi-channel scheduler in firmware. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi-ops.h | 16 drivers/net/wireless/ath/ath10k/wmi-tlv.c | 30 ++

RE: [PATCH 1/3] mwifiex: add cfg80211 set_default_mgmt_key handler

2015-03-17 Thread Avinash Patil
-Original Message- From: Johannes Berg [mailto:johan...@sipsolutions.net] Sent: Friday, February 13, 2015 11:37 PM To: Avinash Patil Cc: linux-wireless@vger.kernel.org; Amitkumar Karwar; Cathy Luo; Xinming Hu; Li Long Subject: Re: [PATCH 1/3] mwifiex: add cfg80211

Re: [PATCH v3] mac80211: add an intermediate software queue implementation

2015-03-17 Thread Felix Fietkau
On 2015-03-17 12:24, Johannes Berg wrote: On Tue, 2015-03-17 at 11:21 +0100, Felix Fietkau wrote: @@ -1257,6 +1284,8 @@ struct ieee80211_vif { u8 cab_queue; u8 hw_queue[IEEE80211_NUM_ACS]; +struct ieee80211_txq *txq; This is just one txq, the mcast one? Perhaps that should

[PATCH v4 0/7] ath10k: add multi-channel support

2015-03-17 Thread Michal Kazior
New qca6174 with wmi-tlv firmware supports multi-channel operation. To make use of it ath10k needs a few changes: implement mac80211's chanctx API and rework tx queue control a bit. Changes since RFC: * I've sent `ath10k: defer AP self-peer removal wait` separately now because it's not

Re: [PATCH v3] mac80211: add an intermediate software queue implementation

2015-03-17 Thread Johannes Berg
On Tue, 2015-03-17 at 13:04 +0100, Felix Fietkau wrote: @@ -1090,10 +1119,25 @@ void ieee80211_sta_ps_deliver_wakeup(struct sta_info *sta) [...] + drv_wake_tx_queue(local, txqi); + } + } This could be an interesting race. If you wake the queue, and then

[PATCH iw v2 0/4] iw: add scheduled scan support

2015-03-17 Thread Luca Coelho
From: Luciano Coelho luciano.coe...@intel.com This series adds scheduled scan support to the iw tool (finally! ;). In v2, just rebased. Luciano Coelho (4): iw: move generic sched scan parsing code out of net detect iw: implement scheduled scan iw: add support for active scheduled scan

[PATCH iw v2 3/4] iw: add support for active scheduled scan

2015-03-17 Thread Luca Coelho
From: Luciano Coelho luciano.coe...@intel.com Add options to explicitly use active or passive scans on schedule scans (and net-detect). If neither active nor passive parameters are passed, the default is to do active scans with the wildcard SSID. Signed-off-by: Luciano Coelho

[PATCH iw v2 4/4] iw: add randomise option for sched_scan

2015-03-17 Thread Luca Coelho
From: Luciano Coelho luciano.coe...@intel.com Like with normal scans, we can randomise the MAC address sent out in active scheduled scans. Add the randomise option to sched_scan (and net-detect) parsing code. Signed-off-by: Luciano Coelho luciano.coe...@intel.com --- iw.h | 2 +- scan.c |

[PATCH iw v2 2/4] iw: implement scheduled scan

2015-03-17 Thread Luca Coelho
From: Luciano Coelho luciano.coe...@nokia.com Add sched_start, sched_stop and events parsing for scheduled scan. For now, only passive scans are supported. Signed-off-by: Luciano Coelho luciano.coe...@intel.com --- event.c | 9 + info.c | 6 ++ scan.c | 29

RE: ARP dropped during WPA handshake

2015-03-17 Thread voncken
During the initial WPA handshake the connection is not fully set up, and so no general traffic can (nor should) pass between the STA and AP. That includes ARP and any L2/L3+ protocols, except for EAP and wifi management packets. The interface itself must be IFF_UP before it can

[PATCH v4] mac80211: add an intermediate software queue implementation

2015-03-17 Thread Felix Fietkau
This allows drivers to request per-vif and per-sta-tid queues from which they can pull frames. This makes it easier to keep the hardware queues short, and to improve fairness between clients and vifs. The task of scheduling packet transmission is left up to the driver - queueing is controlled by

Re: [PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion

2015-03-17 Thread Arend van Spriel
was compile tested with x86_64_defconfig + CONFIG_BRCMFMAC=m Patch is agianst 4.0-rc4 (localversion-next is -next-20150317) It applies to wireless-drivers-next/master as well so Acked-by: Arend van Spriel ar...@broadcom.com Signed-off-by: Nicholas Mc Guirehof...@osadl.org --- drivers/net/wireless

Re: ARP dropped during WPA handshake

2015-03-17 Thread Dan Williams
On Tue, 2015-03-17 at 16:02 +0100, voncken wrote: During the initial WPA handshake the connection is not fully set up, and so no general traffic can (nor should) pass between the STA and AP. That includes ARP and any L2/L3+ protocols, except for EAP and wifi management packets.