Re: [PATCH 7/7] mac80211: Count correctly interface types

2015-04-01 Thread Janusz Dziedzic
On 12 March 2015 at 07:53, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: From: Andrei Otcheretianski andrei.otcheretian...@intel.com Previously, interface combination check in mac80211 considered only interfaces that have channel context. This wouldn't take P2P device interfaces into

Re: [PATCH 7/7] mac80211: Count correctly interface types

2015-04-01 Thread Arend van Spriel
On 04/01/15 09:12, Johannes Berg wrote: On Wed, 2015-04-01 at 08:06 +0200, Janusz Dziedzic wrote: Hello, Seems this one break IBSS case when started from wpa_supplicant at least for Intel7260 and ath10k where dedicated p2p_device is used. This is wpa_supplicant log: 1427867673.149187:

Re: broadcast ssid in scheduled scan

2015-04-01 Thread Luca Coelho
On Tue, 2015-03-31 at 16:21 +0200, Johannes Berg wrote: On Mon, 2015-03-23 at 19:38 +0100, Arend van Spriel wrote: Johannes, Jouni, I have noticed that under some circumstances wpa_supplicant initiates a scheduled scan with broadcast ssid. This is something our firmware can not do so

Re: [PATCH 7/7] mac80211: Count correctly interface types

2015-04-01 Thread Johannes Berg
On Wed, 2015-04-01 at 08:06 +0200, Janusz Dziedzic wrote: Hello, Seems this one break IBSS case when started from wpa_supplicant at least for Intel7260 and ath10k where dedicated p2p_device is used. This is wpa_supplicant log: 1427867673.149187: nl80211: Set mode ifindex 8 iftype 1

Re: [PATCH v4 0/10] Improve Minstrels Minstrel-HTs common code base statistics

2015-04-01 Thread Johannes Berg
On Wed, 2015-03-25 at 01:16 +0100, Felix Fietkau wrote: On 2015-03-24 21:09, Thomas Huehn wrote: This patch series adds several improvements to the readability, the output format of rc_stats and the calculated statistics of Minstrel and Minstrel-HT. Variable names got more consistent and

Re: broadcast ssid in scheduled scan

2015-04-01 Thread Arend van Spriel
On 04/01/15 08:28, Luca Coelho wrote: On Tue, 2015-03-31 at 16:21 +0200, Johannes Berg wrote: On Mon, 2015-03-23 at 19:38 +0100, Arend van Spriel wrote: Johannes, Jouni, I have noticed that under some circumstances wpa_supplicant initiates a scheduled scan with broadcast ssid. This is

RE: [PATCH v2] cfg80211: Stop calling crda if it is not responsive

2015-04-01 Thread Peer, Ilan
-Original Message- From: Johannes Berg [mailto:johan...@sipsolutions.net] Sent: Wednesday, April 01, 2015 11:51 To: Peer, Ilan Cc: linux-wireless@vger.kernel.org; mcg...@suse.com Subject: Re: [PATCH v2] cfg80211: Stop calling crda if it is not responsive On Mon, 2015-03-30 at

Re: [PATCH 7/7] mac80211: Count correctly interface types

2015-04-01 Thread Johannes Berg
On Wed, 2015-04-01 at 10:36 +0200, Arend van Spriel wrote: I think in latest wpa_s the P2P-Device is always created. There used to be a driver_param to create it. Not sure if that driver_param could still be used to avoid P2P-Device creation. Yeah, I feared this was the case so I added Ilan

Re: [PATCH 7/7] mac80211: Count correctly interface types

2015-04-01 Thread Arend van Spriel
On 04/01/15 10:44, Johannes Berg wrote: On Wed, 2015-04-01 at 10:36 +0200, Arend van Spriel wrote: I think in latest wpa_s the P2P-Device is always created. There used to be a driver_param to create it. Not sure if that driver_param could still be used to avoid P2P-Device creation. Yeah, I

Re: [PATCH v2] cfg80211: Stop calling crda if it is not responsive

2015-04-01 Thread Johannes Berg
On Mon, 2015-03-30 at 15:15 +0300, Ilan Peer wrote: Patch eeca9fce1d71a4955855ceb0c3b13c1eb9db27c1 (cfg80211: Schedule timeout for all CRDA call) introduced a regression, where in case that crda is not installed (or not configured properly etc.), the regulatory core will needlessly continue to

Re: [PATCH v2] cfg80211: Stop calling crda if it is not responsive

2015-04-01 Thread Johannes Berg
On Wed, 2015-04-01 at 09:19 +, Peer, Ilan wrote: Applied, but I put the condition in a place before printing more messages, and changed the messages back to the original ones. But this would miss the update in case that the internal DB is also used. Hm, true, I'll move the

Re: [PATCH] ath: use PRI value given by spec for fixed PRI

2015-04-01 Thread Zefir Kurtisi
On 03/30/2015 07:57 PM, Peter Oh wrote: On 03/30/2015 02:55 AM, Zefir Kurtisi wrote: [...] That's why I believe we need to be very cautious when changing it to fix / improve minor issues. This patch is not for minor fix. Current DFS detector fails on Japan W53 band which requires at least

RE: [PATCH 7/7] mac80211: Count correctly interface types

2015-04-01 Thread Peer, Ilan
Hi, Can you try the attached patch? Set p2p_disabled=1 in your configuration file. Anyway, this is a quick solution, will try to work on a more complete one that also checks the combinations. Ilan. -Original Message- From: Arend van Spriel [mailto:ar...@broadcom.com] Sent:

[PATCH] mac80211: fix RX A-MPDU session reorder timer deletion

2015-04-01 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com There's an issue with the way the RX A-MPDU reorder timer is deleted that can cause a kernel crash like this: * tid_rx is removed - call_rcu(ieee80211_free_tid_rx) * station is destroyed * reorder timer fires before ieee80211_free_tid_rx() runs,

[PATCH] mac80211: fix RX A-MPDU session reorder timer deletion

2015-04-01 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com There's an issue with the way the RX A-MPDU reorder timer is deleted that can cause a kernel crash like this: * tid_rx is removed - call_rcu(ieee80211_free_tid_rx) * station is destroyed * reorder timer fires before ieee80211_free_tid_rx() runs,

Re: [PATCH v2 2/2] ath10k: implement more versatile set_bitrate_mask

2015-04-01 Thread Michal Kazior
On 31 March 2015 at 12:49, Michal Kazior michal.kaz...@tieto.com wrote: Until now only a single fixed tx rate or nss was allowed to be set. The patch attempts to improve this by allowing most bitrate masks. The limitation is VHT MCS rates cannot be expressed separately and only the

Re: [PATCH] mac80211: reduce log spam from ieee80211_handle_pwr_constr

2015-04-01 Thread Johannes Berg
On Tue, 2015-03-31 at 10:49 -0400, John W. Linville wrote: This changes a couple of messages from sdata_info to sdata_dbg. This should reduce some log spam, as reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1206468 Applied, thanks. johannes -- To unsubscribe from this

RE: [PATCH v2] cfg80211: Stop calling crda if it is not responsive

2015-04-01 Thread Peer, Ilan
-Original Message- From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- ow...@vger.kernel.org] On Behalf Of Johannes Berg Sent: Wednesday, April 01, 2015 12:23 To: Peer, Ilan Cc: linux-wireless@vger.kernel.org; mcg...@suse.com Subject: Re: [PATCH v2] cfg80211: Stop

Re: Wireless Module: Carl9170 driver and firmware communication

2015-04-01 Thread Christian Lamparter
Hello, On Tue, Mar 31, 2015 at 2:40 AM, Ashkan Parcham Kashani ashkan.parchamkash...@mail.utoronto.ca wrote: I'm working on a project where I need to communicate some additional control information between the carl9170 driver and firmware. I am not exactly sure where the best place to add this

Re: [PATCH v7] mac80211: add an intermediate software queue implementation

2015-04-01 Thread Johannes Berg
On Fri, 2015-03-27 at 21:30 +0100, Felix Fietkau wrote: This allows drivers to request per-vif and per-sta-tid queues from which they can pull frames. This makes it easier to keep the hardware queues short, and to improve fairness between clients and vifs. The task of scheduling packet

Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-04-01 Thread Robert Dolca
On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz sa...@linux.intel.com wrote: + /* If a patch was applied the new version is checked */ + if (patched) { + r = nci_init(ndev); + if (r) + goto error; + + r =

Re: mediatek mt7630e and ksoftirqd CPU load

2015-04-01 Thread Jakub KiciƄski
On Thu, 26 Mar 2015 11:44:44 -0500, Larry Finger wrote: On 03/26/2015 11:12 AM, George Moutsopoulos wrote: Dear developers, if this is not the right place to post this, sorry for the spam. I haven't filed a bug report yet. Tell me if I should. I am not sure if the problem is something

Re: [PATCH] ath10k: fix survey reporting

2015-04-01 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Number of channels is stored in a separate macro in a header file and channel list is constructed independently. The macro is used to define survey array. This fixes a recent regression introduced after adding support for 144 channel. The

Re: [PATCH] ath10k: core: match wait_for_completion_timeout return type

2015-04-01 Thread Kalle Valo
Nicholas Mc Guire hof...@osadl.org writes: Return type of wait_for_completion_timeout is unsigned long not int. An appropriately named unsigned long is added and the assignments fixed up. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied. -- Kalle Valo -- To unsubscribe

pull-request: wireless-drivers 2015-04-01

2015-04-01 Thread Kalle Valo
Hi Dave, one last pull request for 4.0, I hope I'm not too late on this one. Only one iwlwifi memory leak fix this time. Please let me know if there are any problems. Kalle The following changes since commit 6ae4ccfee09efe5baa3951d1c1d27050a46a1469: Merge tag 'iwlwifi-for-kalle-2014-03-22'

Re: [PATCH] ath10k: mac: match wait_for_completion_timeout return type

2015-04-01 Thread Kalle Valo
Nicholas Mc Guire hof...@osadl.org writes: Return type of wait_for_completion_timeout is unsigned long not int. An appropriately named unsigned long is added, respectively 'ret' renamed, and the assignments fixed up. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied. --

Re: [PATCH v2 2/2] ath10k: implement more versatile set_bitrate_mask

2015-04-01 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 31 March 2015 at 12:49, Michal Kazior michal.kaz...@tieto.com wrote: Until now only a single fixed tx rate or nss was allowed to be set. The patch attempts to improve this by allowing most bitrate masks. The limitation is VHT MCS rates

Re: pull-request: wireless-drivers-next 2015-04-01

2015-04-01 Thread David Miller
From: Kalle Valo kv...@codeaurora.org Date: Wed, 01 Apr 2015 18:03:36 +0300 here's a pull request for 4.1, more info in the signed tag below. Please let me know if you have any problems. Pulled, thanks Kalle. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the

Re: [PATCH] ath10k: fix IBSS scanning on wmi-tlv and qca6174

2015-04-01 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: WLAN.RM.2.0-00073 firmware requires self-peer to be created prior to issuing scan command. Without this wmi-tlv with qca6174 firmware crashes after submitting a scan request. Creating the peer as soon as add_interface() shouldn't be a problem.

Re: [PATCH] ath10k: htc: match wait_for_completion_timeout return type

2015-04-01 Thread Kalle Valo
Nicholas Mc Guire hof...@osadl.org writes: Return type of wait_for_completion_timeout is unsigned long not int. An appropriately named unsigned long is added and the assignments fixed up. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied. -- Kalle Valo -- To unsubscribe

Re: [PATCH] ath10k: don't call quiet mode if it's not implemented

2015-04-01 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: qca6174 and wmi-tlv doesn't have quiet mode implemented. Don't even attempt to call it. This fixes a warning when bringing first interface up: failed to set quiet mode period 100 duarion 0 enabled 0 ret -95 Fixes: 8515b5c79a54 (ath10k:

[PATCH 1/2] staging: vt6655: s_vGenerateTxParameter Replace PSTxBufHead with struct vnt_tx_fifo_head

2015-04-01 Thread Malcolm Priestley
With endian correction on fifo_ctl and current_rate. Removing pTxBufHead, pFifoHead and wFifoCtl Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/rxtx.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git

[PATCH 2/2] staging: vt6655: use ieee80211_tx_info to select packet type.

2015-04-01 Thread Malcolm Priestley
Information for packet type is in ieee80211_tx_info band IEEE80211_BAND_5GHZ for PK_TYPE_11A. IEEE80211_TX_RC_USE_CTS_PROTECT via tx_rate flags selects PK_TYPE_11GB This ensures that the packet is always the right type. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc:

Re: [PATCH] ath10k: core: match wait_for_completion_timeout return type

2015-04-01 Thread Kalle Valo
Nicholas Mc Guire hof...@osadl.org writes: Return type of wait_for_completion_timeout is unsigned long not int. An appropriately named unsigned long is added and the assignments fixed up. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied. -- Kalle Valo -- To unsubscribe

Re: [PATCH v2 0/2] ath10k: improve set_bitrate_mask

2015-04-01 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: This makes set_bitrate_mask more flexible by allowing more than applying simple single rate or max nss limits. This still isn't ideal and VHT MCSs can't be set separately (only a few range-options are allowed). v2: * fix ouf-of-bounds *