In case of one shot NOA the interval could be 0.
This patch fix such dump:
divide error: [#1] SMP
CPU: 4 PID: 0 Comm: swapper/4 Tainted: GW OE
4.3.0-rc3master-2015-10-12-00-hz250-wl-ath+ #27
Hardware name: Dell Inc. Latitude E6430/0H3MT5, BIOS A13 09/02/2013
task:
punit vara writes:
> Will my other patches which are already correct be added to wireless
> tree ? or I have to resend everything ?
Yes, please resend the whole patchset. I don't apply patches
individually from a patchset, it's just too time consuming and error
prone.
Hi Dave,
here's a bigger pull request for 4.4. The diffstat looks scary as we
created a new directory realtek for all realtek drivers. In the future
I'm planning to create similar directories for all vendors, currently we
just have ath, mediatek and realtek. This change has been in linux-next
for
Hi Arnd,
I expect your opinion but I would like to make the patch to revert
the commit bcc43a4b5ed75285aeacf2cf8d9b96d6379fb429 if you don't mind
because the WILC1000 in staging still has compile errors.
Then, we had better make patch for your concerns.
I always appreciate your review and
Add new VIF flag, that will allow get NOA update
notification when driver will request this, even
this is not pure P2P vif (eg. STA vif).
Signed-off-by: Janusz Dziedzic
---
include/net/mac80211.h | 4
net/mac80211/mlme.c| 6 --
2 files changed, 8
From: Leo Kim
This patch removes goto statement and moves the spin lock position.
If a memory allocation fails, directly returns an error.
The spin lock actually protects the pHandle. Therefore, call spin lock just
before pHandle is used.
Signee-eff-by: Lee Kim
Add new argument net_device and use netdev private data member wilc
instead of g_linux_wlan. Pass argument dev to the function as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 3 +--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |
This patch adds new argument struct wilc and use it instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
This patch uses netdev private data member wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
This patch changes function parameter linux_wlan_t nic with net_dev dev and
use netdev private data member wilc instead of nic and g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 16 +++-
1 file changed, 11 insertions(+), 5
This patch adds new argument struct wilc and use it instead of g_linux_wlan.
Pass wilc to the function as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
This patch adds argument struct wilc and pass wilc to the function.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
Use netdev private data member wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
Use netdev private member wilc instead of g_linux_wlan and change argument wilc
with dev in the function request_threaded_irq to pass back to handler
the function isr_uh_routine.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 10 --
1 file
This patch changes function argument with net_device and use netdev private
data member wilc instead of g_linux_wlan. And there are assignment code with
different value continuously. Take last code.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 21
This patch add new argument wilc to wilc_handle_isr and pass wilc to
the function.
It is void type for now because wilc_wlan.c was implemented platform
independently at the beginning (linux_wlan.c is implementation of LINUX part),
so the header file which defines struct wilc cannot be included at
Pass argument dev instead of wilc from kthread_run and use netdev private data
member wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff
This patch uses netdev private data memeber wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
This patch changes function parameter type struct wilc with struct net_device
and use netdev private data member wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 25 +++--
1 file changed, 15 insertions(+),
This patch adds new function argument net_device and pass dev to the functions.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.h | 2 +-
3 files changed, 4
This patch adds argument net_device dev and use netdev private data memeber
wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.c | 11 ---
drivers/staging/wilc1000/wilc_wlan.h
Use netdev private data member wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
This patch changes argument wilc with net_device and use netdev private data
member wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git
This patch adds new argument struct wilc and use it instead of
g_linux_wlan. And also pass wilc to the function.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
This patch adds new argument struct wilc and use it instead of g_linux_wlan.
Pass wilc to wilc_wlan_rxq_remove.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git
This patch add new argument wilc and use it instead of g_wlan_linux.
Declare the function in wilc_wfi_netdevice.h.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 10 +-
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 +
This patch add argument net_device dev and use netdev private data member wilc
instead of g_linux_wlan. Pass argument dev to the function.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 17 ++---
1 file changed, 10 insertions(+), 7
This patch adds new argument struct wilc and use it instead of
g_linux_wlan. Pass argument wilc to the function as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 6 +++---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
This patch adds argument wilc and pass the function wilc. Use wilc instead of
g_linux_wlan and pd.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 13 ++---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
wilc_netdev_init function has parameters to pass but no argument is passed
when bus type SPI is selected. Which causes build error.
This patch passes argument to the function wilc_netdev_init.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 6 +-
1
This patch adds new argument net_device and use netdev private data member
wilc instead of g_linux_wlan. Pass argument dev to the function as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 13 +
1 file changed, 9 insertions(+), 4
This patch add new argument struct net_device *dev and pass net_device to
wilc_wlan_txq_add_net_pkt.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.h | 4 ++--
3
This patch adds new argument struct wilc and use wilc instead of g_linux_wlan.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
Removing supported chainmask fields as it can be always derived
from num_rf_chains.
Signed-off-by: Rajkumar Manoharan
---
drivers/net/wireless/ath/ath10k/core.h | 2 --
drivers/net/wireless/ath/ath10k/mac.c | 17 +
This patch changes return type of host_int_add_wep_key_bss_sta from s32
to int. The result variable gets return value from wilc_mq_send that has
return type of int. It should be changed return type of this function
as well as data type of result variable.
Signed-off-by: Chaehyun Lim
This patch changes u8WepKeylen to len that is third argument of
host_int_add_wep_key_bss_sta to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 5
This patch changes struct host_if_drv of host_int_add_wep_key_bss_sta
function declaration from hWFIDrv to hif_drv.
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim
---
This patch changes u8Keyidx to index that is fourth argument of
host_int_add_wep_key_bss_sta to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3
This patch fixes line over 80 characters found by checkpatch.
WARNING: line over 80 characters
FILE: drivers/staging/wilc1000/host_interface.h:408:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 3 ++-
1 file changed, 2 insertions(+), 1
This patch removes multiple blank lines found by checkpatch.
CHECK: Please don't use multiple blank lines
FILE: drivers/staging/wilc1000/host_interface.c:3175:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)
This patch replaces kmalloc followed by memcpy with kmemdup.
It is also added error checking of kmemdup.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
Hi Glen,
[auto build test WARNING on staging/staging-next -- if it's inappropriate base,
please suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/Glen-Lee/staging-wicl1000-isr_uh_routine-use-netdev-private-wilc/20151027-173115
config: i386
Hi Glen,
[auto build test ERROR on staging/staging-next -- if it's inappropriate base,
please suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/Glen-Lee/staging-wicl1000-isr_uh_routine-use-netdev-private-wilc/20151027-173115
config: i386
This patch changes pu8WepKey to key that is second argument of
host_int_add_wep_key_bss_sta to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3
Move HT and VHT capabiltity setup static functions to avoid
forward declaration.
Signed-off-by: Rajkumar Manoharan
---
drivers/net/wireless/ath/ath10k/mac.c | 280 +-
1 file changed, 140 insertions(+), 140 deletions(-)
diff --git
On Mon, 2015-10-26 at 22:50 +0100, Julien Cubizolles wrote:
> Dan Williams writes:
>
> > On Mon, 2015-10-26 at 16:51 +0100, Julien Cubizolles wrote:
> >> I can't connect anymore to my home wifi since upgrading my machine from
> >> Ubuntu 15.04 to Ubuntuy 15.10. I was previously
This patch is to the host_interface.c that fixes up following
warning by checkpatch:
-prefer eth_broadcast_addr() over memset()
Signed-off-by: Punit Vara
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This is patch to the brcmsmac/main.c that removes unnecessary variable
which was declared to return zero.
This patch fixes up warning reported by coccicheck:
-Unneeded variable: "err". Return "0" on line 3788
Signed-off-by: Punit Vara
---
Remove uncessary repeated arguments with OR(|)
This is patch to the brcmsmac/channel.c file that removes following
warning reported by coccicheck:
-duplicated argument to & or |
Signed-off-by: Punit Vara
---
drivers/net/wireless/brcm80211/brcmsmac/channel.c | 1 -
1 file
This patch is to the carl9170/phy.c file that fixes warning reported by
coccicheck :
WARNING: end returns can be simplified
I have removed unneccessary variable declaration and simply return flow
for carl9170_regwrite_result()
Signed-off-by: Punit Vara
---
This patch is to the zd1201.c file that fixes up warning
reported by coccicheck:
WARNING: end returns can be simplified and declaration on line 1658 can
be dropped
Prefer direct return value instead of writing 2-3 more sentence.
Signed-off-by: Punit Vara
---
This patch is to the 3945-mac.c file that fixes up following warning
by coccicheck:
drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable:
"ret". Return "- EOPNOTSUPP" on line 249
Return -EOPNOTSUPP directly instead of return using ret
Signed-off-by: Punit Vara
On Tue, Oct 27, 2015 at 1:42 PM, Kalle Valo wrote:
> punit vara writes:
>
>> Will my other patches which are already correct be added to wireless
>> tree ? or I have to resend everything ?
>
> Yes, please resend the whole patchset. I don't apply patches
This patch is to the ath5k/eeprom.c that fixes up warning caught by
coccicheck:
-Unneeded variable: "ret". Return "0" on line 1733
Remove unneccesary variable ret created to return zero.
Signed-off-by: Punit Vara
---
drivers/net/wireless/ath/ath5k/eeprom.c | 4 ++--
1
This patch is to the brcmsmac/stf.c that fixes up warning caught by
coccicheck:
-Unneeded variable: "ret_code". Return "0" on line 328
Remove unneccesary variable ret_code created to return zero.
Signed-off-by: Punit Vara
---
drivers/net/wireless/brcm80211/brcmsmac/stf.c
On Sun, 25 Oct 2015 19:32:42 +0100
Rafał Miłecki wrote:
> This cleans main.c a bit and will allow us to compile SoC related code
> conditionally in the future.
Looks good.
Acked-by: Michael Buesch
> +#ifdef CONFIG_SSB_BLOCKIO
I wonder whether we should remove
Like others, I'm having problems with mwifiex_usb on a Surface 2 Pro,
with the latest firmware "driver_version = mwifiex 1.0 (14.68.29.p38)"
and the latest release candidate kernel (4.3.0rc7)
Every 5-10 seconds, even while idle, I'll get a kernel message:
usb 1-2: Rx of mgmt packet failed
On Tue, Oct 27, 2015 at 10:51:39PM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch:
>
> -prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara
> ---
>
Hi Julien,
>Yes, I'm using NetworkManager, version 1.0.4-ubuntu5, and I'm guessing
>it's using wpa_supplicant. I deleted the configuration for this network
>and created it again. The network is configured for WPA in
>NetworkManager but I still get the same error message.
Looks like driver has
This patch is to the htt_rx.c that removes unneeded semicolon which is
reported by coccicheck.
Here semicolon just create empty statement so please remote it.
Signed-off-by: Punit Vara
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
1 file changed, 1 insertion(+), 1
Remove uncessary repeated arguments COMP_EFUSE, COMP_REGD, COMP_CHAN
with OR(|)
This is patch to the debug.c file that removes following warning
reported by coccicheck:
-duplicated argument to & or |
Signed-off-by: Punit Vara
---
drivers/net/wireless/rtlwifi/debug.c | 6
On Sun, 25 Oct 2015 19:32:43 +0100
Rafał Miłecki wrote:
> This allows saving a little of space when not using ssb on Broadcom SoC.
I'm not sure whether it's worth it.
But I don't mind having this anyway.
Acked-by: Michael Buesch
--
Michael
pgpEvtCPoQGTU.pgp
This patch is to the ath10k/wmi.h that removes unneeded semicolon which
is reported by coccicheck.
Here semicolon just create empty statement so please remote it.
Signed-off-by: Punit Vara
---
drivers/net/wireless/ath/ath10k/wmi.h | 2 +-
1 file changed, 1 insertion(+), 1
Amitkumar Karwar writes:
> Hi Julien,
>
>>Yes, I'm using NetworkManager, version 1.0.4-ubuntu5, and I'm guessing
>>it's using wpa_supplicant. I deleted the configuration for this network
>>and created it again. The network is configured for WPA in
>>NetworkManager but I
This patch changes return type of host_int_add_wep_key_bss_ap from s32
to int. The result variable gets return value from wilc_mq_send that has
return type of int. It should be changed return type of this function as
well as data type of result variable.
Signed-off-by: Chaehyun Lim
This patch changes data type of variable i from u8 to int.
It is used as index of an array to print its content. It's better
to use as data type of int.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1
This patch changes struct host_if_drv of host_int_add_wep_key_bss_ap
function declaration from hWFIDrv to hif_drv.
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim
---
This patch changes pu8WepKey to key that is second argument of this
function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4
This patch changes u8WepKeylen to len that is third argument of this
function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 6
This patch changes u8Keyidx to index that is fourth argument of this
function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3
This patch changes u8mode to mode that is fifth argument of this
function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3
This patch changes tenuAuth_type to auth_type that is sixth argument of
this function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3
This patch fixes line over 80 characters found by checkpatch.
WARNING: line over 80 characters
FILE: drivers/staging/wilc1000/host_interface.h:424:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 4 +++-
1 file changed, 3 insertions(+), 1
This patch replaces kmalloc followed by memcpy with kmemdup.
It is also added error checking to return -ENOMEM when kmemdup is
failed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
On Tue, Oct 27, 2015 at 05:33:37PM +0900, Glen Lee wrote:
> From: Leo Kim
>
> This patch removes goto statement and moves the spin lock position.
> If a memory allocation fails, directly returns an error.
> The spin lock actually protects the pHandle. Therefore, call spin lock
From: Kalle Valo
Date: Tue, 27 Oct 2015 10:46:38 +0200
> here's a bigger pull request for 4.4. The diffstat looks scary as we
> created a new directory realtek for all realtek drivers. In the future
> I'm planning to create similar directories for all vendors, currently we
On Tue, Oct 27, 2015 at 06:20:14PM +0900, Glen Lee wrote:
> wilc_netdev_init function has parameters to pass but no argument is passed
> when bus type SPI is selected. Which causes build error.
> This patch passes argument to the function wilc_netdev_init.
>
> Signed-off-by: Glen Lee
77 matches
Mail list logo