Re: Matching crc32 checksums from kernel and user space

2015-11-16 Thread Kalle Valo
Kalle Valo writes: > Hi, > > I want ath10k to print a checksum for the firmware image and include > that to the firmware crash dump file as well. Then I want to print the > same checksum from user space scripts and verify it with the crash dump > file. > > I thought that

10ec:b723 [HP Notebook - 15-ac106na] Wifi unstable NO HTML

2015-11-16 Thread Alan
sorry guys my first bug report [1.] Bug #1516251 10ec:b723 [HP Notebook - 15-ac106na] Wifi unstable [2.] Networks not detected unless router is within 2feet weak signal strength, connection dropping [when it does connect] device dropping [disappearing from NetworkManager] only affects this

[PATCH 09/19] staging/wilc1000: move init/exit functions to driver files

2015-11-16 Thread Arnd Bergmann
The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so this is where the init and exit functions should be. Splitting this up enables further cleanups, including eventually allowing both modules to be built together. Signed-off-by: Arnd Bergmann ---

[PATCH 05/19] staging/wilc1000: use NO_SECURITY instead of NO_ENCRYPT

2015-11-16 Thread Arnd Bergmann
The linux_wlan.c file uses a set of enums from wilc_wlan_if.h, with the exception of the NO_ENCRYPT that comes from wilc_wfi_cfgoperations.h. The two sets of enums clearly have the same intention but are defined a bit different. To prepare to clean up the ones in wilc_wfi_cfgoperations.h, this

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-16 Thread Arnd Bergmann
On Monday 16 November 2015 10:36:47 glen lee wrote: > On 2015년 11월 13일 18:17, Arnd Bergmann wrote: > > On Friday 13 November 2015 16:49:22 glen lee wrote: > >> Hi arnd, > >> > >> I found this. These should be like this. It works fine. > >> + .hif_block_tx_ext = sdio_write, > >> +

[question] Rate control algorithm for mesh

2015-11-16 Thread ferran
Hello everybody, I would like to know if there is a transmit rate control algorithm out there that takes into account the destination MAC address. My setting is like this: [node0]· · · · ·[node1][node2] Where the spaced pattern means a poor connection and the densely dotted

Re: BUG #1516251 10ec:b723 [HP Notebook - 15-ac106na] Wifi unstable

2015-11-16 Thread Larry Finger
On 11/16/2015 06:32 AM, Alan wrote: [1.] Bug #1516251 10ec:b723 [HP Notebook - 15-ac106na] Wifi unstable [2.] Networks not detected unless router is within 2feet weak signal strength, connection dropping [when it does connect] device dropping [disappearing from NetworkManager] only affects

[PATCH] rtlwifi: Delete unnecessary checks before the function call "kfree_skb"

2015-11-16 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 16 Nov 2015 13:12:25 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software.

[PATCH 06/19] staging/wilc1000: avoid static definitions in header

2015-11-16 Thread Arnd Bergmann
The wilc_wfi_cfgoperations.h header defines the ieee80211_txrx_stypes and cipher_suites variables that are only used in wilc_wfi_cfgoperations.c and should not be shared in a header file. This moves over all that data into the .c file, and also moves all the macro definitions from the file that

[PATCH 03/19] staging/wilc1000: use proper naming for global symbols

2015-11-16 Thread Arnd Bergmann
There are many global symbols in the wilc1000 driver, some of them with names like "DEBUG_LEVEL" or "probe" that are not acceptable for globals in the linux kernel as they may easily conflict with other (equally broken) drivers. This renames all the globals that do not already start with wilc or

[PATCH 01/19] staging/wilc1000: remove unused functions

2015-11-16 Thread Arnd Bergmann
A number of symbols in the wilc1000 driver are completely unused and can be removed. This includes two variables that are only written but not read. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/host_interface.c | 295 --

[PATCH 08/19] staging/wilc1000: move wilc_wlan_inp_t into struct wilc

2015-11-16 Thread Arnd Bergmann
wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c to have knowledge of the specific sdio and spi front-ends. This removes the structure and places io_type directly inside the struct wilc. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c

[PATCH 14/19] staging/wilc1000: pass hif operations through initialization

2015-11-16 Thread Arnd Bergmann
The wilc_hif_spi and wilc_hif_sdio structures are part of the bus specific code, and the generic code should have no knowledge of their addresses. This changes the code to reference them only from the bus specific initialization code, which we can then use to split up the driver into separate

[PATCH 04/19] staging/wilc1000: move extern declarations to headers

2015-11-16 Thread Arnd Bergmann
'extern' declarations belong into a header file rather than a .c file, to ensure that the definition matches the declaration. This moves all declarations into a header file that seems most appropriate for it. Signed-off-by: Arnd Bergmann ---

[PATCH 15/19] staging/wilc1000: turn enable_irq/disable_irq into callbacks

2015-11-16 Thread Arnd Bergmann
As a preparation for turning the SDIO side of wilc1000 into a separate module, this removes the last direct caller from the core module into the sdio specific portion. All calls to wilc_sdio_enable_interrupt() and wilc_sdio_disable_interrupt() now go through a function pointer in wilc_hif_func. We

[PATCH 07/19] staging/wilc1000: remove linux_wlan_{device_power,device_detection}

2015-11-16 Thread Arnd Bergmann
The driver provides an interface for custom power management and detection that is meant to be filled by people customizing the driver. The default implementation of this is empty, and we don't actually want people to have to modify the source code. If anybody needs this, they need to describe

[PATCH 12/19] staging/wilc1000: use device pointer for phy creation

2015-11-16 Thread Arnd Bergmann
wilc_create_wiphy tries to get a pointer to a device from the global wilc_sdio_func variable. This is a layering violation and we can use the wilc_dev->dev pointer instead. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 2 +-

[PATCH 18/19] staging/wilc1000: use more regular probing

2015-11-16 Thread Arnd Bergmann
So far, my patches tried to do equivalent conversions of the existing code. This one goes beyond that by restructuring how the devices get probed. In particular, the spi driver no longer creates the netdev until the device is probed, and I've removed the global wilc_sdio_func and wilc_spi_dev

[PATCH] NFC: nci: fix memory leak

2015-11-16 Thread Sudip Mukherjee
In case of invalid number_destination_params we were returning error but we missed releasing cmd. Lets check for the number of parameter before allocating memory so that we don't have a memory leak. Signed-off-by: Sudip Mukherjee --- net/nfc/nci/core.c | 6 +++--- 1 file

[PATCH 17/19] staging/wilc1000: split out bus specific modules

2015-11-16 Thread Arnd Bergmann
The SPI and SDIO specific code is now separate enough that we just need to restructure the Makefile and Kconfig logic a bit and export a couple of symbols from the common module to have separate bus glue drivers. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/Kconfig

[PATCH 13/19] staging/wilc1000: get rid of WILC_SDIO_IRQ_GPIO

2015-11-16 Thread Arnd Bergmann
Whether the SDIO function uses an internal or external interrupt should not be a compiletime decision but be determined at runtime. This changes the code to pass a GPIO number from the init code as early as possible, and leaves just one #ifdef WILC_SDIO_IRQ_GPIO to preserve the previous behavior.

[PATCH 16/19] staging/wilc1000: remove WILC_SDIO/WILC_SPI macros

2015-11-16 Thread Arnd Bergmann
The last remaining user of WILC_SDIO macro checks for the correct time to wait in an interrupt for the PLL to settle. We can replace this with a runtime check and remove both WILC_SDIO and WILC_SPI, as we no longer need conditional compilation based on the hardware type. Signed-off-by: Arnd

[PATCH 11/19] staging/wilc1000: pass io_type to wilc_netdev_init

2015-11-16 Thread Arnd Bergmann
In order to avoid some of the #ifdefs, this passes the io_type and device pointer as an argument to wilc_netdev_init. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 18 -- drivers/staging/wilc1000/linux_wlan_sdio.c| 4 ++--

[PATCH 10/19] staging/wilc1000: unify device pointer

2015-11-16 Thread Arnd Bergmann
struct wilc has two pointers to store the device, one for sdio_func and one for spi_device. By changing the pointer to a 'struct device', we can simplify the logic and avoid a few #ifdefs. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 25

[PATCH 02/19] staging/wilc1000: make symbols static if possible

2015-11-16 Thread Arnd Bergmann
All symbols that are only referenced in the file that defines them can be declared 'static' to avoid namespace pollution, to produce better object code, and to make the source more readable. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/Makefile | 3

[PATCH 00/19 v5] staging/wilc1000 cleanups

2015-11-16 Thread Arnd Bergmann
As suggested by Glen Lee, I'm sending the patches once more with the two one-line fixes in "staging/wilc1000: pass hif operations through initialization". I have rebased on top of today's staging-testing, but no other changes were necessary, so this is otherwise identical to the version that Glen

Matching crc32 checksums from kernel and user space

2015-11-16 Thread Kalle Valo
Hi, I want ath10k to print a checksum for the firmware image and include that to the firmware crash dump file as well. Then I want to print the same checksum from user space scripts and verify it with the crash dump file. I thought that crc32 would be good enough for me but it wasn't that simple

Re: [PATCH] ath10k: poll HTT send completion when CE 5 is unused

2015-11-16 Thread Kalle Valo
Rajkumar Manoharan writes: > commit a70587b3389a ("ath10k: configure copy engine 5 for HTT messages") > moved send completion polling under HTT Rx (CE 5) service routine. For > QCA6174 based devices copy engine 1 (CE 1) is used for HTT Rx instead > of CE 5. So send

linux-wireless rebased (probably for the last time) on 4.4-rc1

2015-11-16 Thread John W. Linville
The wireless-testing tree has been rebased on top of 4.4-rc1. The current head of the tree is eced3b090878ddba643bbed599e6edea4ad90f49. Please update any downstream trees accordingly! It has been almost a year since I turned-over wireless maintenance duties to Johannes and Kalle. At that time I

Re: [PATCH] ath10k: Fix the wrong RX rate idx report at 11G mode

2015-11-16 Thread Kalle Valo
Yanbo Li writes: > The RX rate idx is not correctly for 11G mode OFDM packet. > Because the bitrate table start with CCK index instead of OFDM. > > Signed-off-by: Yanbo Li Applied, thanks. -- Kalle Valo -- To unsubscribe from this list: send

Re: [PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 4addr mode

2015-11-16 Thread Kalle Valo
"Li, Yanbo" writes: >> > + /* The padding bytes's location is different on various chips */ >> > + enum ath10k_loc_4addr_pad loc_4addr_pad; >> >> I think that loc prefix is a bit misleading, it reminds me of >> locationing/positioning etc. What about

Re: [PATCH v1] wil6210: hold wil->mutex while managing vrings

2015-11-16 Thread Kalle Valo
Maya Erez writes: > From: Vladimir Kondratiev > > To prevent race when connect flow may run in parallel with > the disconnect event. > > Scenario leading to the bug is: while running connect flow on the AP, > STA sends disconnect. log

Re: [PATCH] ath10k: poll HTT send completion when CE 5 is unused

2015-11-16 Thread Manoharan, Rajkumar
> > commit a70587b3389a ("ath10k: configure copy engine 5 for HTT messages") > > moved send completion polling under HTT Rx (CE 5) service routine. For > > QCA6174 based devices copy engine 1 (CE 1) is used for HTT Rx instead > > of CE 5. So send completion never be called. This is causing "failed

[PATCH 0/2] ath6kl_sdio: add control of CHIP_PWD_L via GPIO

2015-11-16 Thread Steve deRosier
This set of two patches adds the ablity for ath6kl_sdio to control the CHIP_PWD_L pin on startup and for suspend/wakeup. This is importaint because on some platforms, this is the only way to achieve minimum power consumption. The CHIP_PWD_L pin is used to hold the ath chip in reset and this is the

[PATCH 1/2] ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin

2015-11-16 Thread Steve deRosier
Many ath6k chips have a reset pin, usually labeled CHIP_PWD_L. This pin can be pulled low by the host processor to hold the wifi chip in reset. By holding the chip in reset, the lowest power consumption available can be achieved. This adds a module parameter so the ath6kl_sdio driver can control

Re: [PATCH 0/2] ath6kl_sdio: add control of CHIP_PWD_L via GPIO

2015-11-16 Thread Julian Calaby
Hi Steve, On Tue, Nov 17, 2015 at 4:32 PM, Steve deRosier wrote: > This set of two patches adds the ablity for ath6kl_sdio to control the > CHIP_PWD_L pin on startup and for suspend/wakeup. This is importaint because > on some platforms, this is the only way to achieve

Re: [PATCH 1/2] ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin

2015-11-16 Thread Julian Calaby
Hi Steve, On Tue, Nov 17, 2015 at 4:32 PM, Steve deRosier wrote: > Many ath6k chips have a reset pin, usually labeled CHIP_PWD_L. This pin can > be pulled low by the host processor to hold the wifi chip in reset. By > holding the chip in reset, the lowest power consumption

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-11-16 Thread Johannes Berg
> So maybe add some wrapper that does a pr_info then > a pr_debug for the second and subsequent uses like: > That seems like a bad idea - one might be tricked into think that one saw the current data, but the actually current data is later hidden. johannes -- To unsubscribe from this list:

Re: [PATCH 1/2] ath6kl_sdio: Add reset gpio module parameter for CHIP_PWD_L pin

2015-11-16 Thread kbuild test robot
Hi Steve, [auto build test WARNING on wireless-drivers/master] [also build test WARNING on v4.4-rc1 next-20151117] url: https://github.com/0day-ci/linux/commits/Steve-deRosier/ath6kl_sdio-add-control-of-CHIP_PWD_L-via-GPIO/20151117-133751 base: