If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(),
it calls release_bus() and continues execution. But it leads to double
release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex.
The patch adds return in case of failure.
Found by Linux Driver Verification project
On Fri, Dec 04, 2015 at 04:16:45PM +0300, Dan Carpenter wrote:
> This code causes a static checker warning because we check for
> "if (ret == 0)" but we have already had verified that was true. Clean
> it up a little.
>
> Signed-off-by: Dan Carpenter
Acked-by: Stanislaw Gruszka
--
To unsubscrib
From: chunfan chen
The patch allows user to
1. Enable turbo mode in firmware using
following command.
iw dev mlan0 vendor send 0x005043 0x00 0x01
2. Download configuration data to FW using
following command
iw dev mlan0 vendor send 0x005043 0x01 filename
Signed-off-by: chunfan chen
Signed-off-
EU is not a valid country in db.txt file. Hence regulatory_hint
returns failure if EEPROM provides region code as 0x30. Let's
use FR for 0x30.
Signed-off-by: Amitkumar Karwar
Signed-off-by: Cathy Luo
---
drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
If device has already received country information from
EEPROM, we won't parse AP's country IE and download it to
firmware. We will also set regulatory flags to disable beacon
hints and ignore country IE.
Signed-off-by: Amitkumar Karwar
Signed-off-by: Cathy Luo
---
drivers/net/wireless/marvell/
Driver gets country information from EEPROM during
initialization. We will call regulatory_hint to update
current regulatory domain.
As by default world regulatory domain is selected by
cfg80211, country '00' from EEPROM is ignored.
Signed-off-by: Amitkumar Karwar
Signed-off-by: Cathy Luo
---
d
Even if ADHOC start or join attempt is failed, these commands
are returned with success status by firmware. Actual connection
result is provided inside command response.
This patch parses the adhoc connection result and resets
connection state variables if connection is not successful.
Signed-off
It's been observed that even if firmware returns an error
for a configuration command, we go ahead and start AP.
This patch changes the command type from async to sync
so that threads waits for command response and return
failure start AP.
Signed-off-by: Amitkumar Karwar
Signed-off-by: Cathy Luo
This code was supposed to trigger a BUG() if we truncate the output but
it's off by one so it allows one character to be truncated. Really
drivers shouldn't call BUG_ON() and especially for something minor like
this so I've changed it to a WARN_ON().
Signed-off-by: Dan Carpenter
diff --git a/dr
The current code returns success if prism2_init_local_data() fails, but
we want to return an error code. Also we can remove the bogus
ret initializer because it is wrong and never used.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/wireless/intersil/hostap/hostap_cs.c
b/drivers/net/wir
We already know that "wep_key->key_length" is set so there is no need to
check again. Also the last curly brace was indented too far.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
index a6c8a4f..80f
This code causes a static checker warning because we check for
"if (ret == 0)" but we have already had verified that was true. Clean
it up a little.
Signed-off-by: Dan Carpenter
---
I have preserved the original behavior but it's possible that the
original code was buggy. Please review.
diff -
If the mode is NL80211_IFTYPE_UNSPECIFIED then we return success at the
start of the function so this condition is never true.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/wireless/st/cw1200/sta.c
b/drivers/net/wireless/st/cw1200/sta.c
index 95a7fdb..06321c7 100644
--- a/drivers/net/wi
Adding the right mailing list this time.
On Fri, Dec 4, 2015 at 10:18 AM, Emmanuel Grumbach wrote:
> On Fri, Dec 4, 2015 at 9:35 AM, Emmanuel Grumbach wrote:
>> Hi,
>>
>> On Fri, Dec 4, 2015 at 12:05 AM, Stefan Sperling wrote:
>>> Hi Emmanuel,
>>>
>>> As part of implementing 802.11n support in
14 matches
Mail list logo