Re: [PATCH v2] mwifiex: fw download does not release sdio bus during failure

2016-04-20 Thread Julian Calaby
Hi All, On Wed, Apr 20, 2016 at 2:20 PM, Marty Faltesek wrote: > Signed-off-by: Marty Faltesek This looks right to me. Reviewed-by: Julian Calaby Thanks, Julian Calaby > --- > drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff -

[RESEND] Re: updating carl9170-1.fw in linux-firmware.git

2016-04-20 Thread Christian Lamparter
On Wednesday, April 20, 2016 10:59:44 AM Kalle Valo wrote: > Christian Lamparter writes: > > > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: > >> Christian Lamparter writes: > >> > >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > >> > > >> >> Why even mention anything ab

Re: RSS configuration in iwlwifi

2016-04-20 Thread Johannes Berg
On Wed, 2016-04-20 at 18:05 +0100, Ben Hutchings wrote: >  > I see.  You could make this work when the interface is down and > return -EBUSY if the interface is up. > It's slightly more complicated, since it doesn't just affect a single netdev but possibly more than one (since the table is shared

Re: RSS configuration in iwlwifi

2016-04-20 Thread Ben Hutchings
On Wed, 2016-04-20 at 16:22 +, Grumbach, Emmanuel wrote: > On Wed, 2016-04-20 at 16:47 +0100, Ben Hutchings wrote: > > > > On Wed, 2016-04-20 at 15:30 +, Grumbach, Emmanuel wrote: > > > > > > Hi Ben, > > > > > > > > > Thanks for looking at our code. > > > > > > > > > On Wed, 2016-04-2

Re: ap + adhoc not working with Mwifiex driver for sd8887

2016-04-20 Thread Luana Borgia
Hi Amitkumar, thanks for the quick reply.. That's really sad, I hoped that you came with a way to setup the adhoc in ahdemo, like atheros is doing. :( Do you know if there is any plan to manage this in future? Thanks for all support best regards Luana 2016-04-20 9:18 GMT-05:00 Amitkumar Karwa

[PATCH v2 7/8] ath10k: switch testmode to use ath10k_core_fetch_firmware_api_n()

2016-04-20 Thread Kalle Valo
Now that all firmware-N.bin related are within struct ath10k_fw_file we can switch to use ath10k_core_fetch_firmware_api_n() and delete almost identical ath10k_tm_fetch_utf_firmware_api_2(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c |4 - drivers/net/wireless/a

[PATCH v2 6/8] ath10k: move htt_op_version to struct ath10k_fw_file

2016-04-20 Thread Kalle Valo
Preparation for testmode.c to use ath10k_core_fetch_board_data_api_n(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 12 ++-- drivers/net/wireless/ath/ath10k/core.h |1 + drivers/net/wireless/ath/ath10k/debug.c|2 +- drivers/net/wireless/at

[PATCH v2 8/8] ath10k: remove enum ath10k_swap_code_seg_bin_type

2016-04-20 Thread Kalle Valo
It's not needed for anything so just get rid of it. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c |3 +-- drivers/net/wireless/ath/ath10k/swap.c | 22 ++ drivers/net/wireless/ath/ath10k/swap.h |9 + 3 files changed, 8 insertions(+), 26

[PATCH v2 4/8] ath10k: move fw_features to struct ath10k_fw_file

2016-04-20 Thread Kalle Valo
Preparation for testmode.c to use ath10k_core_fetch_board_data_api_n(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 28 +++- drivers/net/wireless/ath/ath10k/core.h |5 ++--- drivers/net/wireless/ath/ath10k/htt_rx.c |2 +- dri

[PATCH v2 5/8] ath10k: move wmi_op_version to struct ath10k_fw_file

2016-04-20 Thread Kalle Valo
Preparation for testmode.c to use ath10k_core_fetch_board_data_api_n(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 20 ++-- drivers/net/wireless/ath/ath10k/core.h |5 ++--- drivers/net/wireless/ath/ath10k/debug.c|2 +- drivers/net

[PATCH v2 3/8] ath10k: move fw_version inside struct ath10k_fw_file

2016-04-20 Thread Kalle Valo
Preparation for testmode.c to use ath10k_core_fetch_board_data_api_n(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 13 + drivers/net/wireless/ath/ath10k/core.h |3 ++- drivers/net/wireless/ath/ath10k/testmode.c | 12 ++-- 3 files ch

[PATCH v2 2/8] ath10k: refactor firmware images to struct ath10k_fw_components

2016-04-20 Thread Kalle Valo
To make it easier to share ath10k_core_fetch_board_data_api_n() with testmode.c refactor all firmware components to struct ath10k_fw_components. This structure will hold firmware related files, for example firmware-N.bin and board-N.bin. For firmware-N.bin create a new struct ath10k_fw_file which

[PATCH v2 1/8] ath10k: remove deprecated firmware API 1 support

2016-04-20 Thread Kalle Valo
This has ben deprecated years ago, I haven't heard anyone using it since and most likely it won't even work anymore. So just remove all of it. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 73 drivers/net/wireless/ath/ath10k/core.h |

[PATCH v2 0/8] ath10k: refactor firmware components

2016-04-20 Thread Kalle Valo
This series refactors various ath10k firmware components into struct ath10k_fw_components which contains everything firmware related (board files, meta data and so on). This makes it possible to kill ath10k_tm_fetch_utf_firmware_api_2() from testmode.c. Also REALLY old FW API 1 (firmware.bin and o

Re: [PATCH] rt2800usb: enable MFP if hw crypt is disabled

2016-04-20 Thread Yeoh Chun-Yeow
Noted. Patch v2 sent. Chun-Yeow On Thu, Apr 21, 2016 at 12:04 AM, Stanislaw Gruszka wrote: > On Wed, Apr 20, 2016 at 02:59:32PM +0800, Chun-Yeow Yeoh wrote: >> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes >> care of the crypto with software encryption/decryption >> and thus, MFP

[PATCH v2] rt2800lib: enable MFP if hw crypt is disabled

2016-04-20 Thread Chun-Yeow Yeoh
If rt2800usb is loaded with nohwcrypt=1, mac80211 takes care of the crypto with software encryption/decryption and thus, MFP can be used. Tested for secured mesh using ath9k_htc and ath9k. Signed-off-by: Chun-Yeow Yeoh v2: set MFP correctly (Stanislaw Gruszka) --- drivers/net/wireless/ralink/r

Re: RSS configuration in iwlwifi

2016-04-20 Thread Grumbach, Emmanuel
On Wed, 2016-04-20 at 19:22 +0300, Emmanuel Grumbach wrote: > On Wed, 2016-04-20 at 16:47 +0100, Ben Hutchings wrote: > > On Wed, 2016-04-20 at 15:30 +, Grumbach, Emmanuel wrote: > > > Hi Ben, > > > > > > > > > Thanks for looking at our code. > > > > > > > > > On Wed, 2016-04-20 at 16:08 +0

Re: RSS configuration in iwlwifi

2016-04-20 Thread Grumbach, Emmanuel
On Wed, 2016-04-20 at 16:47 +0100, Ben Hutchings wrote: > On Wed, 2016-04-20 at 15:30 +, Grumbach, Emmanuel wrote: > > Hi Ben, > > > > > > Thanks for looking at our code. > > > > > > On Wed, 2016-04-20 at 16:08 +0100, Ben Hutchings wrote: > > > > > > I'm not sure if you were aware, but the

Re: [PATCH] rt2800usb: enable MFP if hw crypt is disabled

2016-04-20 Thread Stanislaw Gruszka
On Wed, Apr 20, 2016 at 02:59:32PM +0800, Chun-Yeow Yeoh wrote: > If rt2800usb is loaded with nohwcrypt=1, mac80211 takes > care of the crypto with software encryption/decryption > and thus, MFP can be used. > > Tested for secured mesh using ath9k_htc and ath9k. > > Signed-off-by: Chun-Yeow Yeoh

Re: RSS configuration in iwlwifi

2016-04-20 Thread Ben Hutchings
On Wed, 2016-04-20 at 15:30 +, Grumbach, Emmanuel wrote: > Hi Ben, > > > Thanks for looking at our code. > > > On Wed, 2016-04-20 at 16:08 +0100, Ben Hutchings wrote: > > > > I'm not sure if you were aware, but there is a standard API for > > configuring RSS in network drivers, part of eth

Re: RSS configuration in iwlwifi

2016-04-20 Thread Grumbach, Emmanuel
Hi Ben, Thanks for looking at our code. On Wed, 2016-04-20 at 16:08 +0100, Ben Hutchings wrote: > I'm not sure if you were aware, but there is a standard API for > configuring RSS in network drivers, part of ethtool_ops. I think > iwlwifi should implement that rather than a driver-specific deb

RSS configuration in iwlwifi

2016-04-20 Thread Ben Hutchings
I'm not sure if you were aware, but there is a standard API for configuring RSS in network drivers, part of ethtool_ops.  I think iwlwifi should implement that rather than a driver-specific debugfs interface. Ben. -- Ben Hutchings Never attribute to conspiracy what can adequately be explained by

[PATCH 3/4] ath10k: Define rx_ppdu_end for QCA9984

2016-04-20 Thread Vasanthakumar Thiagarajan
QCA9984 Rx descriptor has two 32-bit words of location information when compared to one 32-bit word in QCA99X0. To handle this difference in rx descriptor ppdu_end, define a new ppdu_end for QCA9984 descriptor which has the new structure to represent rx_location_info. Signed-off-by: Vasanthakumar

[PATCH 4/4] ath10k: Enable support for QCA9984

2016-04-20 Thread Vasanthakumar Thiagarajan
QCA9984 shares the same configuration with QCA99X0. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath10k/core.c | 23 +++ drivers/net/wireless/ath/ath10k/hw.h | 11 +++ drivers/net/wireless/ath/ath10k/pci.c | 14 ++ 3 files chang

[PATCH 2/4] ath10k: Clean up growing hw checks during safe and full reset

2016-04-20 Thread Vasanthakumar Thiagarajan
Store pci chip secific reset funtions in struct ath10k_pci as callbacks during early ath10k_pci_probe() and use the callback to perform chip specific resets. This patch essentially adds two callback in ath10k_pci, one for doing soft reset and the other for hard reset. By using callbacks we can get

[PATCH 1/4] ath10k: Move rx_location_info out of struct rx_pkt_end

2016-04-20 Thread Vasanthakumar Thiagarajan
Define rx_location_info in struct rx_ppdu_end_qca99x0 after rx_pkt_end. This is to prepare rx_ppdu_end for QCA9984 chip. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath10k/rx_desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless

[PATCH 0/4] Add support for QCA9984

2016-04-20 Thread Vasanthakumar Thiagarajan
This patch set adds QCA9984/QCA9994 1.0 support. Boot sequence is same as QCA99X0. Vasanthakumar Thiagarajan (4): ath10k: Move rx_location_info out of struct rx_pkt_end ath10k: Clean up growing hw checks during safe and full reset ath10k: Define rx_ppdu_end for QCA9984 ath10k: Enable suppo

RE: ap + adhoc not working with Mwifiex driver for sd8887

2016-04-20 Thread Amitkumar Karwar
Hi Luana, > From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Luana Borgia > Sent: Wednesday, April 20, 2016 11:14 AM > To: linux-wireless@vger.kernel.org; Avinash Patil > Subject: Fwd: ap + adhoc not working with Mwifiex driver for sd8887 >

RE: ap + adhoc not working with Mwifiex driver for sd8887

2016-04-20 Thread Amitkumar Karwar
Hi Luana, > From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Luana Borgia > Sent: Wednesday, April 20, 2016 11:14 AM > To: linux-wireless@vger.kernel.org; Avinash Patil > Subject: Fwd: ap + adhoc not working with Mwifiex driver for sd8887 >

Re: [patch] brcmfmac: testing the wrong variable in brcmf_rx_hdrpull()

2016-04-20 Thread Arend Van Spriel
On 19-4-2016 16:25, Dan Carpenter wrote: > Smatch complains about this code: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c:335 > brcmf_rx_hdrpull() > error: we previously assumed '*ifp' could be null (see line 333) > > The problem is that we recently changed these from "ifp

Re: [PATCH v2] carl9170: Clarify kconfig text

2016-04-20 Thread Kalle Valo
Christian Lamparter writes: > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: >> Christian Lamparter writes: >> >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> > >> >> Why even mention anything about a "special firmware" as the firmware is >> >> already available from li