Re: [RFC 5/7] net: Add allocation flag to rtnl_unicast()

On Fri, 2016-07-08 at 12:15 +0900, Masashi Honma wrote: = > Thanks for comment. > > I have selected GFP flags based on existing code. > > I have selected GFP_ATOMIC in inet6_netconf_get_devconf() because > skb was allocated with GFP_ATOMIC. Point is : we should remove GFP_ATOMIC uses as much as

Re: [RFC 5/7] net: Add allocation flag to rtnl_unicast()

On 2016年07月08日 11:56, Eric Dumazet wrote: Managing to mix GFP_ATOMIC and GFP_KERNEL almost randomly as you did in this patch is definitely not good. Further more, RTNL is a mutex, held in control path, designed to allow schedules and waiting for memory under pressure. We do not want to

Re: [RFC 5/7] net: Add allocation flag to rtnl_unicast()

On Wed, 2016-07-06 at 09:28 +0900, Masashi Honma wrote: > Signed-off-by: Masashi Honma > --- > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index a1f6b7b..2b0b994 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -628,7 +628,7 @@ static int

Re: linux-next: build warning after merge of the wireless-drivers-next tree

Hi all, On Fri, 8 Jul 2016 11:32:14 +1000 Stephen Rothwell wrote: > > After merging the wireless-drivers-next tree, today's linux-next build > (arm multi_v7_defconfig, x86_64 allmodconfig) produced this warning: > > drivers/net/wireless/marvell/mwifiex/scan.c: In

linux-next: build warning after merge of the wireless-drivers-next tree

Hi all, After merging the wireless-drivers-next tree, today's linux-next build (arm multi_v7_defconfig, x86_64 allmodconfig) produced this warning: drivers/net/wireless/marvell/mwifiex/scan.c: In function 'mwifiex_cancel_scan': drivers/net/wireless/marvell/mwifiex/scan.c:2031:44: warning:

Re: linux-next: manual merge of the mac80211-next tree with the wireless-drivers-next tree

Hi Kalle, On Thu, 07 Jul 2016 19:10:24 +0300 Kalle Valo wrote: > > Stephen, if it's not too much trouble for you it would be good to CC > linux-wireless on wireless related problems. Not everyone follow lkml > (or linux-next). I have added linux-wireless@vger.kernel.org as

Intel 3168 AC regulatory domain question

Hi folks, While testing Intel 3168 card.  I hit this problem where the driver can't set regulatory domain properly. The iwlmvm driver first tries to get regulatory domain from kernel (iwl_mvm_get_current_regdomain()), and then from bios.  Below are the relevant code from nvm.c, with my debug

Re: [PATCH] mwifiex: mask PCIe interrupts before removal

Brian Norris writes: > Hi, > > On Thu, Jun 30, 2016 at 03:21:02PM -0700, Brian Norris wrote: >> The PCIe driver didn't mask the host interrupts before trying to tear >> down. This causes lockups at reboot or rmmod when using MSI-X on 8997, >> since the MSI handler gets

[PATCH 3.19.y-ckt 19/99] ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 cards.

3.19.8-ckt23 -stable review patch. If anyone has any objections, please let me know. ---8< From: "Vittorio Gambaletta (VittGam)" commit 0f9edcdd88a993914fa1d1dc369b35dc503979db upstream. The Wistron

[PATCH 3.19.y-ckt 18/99] ath9k: Add a module parameter to invert LED polarity.

3.19.8-ckt23 -stable review patch. If anyone has any objections, please let me know. ---8< From: "Vittorio Gambaletta (VittGam)" commit cd84042ce9040ad038e958bc67a46fcfc015c736 upstream. The LED can be

Re: ath10k + iw set bitrates is causing FW crash

On Thu, Jul 7, 2016 at 10:19 PM, Krishna Chaitanya wrote: > Hi, > > I am using ath10k driver with qca988x hw2.0 and trying to limit it to use > VHT MCS0-7 (iw set bitrates vht-mcs-5 2:0-7). > > But the command it causing a FW crash, if it disable HW_HAS_RATE_CONTROL > no

Re: [PATCH] mwifiex: mask PCIe interrupts before removal

Hi, On Thu, Jun 30, 2016 at 03:21:02PM -0700, Brian Norris wrote: > The PCIe driver didn't mask the host interrupts before trying to tear > down. This causes lockups at reboot or rmmod when using MSI-X on 8997, > since the MSI handler gets confused and locks up the system. > > Also tested on

ath10k + iw set bitrates is causing FW crash

Hi, I am using ath10k driver with qca988x hw2.0 and trying to limit it to use VHT MCS0-7 (iw set bitrates vht-mcs-5 2:0-7). But the command it causing a FW crash, if it disable HW_HAS_RATE_CONTROL no crash is observed but it still uses MCS9. tree: wireless-drivers-next:

Re: [PATCH] ath10k: disable wake_tx_queue for older devices

Michal Kazior writes: > Ideally wake_tx_queue should be used regardless as > it is a requirement for reducing bufferbloat and > implementing airtime fairness in the future. > > However some setups (typically low-end platforms > hosting QCA988X) suffer performance

Re: linux-next: manual merge of the mac80211-next tree with the wireless-drivers-next tree

(Adding linux-wireless) Stephen Rothwell writes: > Hi Johannes, > > Today's linux-next merge of the mac80211-next tree got a conflict in: > > drivers/net/wireless/marvell/mwifiex/cmdevt.c > > between commit: > > a9c790ba23eb ("mwifiex: factor out mwifiex_cancel_scan")

[bug report] nfc: st-nci: Move loopback usage from HCI to NCI

Hello Christophe Ricard, The patch 3aacd7fe552b: "nfc: st-nci: Move loopback usage from HCI to NCI" from Apr 30, 2016, leads to the following static checker warning: drivers/nfc/st-nci/vendor_cmds.c:351 st_nci_loopback() error: potentially dereferencing uninitialized 'skb'.

[PATCH] wcn36xx: Silence error about unsupported smd event 188

Sometimes the firmware sends a HAL_DEL_BA_IND, the prima driver silently ignore this message so let's do the same to silence the error message. Cc: Nicolas Dechesne Signed-off-by: Bjorn Andersson ---

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

Hi Johannes, Thanks for the reply. You are right that the physical antenna does not change. When I refer to 'calibration data', it actually corresponding to how mwifiex adjust the per-band tx power. For mwifiex, the per-band tx power is pre-calculated based on need, and stored in DT, a vendor

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm, nvram_file_name dt property

On Thursday, July 7, 2016 11:16:59 AM CEST Arend Van Spriel wrote: > On 7-7-2016 10:46, Arnd Bergmann wrote: > > On Wednesday, July 6, 2016 9:19:41 PM CEST Arend Van Spriel wrote: > >> On 6-7-2016 15:42, Arnd Bergmann wrote: > >>> On Wednesday, July 6, 2016 10:08:55 AM CEST Arend Van Spriel wrote:

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

On 7-7-2016 10:46, Arnd Bergmann wrote: > On Wednesday, July 6, 2016 9:19:41 PM CEST Arend Van Spriel wrote: >> On 6-7-2016 15:42, Arnd Bergmann wrote: >>> On Wednesday, July 6, 2016 10:08:55 AM CEST Arend Van Spriel wrote: On Tue, Jul 5, 2016 at 3:43 PM, Arnd Bergmann wrote:

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

On Wednesday, July 6, 2016 9:19:41 PM CEST Arend Van Spriel wrote: > On 6-7-2016 15:42, Arnd Bergmann wrote: > > On Wednesday, July 6, 2016 10:08:55 AM CEST Arend Van Spriel wrote: > >> On Tue, Jul 5, 2016 at 3:43 PM, Arnd Bergmann wrote: > > All existing uses of the model property