Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-09 Thread Kalle Valo
Hi Mahesh and Andy, James Feeney reported that there's a serious regression in bonding module since v4.12, it doesn't work with wireless drivers anymore as wireless drivers don't report the link speed via ethtool: https://bugzilla.kernel.org/show_bug.cgi?id=196547 In the bug report it's said

Re: wireless drivers fail to report link speed?

2017-08-09 Thread Kalle Valo
(Please don't drop me from CC) James Feeney writes: > @ Kalle Valo > >> Have you reported this on netdev (CCing linux-wireless, David Miller and >> the patch authors)? I think the offending bonding patch should be >> reverted but first it needs to be properly reported on the

Re: wireless drivers fail to report link speed?

2017-08-09 Thread James Feeney
Hey Dan On 08/09/2017 12:25 PM, Dan Williams wrote: > The relevant questions, in my view, are: > > 1) why does the bonding driver now require this information? Well, it *always* required the information. Just now, Mahesh has finally decided "up with this I will not put", not being able to get

[PATCH 1/2] cfg80211: enable setting cqm config for AP mode

2017-08-09 Thread Pradeep Kumar Chitrapu
Enable connection monitoring for AP mode which makes it possible to track signal strength of connected stations. Signed-off-by: Pradeep Kumar Chitrapu --- net/wireless/nl80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c

[PATCH 2/2] mac80211: enable setting cqm config for AP mode

2017-08-09 Thread Pradeep Kumar Chitrapu
Enable connection monitoring for AP mode which makes it possible to track signal strength of connected stations. Signed-off-by: Pradeep Kumar Chitrapu --- net/mac80211/cfg.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Reizer, Eyal [170809 10:40]: > Hi Tony, > > Sorry for top posting (mobile...) > I have verified with system design and the data sheet that every wilink 6/7 > chip has a mac address in fuse so probably the board you have (pretty old, > right?) has this mac address in fuse. Maybe

Re: [PATCH v2 02/20] ath6kl: constify usb_device_id

2017-08-09 Thread Steve deRosier
On Wed, Aug 9, 2017 at 9:23 AM, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: Problem with the wifi

2017-08-09 Thread Arend van Spriel
On 09-08-17 18:40, Larry Finger wrote: On 08/08/2017 04:10 AM, Arend van Spriel wrote: + linux-wireless + Larry please keep linux-wireless in this thread. On 08-08-17 08:21, Paolo Bettini wrote: Arend van Spriel ha scritto: + linux-wireless On 07-08-17 21:38, Paolo Bettini wrote: Hi , i am

Re: pull-request: iwlwifi 2017-08-09

2017-08-09 Thread Kalle Valo
Luca Coelho writes: > Here is the third set of fixes for 4.13. More details in the tag > description. > > This includes both series I sent out, the first one, with v2 of the > second patch, with an improved commit message, and the second one, which > contains the mac80211 patch

Re: wireless drivers fail to report link speed?

2017-08-09 Thread Dan Williams
On Wed, 2017-08-09 at 11:01 -0600, James Feeney wrote: > @ Dan Williams > > > I'm not really arguing against updating mac80211 to report this > > information if somebody actually wants to do the patch.  I'm only > > saying that even with the patch, it's not going to do exactly what > > you > >

[PATCH v3 12/19] iwlwifi: mvm: support new beacon template command

2017-08-09 Thread Luca Coelho
From: Haim Dreyfuss Support a new version of the beacon template command. This replaces v8 of the command, which was missing the rate code. Also, export rate decision logic to a separate function. Signed-off-by: Haim Dreyfuss Signed-off-by:

[PATCH] NFC: nfcmrvl: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/nfc/nfcmrvl/usb.c | 2 +- 1 file changed, 1

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Tony Lindgren [170809 10:26]: > * Reizer, Eyal [170809 00:55]: > > --- a/drivers/net/wireless/ti/wlcore/main.c > > +++ b/drivers/net/wireless/ti/wlcore/main.c > > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl) > > nic_addr =

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Reizer, Eyal [170809 00:55]: > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl) > nic_addr = wl->fuse_nic_addr + 1; > } > > + if (oui_addr

Re: wireless drivers fail to report link speed?

2017-08-09 Thread James Feeney
On 08/09/2017 03:30 AM, Arend van Spriel wrote: >> That seems a little over-broad, at least certainly with respect to "half >> duplex". If the link is known to be half duplex, then the kernel ethtool can >> simply report that the link is "half duplex". I am not hearing a good >> justification,

Re: [v5] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Tony Lindgren
* Reizer, Eyal [170809 00:26]: > Managed to test with a wilink6 module and in fact reading hardware mac > Address from fuse is working ok for wilink6/7 as well. > submitting v6 using this mac address instead of a random one when the > bogus (deadbeef...) mac address is read from

Re: Problem with the wifi

2017-08-09 Thread Larry Finger
On 08/08/2017 04:10 AM, Arend van Spriel wrote: + linux-wireless + Larry please keep linux-wireless in this thread. On 08-08-17 08:21, Paolo Bettini wrote: Arend van Spriel ha scritto: + linux-wireless On 07-08-17 21:38, Paolo Bettini wrote: Hi , i am Paolo and i installed Debian stretch on

[PATCH v2 15/20] rt73usb: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 13/20] rt2500usb: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 17/20] rtl8xxxu: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 20/20] zd1211rw: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 19/20] zd1201: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 18/20] rtl8192cu: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 16/20] rtl8187: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 14/20] rt2800usb: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 10/20] libertas_tf: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 12/20] mt7601u: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 11/20] mwifiex: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 09/20] libertas: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 08/20] p54: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 07/20] orinoco: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 02/20] ath6kl: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 05/20] at76c50x: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 04/20] carl9170: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 03/20] ath9k: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

[PATCH v2 00/20] constify wireless usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Arvind Yadav (20): [PATCH v2 01/20] ar5523: constify usb_device_id [PATCH v2 02/20] ath6kl: constify usb_device_id

Re: brcm43430 sdio wifi regression with 4.13-rc1

2017-08-09 Thread russianneuroman...@ya.ru
Hello! > There are three patches currently in wireless tree, maybe also in netdev > tree, which will probably be included in 4.13-rc4 fixing the issue below. With Linux 4.13rc4 issue is no longer reproducible on Lenovo Miix2 8. 03.08.2017, 05:05, "Arend van Spriel"

Re: wireless drivers fail to report link speed?

2017-08-09 Thread Dan Williams
On Tue, 2017-08-08 at 18:36 -0600, James Feeney wrote: > Hey > > On 08/08/2017 04:49 PM, Ben Greear wrote: > > > > Some time back, I added some support to ath10k to report some > > ethtool info. > > At least most of this is upstream.  I do report rx and rx link > > rate, and yes, > > it changes,

Re: wireless drivers fail to report link speed?

2017-08-09 Thread Arend van Spriel
On 8/9/2017 2:36 AM, James Feeney wrote: Hey [...] On 08/08/2017 05:43 PM, Dan Williams wrote: It's very relevant to the question. Because if the speed is actually not useful for the requested purpose, there is no real point in having it reported it via ethtool. Same for duplex. Wifi

Re: [PATCH v4 01/10] wil6210: protect against invalid length of tx management frame

2017-08-09 Thread Arend van Spriel
On 8/3/2017 9:08 PM, Maya Erez wrote: From: Hamad Kadmany Validate buffer length has the minimum needed size when sending management frame to protect against possible buffer overrun. I noticed this is already applied, but I saw this subject text which has

[v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Reizer, Eyal
The following commits: commit c815fdebef44 ("wlcore: spi: Populate config firmware data") commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well for specifying an alternate mac address.

pull-request: iwlwifi 2017-08-09

2017-08-09 Thread Luca Coelho
Hi Kalle, Here is the third set of fixes for 4.13. More details in the tag description. This includes both series I sent out, the first one, with v2 of the second patch, with an improved commit message, and the second one, which contains the mac80211 patch as well. I have sent this out before

Re: [PATCH v2 4/19] iwlwifi: mvm: add debugfs to force CT-kill

2017-08-09 Thread Kalle Valo
Luca Coelho writes: > From: Chaya Rachel Ivgi > > CT-kill is a thermal-based "RF-kill", which disables the NIC > completely if the temperature gets too high, in order to avoid damage. > > Add a debugfs entry to simulate high temperatures, in order to

Re: [PATCH v2 2/3] iwlwifi: mvm: start mac queues when deferred tx frames are purged

2017-08-09 Thread Kalle Valo
Luca Coelho writes: > From: Avraham Stern > > In AP mode, if a station is removed just as it is adding a new stream, > the queue in question will remain stopped and no more TX will happen > in this queue, leading to connection failures and other

RE: [v5] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Reizer, Eyal
> > > Subject: Re: [v5] wlcore: add missing nvs file name info for wilink8 > > > > * Reizer, Eyal [170807 00:47]: > > > Hi Tony, > > > > > > > > * Reizer, Eyal [170807 00:32]: > > > > > The following commits: > > > > > c815fde wlcore: spi: Populate config firmware

[PATCH 1/2] mac80211: add api to start ba session timer expired flow

2017-08-09 Thread Luca Coelho
From: Naftali Goldstein Some drivers handle rx buffer reordering internally (and by extension handle also the rx ba session timer internally), but do not ofload the addba/delba negotiation. Add an api for these drivers to properly tear-down the ba session, including

[PATCH 2/2] iwlwifi: mvm: send delba upon rx ba session timeout

2017-08-09 Thread Luca Coelho
From: Naftali Goldstein When an RX block-ack session times out, the firmware, which offloads RX reordering but not the BA session negotiation, stops the session but doesn't send a DELBA. This causes the the session to remain active in the remote device, so no more

[PATCH 0/2] iwlwifi: one more fix intended for 4.13 2017-08-09

2017-08-09 Thread Luca Coelho
From: Luca Coelho Hi, This is the mac80211+iwlwifi fix we talked about earlier. As I mentioned, the iwlwifi patch fixes a severe degradation of throughput in the 9000 device series, due to a BA-session getting stuck and the lack of future aggregation. The mac80211

[PATCH v2 12/19] iwlwifi: mvm: support new beacon template command

2017-08-09 Thread Luca Coelho
From: Haim Dreyfuss Support a new version of the beacon template command. This replaces v8 of the command, which was missing the rate code. Also, export rate decision logic to a separate function. Signed-off-by: Haim Dreyfuss Signed-off-by:

[PATCH v2 4/19] iwlwifi: mvm: add debugfs to force CT-kill

2017-08-09 Thread Luca Coelho
From: Chaya Rachel Ivgi CT-kill is a thermal-based "RF-kill", which disables the NIC completely if the temperature gets too high, in order to avoid damage. Add a debugfs entry to simulate high temperatures, in order to test CT-kill flows in the driver without having

[PATCH v2 2/3] iwlwifi: mvm: start mac queues when deferred tx frames are purged

2017-08-09 Thread Luca Coelho
From: Avraham Stern In AP mode, if a station is removed just as it is adding a new stream, the queue in question will remain stopped and no more TX will happen in this queue, leading to connection failures and other problems. This is because under DQA, when tx is