Re: [for-4.14, 1/2] brcmfmac: add length check in brcmf_cfg80211_escan_handler()

2017-09-19 Thread Kalle Valo
Arend Van Spriel wrote: > Upon handling the firmware notification for scans the length was > checked properly and may result in corrupting kernel heap memory > due to buffer overruns. This fix addresses CVE-2017-0786. > > Cc: sta...@vger.kernel.org # v4.0.x > Cc:

Re: [PATCH 2/2] mwifiex: print URB submit failure error after threshold attemtps

2017-09-19 Thread Kalle Valo
Brian Norris writes: > Hi Ganapathi, > > On Thu, Sep 14, 2017 at 02:14:24PM +, Ganapathi Bhat wrote: >> > On Thu, 2017-08-31 at 01:21 +0530, Ganapathi Bhat wrote: >> > > @@ -300,9 +300,16 @@ static int mwifiex_usb_submit_rx_urb(struct >> > urb_context *ctx, int

[PATCH] ath10k: fix core PCI suspend when WoWLAN is supported but disabled

2017-09-19 Thread Brian Norris
For devices where the FW supports WoWLAN but user-space has not configured it, we don't do any PCI-specific suspend/resume operations, because mac80211 doesn't call drv_suspend() when !wowlan. This has particularly bad effects for some platforms, because we don't stop the power-save timer, and if

[PATCH] mwifiex: make const array tos_to_ac static, reduces object code size

2017-09-19 Thread Colin King
From: Colin Ian King Don't populate the read-only const array tos_to_ac on the stack, instead make it static. Makes the object code smaller by 250 bytes: Before: textdata bss dec hex filename 261042720 128 289527118 wmm.o After:

[PATCH] ath9k: make const array reg_hole_list static, reduces object code size

2017-09-19 Thread Colin King
From: Colin Ian King Don't populate the read-only array reg_hole_list on the stack, instead make it static. Makes the object code smaller by over 200 bytes: Before: textdata bss dec hex filename 57518 15248 0 72766 11c3e debug.o

Re: pull-request: mac80211 2017-11-19

2017-09-19 Thread David Miller
From: Johannes Berg Date: Tue, 19 Sep 2017 09:20:47 +0200 > Here's a new set of two small changes to prevent null pointer > dereferences on malformed netlink messages. > > Please pull and let me know if there's any problem. Pulled, thank you.

Re: [PATCH 2/2] mwifiex: use get_random_mask_addr() helper

2017-09-19 Thread Brian Norris
Hi, On Tue, Sep 19, 2017 at 05:30:06PM +0300, Kalle Valo wrote: > Ganapathi Bhat writes: > > > Hi Kalle, > >> > >> > Avoid calculating random MAC address in driver. Instead make use of > >> > 'get_random_mask_addr()' function. > >> > > >> > Signed-off-by: Ganapathi Bhat

Re: [PATCH] mac80211_hwsim: enabling WDS

2017-09-19 Thread Johannes Berg
Hi, > I'm developing an wireless emulator > (https://github.com/intrig-unicamp/mininet-wifi) which relies on > mac80211_hwsim for loading virtual wireless interfaces. In order to > get access points wirelessly connected I was think to enable WDS (in > addition to the well known mesh mode). Why

Re: [PATCH] rsi: sdio suspend and resume support

2017-09-19 Thread Kalle Valo
Amitkumar Karwar writes: > From: Karun Eagalapati > > SDIO suspend and resume handlers are implemented and verified > that device works after suspend/resume cycle. > > Signed-off-by: Karun Eagalapati > Signed-off-by: Amitkumar

Re: [PATCH] rsi: add driver and firmware version info

2017-09-19 Thread Kalle Valo
Amitkumar Karwar writes: > From: Pavani Muthyala > > We will dump information about driver and firmware versions, > firmware file name and operating mode during initialization. > > Signed-off-by: Pavani Muthyala

Re: [PATCH 2/2] mwifiex: use get_random_mask_addr() helper

2017-09-19 Thread Kalle Valo
Ganapathi Bhat writes: > Hi Kalle, >> >> > Avoid calculating random MAC address in driver. Instead make use of >> > 'get_random_mask_addr()' function. >> > >> > Signed-off-by: Ganapathi Bhat >> >> I don't see 1/2 anywhere. Did it get lost? > > Actually

[PATCH] nfc: s3fwrn5: make array match static const, reduces object code size

2017-09-19 Thread Colin King
From: Colin Ian King Don't populate the read-only array match on the stack, instead make it static const. Makes the object code smaller by over 310 bytes: Before: textdata bss dec hex filename 83041084 1289516252c

Re: [PATCH 1/2] mac80211: Add rcu read side critical sections

2017-09-19 Thread Ville Syrjälä
On Mon, Sep 18, 2017 at 10:11:17PM +0200, Johannes Berg wrote: > > I got the following lockdep warning about the rcu_dereference()s in > > ieee80211_tx_h_select_key(). After tracing all callers of > > ieee80211_tx_h_select_key() I discovered that > > ieee80211_get_buffered_bc() > > and

[PATCH] wcn36xx: Disable 5GHz for wcn3620

2017-09-19 Thread Loic Poulain
wcn3620 can only operate on 2.4GHz band due to RF limitation. If wcn36xx digital block is associated with an external IRIS RF module, retrieve the id and disable 5GHz band in case of wcn3620 id. Signed-off-by: Loic Poulain --- drivers/net/wireless/ath/wcn36xx/main.c

[PATCH] mac80211_hwsim: enabling WDS

2017-09-19 Thread Ramon Fontes
Hi, I'm developing an wireless emulator (https://github.com/intrig-unicamp/mininet-wifi) which relies on mac80211_hwsim for loading virtual wireless interfaces. In order to get access points wirelessly connected I was think to enable WDS (in addition to the well known mesh mode). Then, I went

Re: [TDLS PATCH V3 1/5] mac80211: Enable TDLS peer buffer STA feature

2017-09-19 Thread Arend van Spriel
On 19-09-17 10:15, Johannes Berg wrote: On Tue, 2017-09-19 at 09:56 +0200, Arend van Spriel wrote: --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -3249,6 +3249,8 @@ struct cfg80211_ops { * beaconing mode (AP, IBSS, Mesh, ...). * @WIPHY_FLAG_HAS_STATIC_WEP: The device

[PATCH] cfg80211: remove unused function ieee80211_data_from_8023()

2017-09-19 Thread Johannes Berg
From: Johannes Berg This function hasn't been used since the removal of iwmc3200wifi in 2012. It also appears to have a bug when qos=True, since then it'll copy uninitialized stack memory to the SKB. Just remove the function entirely. Reported-by: Jouni Malinen

Re: rtl8821ae keep alive not set, connection lost

2017-09-19 Thread James Cameron
On Thu, Sep 14, 2017 at 07:27:39PM +1000, James Cameron wrote: > On Wed, Sep 13, 2017 at 07:39:35PM -0500, Larry Finger wrote: > > On 09/13/2017 04:46 PM, James Cameron wrote: > > > > > >I'll give it some more testing and let you know, but it seems as > > >capable of keeping a connection as 4.13

Re: [TDLS PATCH V3 1/5] mac80211: Enable TDLS peer buffer STA feature

2017-09-19 Thread Johannes Berg
On Tue, 2017-09-19 at 09:56 +0200, Arend van Spriel wrote: > > > --- a/include/net/cfg80211.h > > +++ b/include/net/cfg80211.h > > @@ -3249,6 +3249,8 @@ struct cfg80211_ops { > >    *beaconing mode (AP, IBSS, Mesh, ...). > >    * @WIPHY_FLAG_HAS_STATIC_WEP: The device supports static WEP

Re: [TDLS PATCH V3 1/5] mac80211: Enable TDLS peer buffer STA feature

2017-09-19 Thread Arend van Spriel
On 19-09-17 05:15, yint...@qti.qualcomm.com wrote: From: Yingying Tang Enable TDLS peer buffer STA feature. Set extended capability bit to enable buffer STA when driver support it. Signed-off-by: Yingying Tang --- include/net/cfg80211.h |

pull-request: mac80211 2017-11-19

2017-09-19 Thread Johannes Berg
Hi Dave, Here's a new set of two small changes to prevent null pointer dereferences on malformed netlink messages. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 126f760ca94dae77425695f9f9238b731de86e32: rds: Fix incorrect